[LLVMdev] RFC: llvm-convert.cpp Patch

[Bill Wendling]

On 11/7/07, Dale Johannesen <dalej at apple.com> wrote:
>
> OK then, it looks like other people have made the points I was going
> to, but briefly:
>
> Using DECL_USER_ALIGN is wrong; that is for user-specified
> alignments, and if
> you use it for something else, you'll break that.
>
Okay.

> The alignment on memcpy needs to take both the source & destination
> into account.

I agree. But I was thinking that there was a more fundamental problem,
i.e. that GCC was changing the alignment of the constructor without
taking the destination's alignment into account -- that is, it's not
changing the destination's alignment and/or checking it beforehand.

> You seem to have gotten this far.  Unfortunately that bit of llvm-
> convert is a maze of
> recursive little passages,

Tell me about it! ;-)

>  but your last patch seems to be thinking along the right lines.
>
:-)

-bw