[LLVMdev] Advice on a VStudio specific patch
sabre at nondot.org
Thu May 31 15:59:52 PDT 2007
On Thu, 31 May 2007, Chuck Rose III wrote:
> Our project is cross platform and on Windows we use VStudio 2005.
> VStudio presents a couple of issues related around it's STL
> implementation and also it's non-respect for the no-return semantic of
Ok. We want the source to be portable, so it's goodness to get these
fixes into the main tree.
> I've fixed it locally, but I'd like to send a patch so I don't have to
> do this every time I update from the source repository. So.... if I'm
> fixing something for a specific compiler, do you think I should just do
> so for all compilers or should I put the differences in a #ifdef check
> for VStudio?
Can you send one example of what you're thinking of? We prefer to keep
the main code #ifdef free, moving compiler-specific code to
include/llvm/Support/Compiler.h. Depending on what you mean, this may or
may not make sense though :)
More information about the llvm-dev