[LLVMdev] API design

David Greene dag at cray.com
Tue Jul 3 13:25:26 PDT 2007


On Tuesday 03 July 2007 10:58, David Greene wrote:

> > Here's a different suggestion that cloning all the code.  Instead of
> > doing that, why not add a new (templated) CallInst ctor, one which is
> > very trivial.  Then you could put the conditional code in it (to detect
> > an empty range) and call into the non-inline stuff we already have.
> >
> > It should be fine to only support random access iterators, so you could
> > call into the existing stuff that takes a base + size.
>
> That's pretty close to what I was thinking.  I think it's a good solution.

I'm happy to go do this but I'm wondering if we should include some 
concept-checking code or something equivalent to ensure that we're
passed random access iterators.

What do you all think?

                                             -Dave



More information about the llvm-dev mailing list