[LLVMdev] Files to lib/System/Win32

Jeff Cohen jeffc at jolt-lang.org
Sat Sep 18 12:01:13 PDT 2004


Here's my first take on Path.cpp.  It has a few holes still but it ought
to be basically functional.

A few observations:

First, the Win32 version still has a lot of code in common with Unix. 
This code should be pulled out into a common file.

Second, some of the functions leave me scratching me head.  What purpose
does create_file serve?  Is there really a need to create empty files?
(It also leaks an open file handle, BTW).  I would expect set_file to
alter only the file name portion of the path and leave the directory
portion unchanged, and the opposite for set_directory.  set_directory
obliterates the file name portion of the path (OK, I guess) but set_file
doesn't make any sense at all.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Path.diff
Type: application/octet-stream
Size: 10799 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20040918/681287f5/attachment.obj>


More information about the llvm-dev mailing list