[LLVMdev] Files to lib/System/Win32

[Reid Spencer]

Henrik,

The patches you submitted will not work (at all) for the Win32 platform
because they (still) use Unix system calls. Win32 doesn't have mkdtemp,
fork, execve, etc. Furthermore in Path.cpp forward slashes are still
used. These need to be changed to back slashes. 

So, I'm not familiar with mingw platform. Since you've stated they
compile on your mingw platform, I'm assuming mingw is some kind of Unix
clone like cygwin. That raises for me the issue of whether we really
want to support *another* Unix interface on Windows. We are already
supporting cygwin and Interix.

So, would you consider using cygwin or Interix instead of mingw? If not,
then I will place your patches into a lib/System/MingW directory and you
can provide the implementation there. If you want to go that way you'll
need to make some corrections to your patches. The main one is that
you've replicated the generic Unix code into the Path.cpp file. Instead
of doing that, I would prefer it if you #included it so we don't have
duplicate Unix code all over the place. 

Thanks,

Reid.
 
On Mon, 2004-09-13 at 17:11, Henrik Bach wrote:
> Hi
> 
> Here is my first patches to the Win32 platform.
> 
> They compile on the mingw platform.
> 
> I haven't test them yet, but I thought it will best to put them in the save, 
> just in case...
> 
> 
> /Henrik
> 
> _________________________________________________________________
> F alle de nye og sjove ikoner med MSN Messenger http://messenger.msn.dk/
> 
> ______________________________________________________________________
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://mail.cs.uiuc.edu/mailman/listinfo/llvmdev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20040913/5498bd6a/attachment.sig>