<html><head><meta http-equiv="content-type" content="text/html; charset=us-ascii"></head><body style="overflow-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;"><div><br></div><p dir="auto" style="box-sizing: border-box; margin-bottom: 16px; caret-color: rgb(31, 35, 40); color: rgb(31, 35, 40); font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Noto Sans", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"; font-size: 14px; margin-top: 0px !important;"><br></p><div><br><blockquote type="cite"><div>On Jul 18, 2023, at 00:47, Arthur Eubanks via llvm-commits <llvm-commits@lists.llvm.org> wrote:</div><br class="Apple-interchange-newline"><div><div><br>Author: Arthur Eubanks<br>Date: 2023-07-17T15:46:38-07:00<br>New Revision: f2ab8f43800ff14051213bff40d35406691f29b0<br><br>URL: https://github.com/llvm/llvm-project/commit/f2ab8f43800ff14051213bff40d35406691f29b0<br>DIFF: https://github.com/llvm/llvm-project/commit/f2ab8f43800ff14051213bff40d35406691f29b0.diff<br><br>LOG: [llvm-reduce] Reduce global value linkage<br><br>Added: <br> llvm/test/tools/llvm-reduce/reduce-linkage.ll<br><br>Modified: <br> llvm/tools/llvm-reduce/deltas/ReduceGlobalValues.cpp<br><br>Removed: <br><br><br><br>################################################################################<br>diff --git a/llvm/test/tools/llvm-reduce/reduce-linkage.ll b/llvm/test/tools/llvm-reduce/reduce-linkage.ll<br>new file mode 100644<br>index 00000000000000..e7f35245194c41<br>--- /dev/null<br>+++ b/llvm/test/tools/llvm-reduce/reduce-linkage.ll<br>@@ -0,0 +1,22 @@<br>+; Test that llvm-reduce can remove function linkage.<br>+;<br>+; RUN: llvm-reduce --abort-on-invalid-reduction --delta-passes=global-values --test FileCheck --test-arg --check-prefixes=CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s -o %t<br>+; RUN: FileCheck --check-prefix=CHECK-FINAL --implicit-check-not=internal %s < %t<br>+<br>+; CHECK-INTERESTINGNESS: define<br>+; CHECK-INTERESTINGNESS-SAME: void @f<br>+<br>+; CHECK-FINAL: define void @f()<br>+<br>+define void @f() {<br>+ ret void<br>+}<br>+<br>+; CHECK-INTERESTINGNESS: define<br>+; CHECK-INTERESTINGNESS-SAME: void @g<br>+<br>+; CHECK-FINAL: define void @g()<br>+<br>+define internal void @g() {<br>+ ret void<br>+}<br></div></div></blockquote></div><br><div><br></div><div><br></div><div><br></div><div><p dir="auto" style="box-sizing: border-box; margin-bottom: 16px; caret-color: rgb(31, 35, 40); color: rgb(31, 35, 40); font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Noto Sans", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"; font-size: 14px; margin-top: 0px !important;">Unfortunately the added test will fail if the path to <code class="notranslate" style="box-sizing: border-box; font-family: ui-monospace, SFMono-Regular, "SF Mono", Menlo, Consolas, "Liberation Mono", monospace; font-size: 11.9px; padding: 0.2em 0.4em; margin: 0px; white-space: break-spaces; border-radius: 6px;">llvm-project</code> contains any directory that contains <code class="notranslate" style="box-sizing: border-box; font-family: ui-monospace, SFMono-Regular, "SF Mono", Menlo, Consolas, "Liberation Mono", monospace; font-size: 11.9px; padding: 0.2em 0.4em; margin: 0px; white-space: break-spaces; border-radius: 6px;">internal</code>.</p><p dir="auto" style="box-sizing: border-box; margin-top: 0px; caret-color: rgb(31, 35, 40); color: rgb(31, 35, 40); font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Noto Sans", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"; font-size: 14px; margin-bottom: 0px !important;">IIUC <code class="notranslate" style="box-sizing: border-box; font-family: ui-monospace, SFMono-Regular, "SF Mono", Menlo, Consolas, "Liberation Mono", monospace; font-size: 11.9px; padding: 0.2em 0.4em; margin: 0px; white-space: break-spaces; border-radius: 6px;">--implicit-check-not</code> could just be dropped, as you explicitly check the <code class="notranslate" style="box-sizing: border-box; font-family: ui-monospace, SFMono-Regular, "SF Mono", Menlo, Consolas, "Liberation Mono", monospace; font-size: 11.9px; padding: 0.2em 0.4em; margin: 0px; white-space: break-spaces; border-radius: 6px;">define void @g()</code>?</p><p dir="auto" style="box-sizing: border-box; margin-top: 0px; caret-color: rgb(31, 35, 40); color: rgb(31, 35, 40); font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Noto Sans", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"; font-size: 14px; margin-bottom: 0px !important;"><br></p><p dir="auto" style="box-sizing: border-box; margin-top: 0px; caret-color: rgb(31, 35, 40); color: rgb(31, 35, 40); font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Noto Sans", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"; font-size: 14px; margin-bottom: 0px !important;">Cheers,</p><p dir="auto" style="box-sizing: border-box; margin-top: 0px; caret-color: rgb(31, 35, 40); color: rgb(31, 35, 40); font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Noto Sans", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"; font-size: 14px; margin-bottom: 0px !important;">Florian</p></div></body></html>