<div dir="ltr">In this case you ask if I can add any coverage for this class :)<div>Indirectly it used by compiler-rt/lib/sanitizer_common/tests/sanitizer_common_range_test.cpp<br><div>I will add dedicated tests for the class.<br></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 5 Jun 2023 at 12:51, David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Could add some test coverage for that minor fix for the ArrayRef(constT*, constT*) ctor.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jun 2, 2023 at 2:32 PM Vitaly Buka via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Vitaly Buka<br>
Date: 2023-06-02T14:32:03-07:00<br>
New Revision: c42e555dc2b2df45027df62a28314446802cd8b7<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/c42e555dc2b2df45027df62a28314446802cd8b7" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/c42e555dc2b2df45027df62a28314446802cd8b7</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/c42e555dc2b2df45027df62a28314446802cd8b7.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/c42e555dc2b2df45027df62a28314446802cd8b7.diff</a><br>
<br>
LOG: [NFC][sanitizer] Delegate ArrayRef constructors<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    compiler-rt/lib/sanitizer_common/sanitizer_common.h<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/compiler-rt/lib/sanitizer_common/sanitizer_common.h b/compiler-rt/lib/sanitizer_common/sanitizer_common.h<br>
index 358878e81c948..302b4437d64bd 100644<br>
--- a/compiler-rt/lib/sanitizer_common/sanitizer_common.h<br>
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_common.h<br>
@@ -1083,10 +1083,10 @@ template <typename T><br>
 class ArrayRef {<br>
  public:<br>
   ArrayRef() {}<br>
-  ArrayRef(T *begin, T *end) : begin_(begin), end_(end) {}<br>
+  ArrayRef(const T *begin, const T *end) : begin_(begin), end_(end) {}<br>
<br>
   template <typename C><br>
-  ArrayRef(const C &src) : begin_(src.data()), end_(src.data() + src.size()) {}<br>
+  ArrayRef(const C &src) : ArrayRef(src.data(), src.data() + src.size()) {}<br>
<br>
   const T *begin() const { return begin_; }<br>
   const T *end() const { return end_; }<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</blockquote></div>