<div dir="ltr"><div>Can you point to examples where RISC-V is often broken?</div><br clear="all"><div><div dir="ltr" data-smartmail="gmail_signature">~Craig</div></div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Dec 21, 2022 at 3:24 PM Nico Weber via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Nico Weber<br>
Date: 2022-12-21T18:24:44-05:00<br>
New Revision: 47df55f3ef57179ebd845290a1bee18c445ff180<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/47df55f3ef57179ebd845290a1bee18c445ff180" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/47df55f3ef57179ebd845290a1bee18c445ff180</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/47df55f3ef57179ebd845290a1bee18c445ff180.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/47df55f3ef57179ebd845290a1bee18c445ff180.diff</a><br>
<br>
LOG: [gn] Don't include RISCV in targets build for 'all'<br>
<br>
RISCV build and tests are often broken.<br>
<br>
You can use `llvm_targets_to_build = "experimental"` to enable<br>
_all_ targets, including the experimental ones. If RISCV is listed<br>
in llvm_targets_to_build, it's built as before.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/utils/gn/secondary/llvm/lib/Target/targets.gni<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/llvm/utils/gn/secondary/llvm/lib/Target/targets.gni b/llvm/utils/gn/secondary/llvm/lib/Target/targets.gni<br>
index 14c5fdc6dd4be..45dce88e17960 100644<br>
--- a/llvm/utils/gn/secondary/llvm/lib/Target/targets.gni<br>
+++ b/llvm/utils/gn/secondary/llvm/lib/Target/targets.gni<br>
@@ -8,7 +8,7 @@ declare_args() {<br>
 }<br>
<br>
 # FIXME: Port the remaining targets.<br>
-llvm_all_targets = [<br>
+llvm_all_stable_targets = [<br>
   "AArch64",<br>
   "AMDGPU",<br>
   "ARM",<br>
@@ -27,6 +27,10 @@ llvm_all_targets = [<br>
   "X86",<br>
 ]<br>
<br>
+llvm_all_experimental_targets = [ "RISCV" ]<br>
+<br>
+llvm_all_targets = llvm_all_stable_targets + llvm_all_experimental_targets<br>
+<br>
 # FIXME: This should be based off target_cpu once cross compiles work.<br>
 if (host_cpu == "arm64") {<br>
   native_target = "AArch64"<br>
@@ -43,6 +47,8 @@ if (host_cpu == "arm64") {<br>
 if (llvm_targets_to_build == "host") {<br>
   llvm_targets_to_build = [ native_target ]<br>
 } else if (llvm_targets_to_build == "all") {<br>
+  llvm_targets_to_build = llvm_all_stable_targets<br>
+} else if (llvm_targets_to_build == "experimental") {<br>
   llvm_targets_to_build = llvm_all_targets<br>
 }<br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>