<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Sorry about that, I had made a copy-paste mistake in my changes, I fixed it here: <a href="https://github.com/llvm/llvm-project/commit/69d9437472851290b5db54661c336284f7ffc9a8" class="">https://github.com/llvm/llvm-project/commit/69d9437472851290b5db54661c336284f7ffc9a8</a><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jun 22, 2022, at 10:39 AM, Mehdi AMINI <<a href="mailto:joker.eph@gmail.com" class="">joker.eph@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Hi Argyrios,<div class=""><br class=""></div><div class="">I see some failure right now with clang-5: <a href="https://buildkite.com/mlir/mlir-core/builds/23452#01818c5c-a30d-4172-92d6-44d6ead085a7" class="">https://buildkite.com/mlir/mlir-core/builds/23452#01818c5c-a30d-4172-92d6-44d6ead085a7</a> ; can you look into this?</div><div class=""><br class=""></div><div class="">Thanks,</div><div class=""><br class=""></div><div class="">-- </div><div class="">Mehdi</div><div class=""><br class=""></div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jun 21, 2022 at 6:48 PM Argyrios Kyrtzidis via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><br class="">
Author: Argyrios Kyrtzidis<br class="">
Date: 2022-06-21T09:48:07-07:00<br class="">
New Revision: acd64d8e85f69467c64af833ef6b38b807bd9b4b<br class="">
<br class="">
URL: <a href="https://github.com/llvm/llvm-project/commit/acd64d8e85f69467c64af833ef6b38b807bd9b4b" rel="noreferrer" target="_blank" class="">https://github.com/llvm/llvm-project/commit/acd64d8e85f69467c64af833ef6b38b807bd9b4b</a><br class="">
DIFF: <a href="https://github.com/llvm/llvm-project/commit/acd64d8e85f69467c64af833ef6b38b807bd9b4b.diff" rel="noreferrer" target="_blank" class="">https://github.com/llvm/llvm-project/commit/acd64d8e85f69467c64af833ef6b38b807bd9b4b.diff</a><br class="">
<br class="">
LOG: [Support/BLAKE3] CMake: Check for `IS_X64` or `CMAKE_OSX_ARCHITECTURES` before adding the assembly files<br class="">
<br class="">
This should fix `clang-ppc64-aix` builder (<a href="https://lab.llvm.org/buildbot/#/builders/214" rel="noreferrer" target="_blank" class="">https://lab.llvm.org/buildbot/#/builders/214</a>)<br class="">
<br class="">
Added: <br class="">
<br class="">
<br class="">
Modified: <br class="">
llvm/lib/Support/BLAKE3/CMakeLists.txt<br class="">
<br class="">
Removed: <br class="">
<br class="">
<br class="">
<br class="">
################################################################################<br class="">
diff --git a/llvm/lib/Support/BLAKE3/CMakeLists.txt b/llvm/lib/Support/BLAKE3/CMakeLists.txt<br class="">
index df1805918587..4fd60a99bbfb 100644<br class="">
--- a/llvm/lib/Support/BLAKE3/CMakeLists.txt<br class="">
+++ b/llvm/lib/Support/BLAKE3/CMakeLists.txt<br class="">
@@ -53,12 +53,8 @@ if (CAN_USE_ASSEMBLER)<br class="">
disable_blake3_x86_simd()<br class="">
endif()<br class="">
else()<br class="">
- check_symbol_exists(__i386__ "" IS_X32)<br class="">
- if (IS_X32)<br class="">
- # blake3 C code autoenables SIMD for i386, but those implementations are<br class="">
- # only available via the intrinsics sources which we don't enable here.<br class="">
- disable_blake3_x86_simd()<br class="">
- else()<br class="">
+ check_symbol_exists(__x86_64__ "" IS_X64)<br class="">
+ if (IS_X64 OR CMAKE_OSX_ARCHITECTURES)<br class="">
# In a macOS Universal build (setting CMAKE_OSX_ARCHITECTURES to multiple<br class="">
# values), compilation of the source files will target multiple architectures<br class="">
# (each source file is internally compiled once for each architecture).<br class="">
@@ -70,13 +66,11 @@ if (CAN_USE_ASSEMBLER)<br class="">
blake3_avx2_x86-64_unix.S<br class="">
blake3_avx512_x86-64_unix.S<br class="">
)<br class="">
- check_c_compiler_flag("-mavx512vl" SUPPORTS_avx512vl)<br class="">
- if (SUPPORTS_avx512vl)<br class="">
- # Clang-6 needs this flag. We also suppress '-Wunused-command-line-argument'<br class="">
- # in case the file is included with arm architecture.<br class="">
- set_source_files_properties(blake3_avx512_x86-64_unix.S<br class="">
- PROPERTIES COMPILE_OPTIONS "-mavx512vl;-Wno-unused-command-line-argument")<br class="">
- endif()<br class="">
+ # Clang-6 needs this flag.<br class="">
+ set_source_files_properties(blake3_avx512_x86-64_windows_gnu.S<br class="">
+ PROPERTIES COMPILE_OPTIONS "-mavx512vl")<br class="">
+ else()<br class="">
+ disable_blake3_x86_simd()<br class="">
endif()<br class="">
endif()<br class="">
else()<br class="">
<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""></body></html>