<div dir="ltr">Hi Argyrios,<div><br></div><div>I see some failure right now with clang-5: <a href="https://buildkite.com/mlir/mlir-core/builds/23452#01818c5c-a30d-4172-92d6-44d6ead085a7">https://buildkite.com/mlir/mlir-core/builds/23452#01818c5c-a30d-4172-92d6-44d6ead085a7</a> ; can you look into this?</div><div><br></div><div>Thanks,</div><div><br></div><div>-- </div><div>Mehdi</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jun 21, 2022 at 6:48 PM Argyrios Kyrtzidis via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><br>
Author: Argyrios Kyrtzidis<br>
Date: 2022-06-21T09:48:07-07:00<br>
New Revision: acd64d8e85f69467c64af833ef6b38b807bd9b4b<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/acd64d8e85f69467c64af833ef6b38b807bd9b4b" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/acd64d8e85f69467c64af833ef6b38b807bd9b4b</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/acd64d8e85f69467c64af833ef6b38b807bd9b4b.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/acd64d8e85f69467c64af833ef6b38b807bd9b4b.diff</a><br>
<br>
LOG: [Support/BLAKE3] CMake: Check for `IS_X64` or `CMAKE_OSX_ARCHITECTURES` before adding the assembly files<br>
<br>
This should fix `clang-ppc64-aix` builder (<a href="https://lab.llvm.org/buildbot/#/builders/214" rel="noreferrer" target="_blank">https://lab.llvm.org/buildbot/#/builders/214</a>)<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/lib/Support/BLAKE3/CMakeLists.txt<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/llvm/lib/Support/BLAKE3/CMakeLists.txt b/llvm/lib/Support/BLAKE3/CMakeLists.txt<br>
index df1805918587..4fd60a99bbfb 100644<br>
--- a/llvm/lib/Support/BLAKE3/CMakeLists.txt<br>
+++ b/llvm/lib/Support/BLAKE3/CMakeLists.txt<br>
@@ -53,12 +53,8 @@ if (CAN_USE_ASSEMBLER)<br>
       disable_blake3_x86_simd()<br>
     endif()<br>
   else()<br>
-    check_symbol_exists(__i386__ "" IS_X32)<br>
-    if (IS_X32)<br>
-      # blake3 C code autoenables SIMD for i386, but those implementations are<br>
-      # only available via the intrinsics sources which we don't enable here.<br>
-      disable_blake3_x86_simd()<br>
-    else()<br>
+    check_symbol_exists(__x86_64__ "" IS_X64)<br>
+    if (IS_X64 OR CMAKE_OSX_ARCHITECTURES)<br>
       # In a macOS Universal build (setting CMAKE_OSX_ARCHITECTURES to multiple<br>
       # values), compilation of the source files will target multiple architectures<br>
       # (each source file is internally compiled once for each architecture).<br>
@@ -70,13 +66,11 @@ if (CAN_USE_ASSEMBLER)<br>
         blake3_avx2_x86-64_unix.S<br>
         blake3_avx512_x86-64_unix.S<br>
       )<br>
-      check_c_compiler_flag("-mavx512vl" SUPPORTS_avx512vl)<br>
-      if (SUPPORTS_avx512vl)<br>
-        # Clang-6 needs this flag. We also suppress '-Wunused-command-line-argument'<br>
-        # in case the file is included with arm architecture.<br>
-        set_source_files_properties(blake3_avx512_x86-64_unix.S<br>
-          PROPERTIES COMPILE_OPTIONS "-mavx512vl;-Wno-unused-command-line-argument")<br>
-      endif()<br>
+      # Clang-6 needs this flag.<br>
+      set_source_files_properties(blake3_avx512_x86-64_windows_gnu.S<br>
+        PROPERTIES COMPILE_OPTIONS "-mavx512vl")<br>
+    else()<br>
+      disable_blake3_x86_simd()<br>
     endif()<br>
   endif()<br>
 else()<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>