<div dir="ltr">Oh in retrospect I should have updated the commit message as well.<div><br></div><div>Going to revert, update commit message and reapply.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, May 10, 2022 at 6:55 PM Craig Topper <<a href="mailto:craig.topper@gmail.com">craig.topper@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">This did not use the title that I asked you to put in the review.<div><br><div><div><div dir="ltr">~Craig</div></div><br></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, May 10, 2022 at 5:57 PM Mingming Liu via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Mingming Liu<br>
Date: 2022-05-10T17:56:51-07:00<br>
New Revision: 8bef5476de3ec7388ad0c72b26dcc82ac7fd970a<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/8bef5476de3ec7388ad0c72b26dcc82ac7fd970a" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/8bef5476de3ec7388ad0c72b26dcc82ac7fd970a</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/8bef5476de3ec7388ad0c72b26dcc82ac7fd970a.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/8bef5476de3ec7388ad0c72b26dcc82ac7fd970a.diff</a><br>
<br>
LOG: [NFC] Run clang-format on llvm/lib/Target/X86/X86InstroInfo.cpp<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D125345" rel="noreferrer" target="_blank">https://reviews.llvm.org/D125345</a><br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/lib/Target/X86/X86InstrInfo.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/llvm/lib/Target/X86/X86InstrInfo.cpp b/llvm/lib/Target/X86/X86InstrInfo.cpp<br>
index f4ffb42d9972d..831142a66d6bb 100644<br>
--- a/llvm/lib/Target/X86/X86InstrInfo.cpp<br>
+++ b/llvm/lib/Target/X86/X86InstrInfo.cpp<br>
@@ -1049,11 +1049,12 @@ static bool findRedundantFlagInstr(MachineInstr &CmpInstr,<br>
     // in the `AND` and `TEST` operation; signed bit is not known for `AND`,<br>
     // and is known to be 0 as a result of `TEST64rr`.<br>
     //<br>
-    // FIXME: As opposed to poisoning the SF bit direclty, consider peeking into<br>
-    // the AND instruction and using the static information to guide peephole optimization if possible.<br>
-    // For example, it's possible to fold a conditional move into a copy<br>
-    // if the relevant EFLAG bits could be deduced from an immediate operand of and operation.<br>
-    // <br>
+    // FIXME: As opposed to poisoning the SF bit directly, consider peeking into<br>
+    // the AND instruction and using the static information to guide peephole<br>
+    // optimization if possible. For example, it's possible to fold a<br>
+    // conditional move into a copy if the relevant EFLAG bits could be deduced<br>
+    // from an immediate operand of and operation.<br>
+    //<br>
     NoSignFlag = true;<br>
     // ClearsOverflowFlag is true for AND operation (no surprise).<br>
     ClearsOverflowFlag = true;<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div><font color="#555555" face="sans-serif" size="2">Thanks,</font></div><div><font color="#555555" face="sans-serif" size="2">Mingming</font></div></div></div></div></div></div>