<div dir="ltr">I /think/ there's unit test coverage for this class that could be improved to cover this fix (& maybe the constification fixes in that other commit too)</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Nov 15, 2021 at 5:29 PM Duncan P. N. Exon Smith via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Duncan P. N. Exon Smith<br>
Date: 2021-11-15T17:29:00-08:00<br>
New Revision: b23ba295bd129315eac09a52cf58346081e6fdc8<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/b23ba295bd129315eac09a52cf58346081e6fdc8" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/b23ba295bd129315eac09a52cf58346081e6fdc8</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/b23ba295bd129315eac09a52cf58346081e6fdc8.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/b23ba295bd129315eac09a52cf58346081e6fdc8.diff</a><br>
<br>
LOG: DebugInfo: Make DWARFExpression::iterator::operator++ return itself<br>
<br>
Looks like an accident that `operator++` was returning `Operator&`<br>
instead of `iterator&`. Update to match standard iterator behaviour.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h b/llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h<br>
index dc575265d816..9ebe9b0e4110 100644<br>
--- a/llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h<br>
+++ b/llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h<br>
@@ -116,12 +116,12 @@ class DWARFExpression {<br>
     }<br>
<br>
   public:<br>
-    class Operation &operator++() {<br>
+    iterator &operator++() {<br>
       Offset = Op.isError() ? Expr->Data.getData().size() : Op.EndOffset;<br>
       Op.Error =<br>
           Offset >= Expr->Data.getData().size() ||<br>
           !Op.extract(Expr->Data, Expr->AddressSize, Offset, Expr->Format);<br>
-      return Op;<br>
+      return *this;<br>
     }<br>
<br>
     class Operation &operator*() const {<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>