<div dir="ltr"><div>Hi,</div><div><br></div><div>May someone please take a look?</div><div><br></div><div>This patch fixes a case where -inf is printed as "INF".</div><div><br></div><div>Thank you.</div><div><br></div><div>Regards,</div><div>Logan<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Oct 15, 2021 at 5:51 PM Logan Chien via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">logan created this revision.<br>
Herald added subscribers: dexonsmith, hiraditya.<br>
logan requested review of this revision.<br>
Herald added a project: LLVM.<br>
Herald added a subscriber: llvm-commits.<br>
<br>
This commit makes `llvm::write_double` print `-inf` as `"-INF"` instead of `"INF"`.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D111917" rel="noreferrer" target="_blank">https://reviews.llvm.org/D111917</a><br>
<br>
Files:<br>
  llvm/lib/Support/NativeFormatting.cpp<br>
  llvm/unittests/Support/NativeFormatTests.cpp<br>
<br>
<br>
Index: llvm/unittests/Support/NativeFormatTests.cpp<br>
===================================================================<br>
--- llvm/unittests/Support/NativeFormatTests.cpp<br>
+++ llvm/unittests/Support/NativeFormatTests.cpp<br>
@@ -125,6 +125,8 @@<br>
                                  FloatStyle::Fixed));<br>
   EXPECT_EQ("INF", format_number(std::numeric_limits<double>::infinity(),<br>
                                  FloatStyle::Fixed));<br>
+  EXPECT_EQ("-INF", format_number(-std::numeric_limits<double>::infinity(),<br>
+                                  FloatStyle::Fixed));<br>
 }<br>
<br>
 TEST(NativeFormatTest, HexTests) {<br>
Index: llvm/lib/Support/NativeFormatting.cpp<br>
===================================================================<br>
--- llvm/lib/Support/NativeFormatting.cpp<br>
+++ llvm/lib/Support/NativeFormatting.cpp<br>
@@ -168,7 +168,7 @@<br>
     S << "nan";<br>
     return;<br>
   } else if (std::isinf(N)) {<br>
-    S << "INF";<br>
+    S << (std::signbit(N) ? "-INF" : "INF");<br>
     return;<br>
   }<br>
<br>
<br>
<br>
</blockquote></div>