<div dir="ltr"><a href="https://lab.llvm.org/buildbot/#/builders/5/builds/12978">https://lab.llvm.org/buildbot/#/builders/5/builds/12978</a> looks related to the patch<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, 10 Oct 2021 at 21:11, Lang Hames via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Lang Hames<br>
Date: 2021-10-10T21:09:29-07:00<br>
New Revision: c59ebe4c4c2d125a8a0b788f5af5d4d052d38818<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/c59ebe4c4c2d125a8a0b788f5af5d4d052d38818" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/c59ebe4c4c2d125a8a0b788f5af5d4d052d38818</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/c59ebe4c4c2d125a8a0b788f5af5d4d052d38818.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/c59ebe4c4c2d125a8a0b788f5af5d4d052d38818.diff</a><br>
<br>
LOG: [ORC] Add TaskDispatcher::shutdown calls to TaskDispatchTest.cpp unit tests.<br>
<br>
These calls were left out of 4d7cea3d2e8. In the InPlaceDispatcher test case<br>
the operation is a no-op, but it's good form to include it. In the<br>
DynamicThreadPoolTaskDispatcher test the shutdown call is required to ensure<br>
that we don't exit the test (and tear down the dispatcher) before the thread<br>
running the dispatch has completed.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/unittests/ExecutionEngine/Orc/TaskDispatchTest.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/llvm/unittests/ExecutionEngine/Orc/TaskDispatchTest.cpp b/llvm/unittests/ExecutionEngine/Orc/TaskDispatchTest.cpp<br>
index 60a5e755f91f0..83d386c631ddd 100644<br>
--- a/llvm/unittests/ExecutionEngine/Orc/TaskDispatchTest.cpp<br>
+++ b/llvm/unittests/ExecutionEngine/Orc/TaskDispatchTest.cpp<br>
@@ -19,6 +19,7 @@ TEST(InPlaceTaskDispatchTest, GenericNamedTask) {<br>
   bool B = false;<br>
   D->dispatch(makeGenericNamedTask([&]() { B = true; }));<br>
   EXPECT_TRUE(B);<br>
+  D->shutdown();<br>
 }<br>
<br>
 #if LLVM_ENABLE_THREADS<br>
@@ -29,5 +30,6 @@ TEST(DynamicThreadPoolDispatchTest, GenericNamedTask) {<br>
   D->dispatch(makeGenericNamedTask(<br>
       [P = std::move(P)]() mutable { P.set_value(true); }));<br>
   EXPECT_TRUE(F.get());<br>
+  D->shutdown();<br>
 }<br>
 #endif<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>