<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi,<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Oct 25, 2020, at 17:47, Nikita Popov via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class=""><br class="">Author: Nikita Popov<br class="">Date: 2020-10-25T18:46:50+01:00<br class="">New Revision: 22a5cde541c3306e53279fd02c6d60ae6178ef10<br class=""><br class="">URL: <a href="https://github.com/llvm/llvm-project/commit/22a5cde541c3306e53279fd02c6d60ae6178ef10" class="">https://github.com/llvm/llvm-project/commit/22a5cde541c3306e53279fd02c6d60ae6178ef10</a><br class="">DIFF: <a href="https://github.com/llvm/llvm-project/commit/22a5cde541c3306e53279fd02c6d60ae6178ef10.diff" class="">https://github.com/llvm/llvm-project/commit/22a5cde541c3306e53279fd02c6d60ae6178ef10.diff</a><br class=""><br class="">LOG: [SCEV] Separate out constant folding in mul expr creation<br class=""><br class="">Separate out the code handling constant folding into a separate<br class="">block, that is independent of other folds that need a constant<br class="">first operand. Also make some minor adjustments to make the<br class="">constant folding look nearly identical to the same code in<br class="">getAddExpr().<br class=""><br class="">The only reason this change is not strictly NFC is that the<br class="">C1*(C2+V) fold is moved below the constant folding, which means<br class="">that it now also applies to C1*C2*(C3+V), as it should.<br class=""><br class="">Added: <br class=""></div></div></blockquote></div><br class=""><div class=""><br class=""></div><div class="">It looks like this change may cause a crash in LoopStrengthReduce: <font face="arial, sans-serif" class=""><span style="white-space: pre;" class=""><a href="https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=35400" class="">https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=35400</a></span></font></div><div class=""><br class=""></div><div class="">To reproduce, run `llc` on <span style="font-family: arial, sans-serif; white-space: pre;" class=""> </span><font face="arial, sans-serif" class=""><span style="white-space: pre;" class=""><a href="https://oss-fuzz.com/download?testcase_id=5243727227518976" class="">https://oss-fuzz.com/download?testcase_id=5243727227518976</a></span></font></div><div class=""><br class=""></div><div class="">Cheers,</div><div class="">Florian</div></body></html>