<div dir="ltr">We're seeing a crash caused by this patch. I'll revert and post a test case ASAP.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jun 3, 2021 at 7:10 PM Arthur Eubanks via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Arthur Eubanks<br>
Date: 2021-06-03T19:09:09-07:00<br>
New Revision: 738abfdbea21acd2597d83ad3390daf5696b6d07<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/738abfdbea21acd2597d83ad3390daf5696b6d07" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/738abfdbea21acd2597d83ad3390daf5696b6d07</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/738abfdbea21acd2597d83ad3390daf5696b6d07.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/738abfdbea21acd2597d83ad3390daf5696b6d07.diff</a><br>
<br>
LOG: [NFC] Remove checking pointee type for byval/preallocated type<br>
<br>
These currently always require a type parameter. The bitcode reader<br>
already upgrades old bitcode without the type parameter to use the<br>
pointee type.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/include/llvm/IR/InstrTypes.h<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/llvm/include/llvm/IR/InstrTypes.h b/llvm/include/llvm/IR/InstrTypes.h<br>
index 802b913aa9f4..7fc4602aee49 100644<br>
--- a/llvm/include/llvm/IR/InstrTypes.h<br>
+++ b/llvm/include/llvm/IR/InstrTypes.h<br>
@@ -1729,13 +1729,13 @@ class CallBase : public Instruction {<br>
   /// Extract the byval type for a call or parameter.<br>
   Type *getParamByValType(unsigned ArgNo) const {<br>
     Type *Ty = Attrs.getParamByValType(ArgNo);<br>
-    return Ty ? Ty : getArgOperand(ArgNo)->getType()->getPointerElementType();<br>
+    return Ty;<br>
   }<br>
<br>
   /// Extract the preallocated type for a call or parameter.<br>
   Type *getParamPreallocatedType(unsigned ArgNo) const {<br>
     Type *Ty = Attrs.getParamPreallocatedType(ArgNo);<br>
-    return Ty ? Ty : getArgOperand(ArgNo)->getType()->getPointerElementType();<br>
+    return Ty;<br>
   }<br>
<br>
   /// Extract the number of dereferenceable bytes for a call or<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>