<div dir="ltr"><div>Sorry, should've mentioned the reason: the auto-generated CHECK lines produced by the script at utils/update_test_checks.py can conflict with IR values named "tmp[0-9]+". The script warns at runtime about this, so this patch avoids that warning.</div><div><br></div><div>More details here:</div><div><a href="https://llvm.org/PR45951">https://llvm.org/PR45951</a></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jun 14, 2021 at 9:20 PM David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hmm, why is it important to avoid these?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jun 10, 2021 at 2:04 PM Sanjay Patel via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Sanjay Patel<br>
Date: 2021-06-10T17:04:23-04:00<br>
New Revision: 7b969ef8b4eb93d7a2be093b27280f12b8cd9ccb<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/7b969ef8b4eb93d7a2be093b27280f12b8cd9ccb" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/7b969ef8b4eb93d7a2be093b27280f12b8cd9ccb</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/7b969ef8b4eb93d7a2be093b27280f12b8cd9ccb.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/7b969ef8b4eb93d7a2be093b27280f12b8cd9ccb.diff</a><br>
<br>
LOG: [SimplifyCFG] avoid 'tmp' variables in test file; NFC<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/test/Transforms/SimplifyCFG/two-entry-phi-return.ll<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/llvm/test/Transforms/SimplifyCFG/two-entry-phi-return.ll b/llvm/test/Transforms/SimplifyCFG/two-entry-phi-return.ll<br>
index af647508ee65f..e9b52f49b961c 100644<br>
--- a/llvm/test/Transforms/SimplifyCFG/two-entry-phi-return.ll<br>
+++ b/llvm/test/Transforms/SimplifyCFG/two-entry-phi-return.ll<br>
@@ -4,21 +4,21 @@<br>
 define i1 @qux(i8* %m, i8* %n, i8* %o, i8* %p) nounwind  {<br>
 ; CHECK-LABEL: @qux(<br>
 ; CHECK-NEXT:  entry:<br>
-; CHECK-NEXT:    [[TMP7:%.*]] = icmp eq i8* %m, %n<br>
-; CHECK-NEXT:    [[TMP15:%.*]] = icmp eq i8* %o, %p<br>
-; CHECK-NEXT:    [[TMP15_:%.*]] = select i1 [[TMP7]], i1 [[TMP15]], i1 false, !prof !0<br>
-; CHECK-NEXT:    ret i1 [[TMP15_]]<br>
+; CHECK-NEXT:    [[T7:%.*]] = icmp eq i8* [[M:%.*]], [[N:%.*]]<br>
+; CHECK-NEXT:    [[T15:%.*]] = icmp eq i8* [[O:%.*]], [[P:%.*]]<br>
+; CHECK-NEXT:    [[SPEC_SELECT:%.*]] = select i1 [[T7]], i1 [[T15]], i1 false, !prof [[PROF0:![0-9]+]]<br>
+; CHECK-NEXT:    ret i1 [[SPEC_SELECT]]<br>
 ;<br>
 entry:<br>
-  %tmp7 = icmp eq i8* %m, %n<br>
-  br i1 %tmp7, label %bb, label %UnifiedReturnBlock, !prof !0<br>
+  %t7 = icmp eq i8* %m, %n<br>
+  br i1 %t7, label %bb, label %UnifiedReturnBlock, !prof !0<br>
<br>
 bb:<br>
-  %tmp15 = icmp eq i8* %o, %p<br>
+  %t15 = icmp eq i8* %o, %p<br>
   br label %UnifiedReturnBlock<br>
<br>
 UnifiedReturnBlock:<br>
-  %result = phi i1 [ 0, %entry ], [ %tmp15, %bb ]<br>
+  %result = phi i1 [ 0, %entry ], [ %t15, %bb ]<br>
   ret i1 %result<br>
<br>
 }<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</blockquote></div>