<div dir="ltr">Is there room (readily used infrastructure, etc) for unit tests for these primitives?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jun 1, 2021 at 11:26 AM Lang Hames via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Lang Hames<br>
Date: 2021-06-01T11:24:19-07:00<br>
New Revision: d791f0c2199e47e63e1dd95da2e78518d574bad2<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/d791f0c2199e47e63e1dd95da2e78518d574bad2" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/d791f0c2199e47e63e1dd95da2e78518d574bad2</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/d791f0c2199e47e63e1dd95da2e78518d574bad2.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/d791f0c2199e47e63e1dd95da2e78518d574bad2.diff</a><br>
<br>
LOG: [ORC-RT] Add equality/inequality comparison to string_view.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    compiler-rt/lib/orc/adt.h<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/compiler-rt/lib/orc/adt.h b/compiler-rt/lib/orc/adt.h<br>
index b7d2174bc197e..33b731082f88f 100644<br>
--- a/compiler-rt/lib/orc/adt.h<br>
+++ b/compiler-rt/lib/orc/adt.h<br>
@@ -84,6 +84,21 @@ class string_view {<br>
   constexpr size_type size() const noexcept { return Size; }<br>
   constexpr bool empty() const noexcept { return Size == 0; }<br>
<br>
+  friend bool operator==(const string_view &LHS, const string_view &RHS) {<br>
+    if (LHS.Size != RHS.Size)<br>
+      return false;<br>
+    if (LHS.Data == RHS.Data)<br>
+      return true;<br>
+    for (size_t I = 0; I != LHS.Size; ++I)<br>
+      if (LHS.Data[I] != RHS.Data[I])<br>
+        return false;<br>
+    return true;<br>
+  }<br>
+<br>
+  friend bool operator!=(const string_view &LHS, const string_view &RHS) {<br>
+    return !(LHS == RHS);<br>
+  }<br>
+<br>
 private:<br>
   const char *Data = nullptr;<br>
   size_type Size = 0;<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>