<div dir="ltr">Looks like this causes failures in release builds. I don't have a buildbot link yet; I noticed this running tests locally. Reproduced directly:<div><br></div><div>$ bin/llvm-as ~/src/llvm-project/llvm/test/Verifier/token1.ll -o /dev/null<br>bin/llvm-as: assembly parsed, but does not verify as correct!<br>Function takes token but isn't an intrinsic<br>token %A<br>void (token, token)* @f<br>PHI nodes cannot have token type!</div><div><br>$ echo $?<br>1<br></div><div><br></div><div>I guess it's not actually crashing, just returning a bad error code.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Apr 27, 2021 at 1:10 PM Roman Lebedev via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Roman Lebedev<br>
Date: 2021-04-27T21:09:43+03:00<br>
New Revision: be935f28888cbfe705699fa3beb8b849aa0f9f90<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/be935f28888cbfe705699fa3beb8b849aa0f9f90" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/be935f28888cbfe705699fa3beb8b849aa0f9f90</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/be935f28888cbfe705699fa3beb8b849aa0f9f90.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/be935f28888cbfe705699fa3beb8b849aa0f9f90.diff</a><br>
<br>
LOG: [NFC][Verifier] Fixup token PHINode test cases<br>
<br>
It would still pass in non-assert build,<br>
but with asserts it would now crash.<br>
<br>
I haven't checked, but hopefully `not`'s `--crash` argument<br>
should be enough to support both paths.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/test/Verifier/token1.ll<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/llvm/test/Verifier/token1.ll b/llvm/test/Verifier/token1.ll<br>
index ac7ff30948ea..90d48832f2bb 100644<br>
--- a/llvm/test/Verifier/token1.ll<br>
+++ b/llvm/test/Verifier/token1.ll<br>
@@ -1,4 +1,4 @@<br>
-; RUN: not llvm-as %s -o /dev/null 2>&1 | FileCheck %s<br>
+; RUN: not --crash llvm-as %s -o /dev/null 2>&1 | FileCheck %s<br>
<br>
 define void @f(token %A, token %B) {<br>
 entry:<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>