<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 4/5/21 12:48 PM, Eric Christopher
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CALehDX4jOv7DUNLuyv3Lc7Qi8sekyyeFnng4ngX7P_ANU00H8Q@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div dir="ltr"><br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Mon, Apr 5, 2021 at 10:47
AM Philip Reames via Phabricator <<a
href="mailto:reviews@reviews.llvm.org"
moz-do-not-send="true">reviews@reviews.llvm.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">reames added inline
comments.<br>
<br>
<br>
================<br>
Comment at: llvm/docs/DeveloperPolicy.rst:330<br>
+* In general, if the author themselves would revert the
change per these<br>
+ guidelines, we encourage other contributors to do so as a
favor to the<br>
+ author. This is one of the major cases where our norms
differ from others;<br>
----------------<br>
probinson wrote:<br>
> reames wrote:<br>
> > echristo wrote:<br>
> > > reames wrote:<br>
> > > > echristo wrote:<br>
> > > > > I think wording wise we can just
remove the "... as a favor to the author." here and reword a
little below...<br>
> > > > I left this one as is. I took all your
other edits, but taking this out seems to loose an important
point to me. <br>
> > > I followed up offline here with an article
that would help illustrate my point, but for me not having
the "I'm doing you a favor" is important. It's not a favor,
it's just how we work. There's no obligation or reciprocity
expected which the text gives the impression of.<br>
> > You did, my apologies for not acknowledging that.<br>
> > <br>
> > I read the article you sent, it was definitely
interesting, but it didn't change my take on this.<br>
> > <br>
> > I'm going to defer to Chris on this. If he wants
a change, I'll make it. If he's okay with the current
wording, I'll leave it as is.<br>
> Maybe "courtesy" rather than "favor" would have less
implication of an obligation? Overall we are expected to be
courteous to one another.<br>
Great suggestion, that would work for me. Eric?<br>
</blockquote>
<div><br>
</div>
<div>Could work for now. Could you reframe the wording around
"we are being courteous to each other by helping keep top of
tree working well"? I'd support wording in those terms - it
doesn't phrase things by imposing obligations onto others.</div>
</div>
</div>
</blockquote>
<p>Eric,</p>
<p>I took the "as a courtesy" wording, and plan to commit that
unless you object. <br>
</p>
<p>I found your alternate wording hard to parse, and honestly, I'm
not really seeing the distinction you're trying to make. Could I
ask you to post a patch with an attempt at rewording once this
lands? I'm not at all opposed to the idea, but I don't think I'm
the right person to try drafting it.</p>
Philip<br>
</body>
</html>