<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
On 05/04/2021 19:16, Eric Christopher wrote:
<blockquote type="cite"
cite="mid:CALehDX7KRczpzMB0OL_ErZCasro0YXjVjq-TdGaAOE086XwHNQ@mail.gmail.com">
<div dir="ltr">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div class="gmail_quote"><a class="gmail_plusreply"
id="gmail-m_5394577742570426821plusReplyChip-1"
href="mailto:echristo@gmail.com" target="_blank">@Eric
Christopher</a> - any idea what the ToolSubst's you
updated in <a
href="https://reviews.llvm.org/rGea7b1c79f73d8def"
target="_blank">https://reviews.llvm.org/rGea7b1c79f73d8def</a> are
for/when they're needed/not needed?<br>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>Sorry, been too long I can't recall :(</div>
</div>
</div>
</blockquote>
<p>Ok, I had a look an explained the situation in
<a class="moz-txt-link-freetext" href="https://reviews.llvm.org/D99931">https://reviews.llvm.org/D99931</a><br>
<br>
Maybe the test suite could use a warning for RUN lines with
relative paths, i.e. without ToolSubst?<br>
<br>
And: Is there a way to query for builders that match a CMake
setting? I only know these two build with examples enabled:<br>
<a class="moz-txt-link-freetext" href="http://lab.llvm.org:8011/#/builders/13">http://lab.llvm.org:8011/#/builders/13</a><br>
<a class="moz-txt-link-freetext" href="http://lab.llvm.org:8011/#/builders/61">http://lab.llvm.org:8011/#/builders/61</a><br>
<br>
<br>
On Sat, Apr 3, 2021 at 12:08 PM David Blaikie <<a
href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>>
wrote:
</p>
<blockquote type="cite">
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div> There are bots that build with examples enabled, but they
do the same thing I used to do: configure with examples and
check-llvm. This way the issue doesn't show up.</div>
</blockquote>
<br>
Hmm, it does seem to show up for me (after I deleted the binary
and removed the CMakeFiles.txt change) in check-llvm and
check-all. So I'm not sure what's different about your situation
or buildbots, etc - do you use Ninja or make or some other thing?
(though I'd imagine we have buildbots using ninja... )</blockquote>
Interesting, with a clean build it now shows up here too. Maybe I
really didn't clean up the build directory when I ran the test suite
earlier. Anyway, yes you are right. It's necessary to add them to
LLVM_TEST_DEPENDS manually.<br>
<br>
<br>
<div class="moz-cite-prefix">On Sat, Apr 3, 2021 at 12:08 PM David
Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>>
wrote:
</div>
<blockquote type="cite">In which bit of python? In the ToolSubst
code? I think the "unresolved=ignore" part means it doesn't need
to be exactly the same as the conditions in which its built</blockquote>
Yes sounds reasonable.<br>
<br>
</body>
</html>