<div dir="ltr"><div class="gmail_default" style="font-family:monospace;font-size:small;color:#000000">that is fine if it does not add visible compile time overhead (e.g, to compute and track size).</div><div class="gmail_default" style="font-family:monospace;font-size:small;color:#000000"><br></div><div class="gmail_default" style="font-family:monospace;font-size:small;color:#000000">David</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Mar 17, 2021 at 11:46 AM Hongtao Yu <<a href="mailto:hoy@fb.com">hoy@fb.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="EN-US" style="overflow-wrap: break-word;">
<div class="gmail-m_9192214545725690545WordSection1">
<p class="MsoNormal"><span style="font-size:12pt;font-family:"Courier New";color:black;background:white">Thanks for the suggestion. I was thinking about capping on function size so that small callees such as getters/setters can always be inlined. What do
you think?</span><u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(181,196,223);padding:3pt 0in 0in">
<p class="MsoNormal" style="margin-right:0in;margin-bottom:12pt;margin-left:0.5in">
<b><span style="font-size:12pt;color:black">From: </span></b><span style="font-size:12pt;color:black">Xinliang David Li <<a href="mailto:davidxl@google.com" target="_blank">davidxl@google.com</a>><br>
<b>Date: </b>Wednesday, March 17, 2021 at 9:02 AM<br>
<b>To: </b>Hongtao Yu <<a href="mailto:reviews%2BD98481%2Bpublic%2B2d824aa1c1081e47@reviews.llvm.org" target="_blank">reviews+D98481+public+2d824aa1c1081e47@reviews.llvm.org</a>><br>
<b>Cc: </b>Hongtao Yu <<a href="mailto:hoy@fb.com" target="_blank">hoy@fb.com</a>>, Wenlei He <<a href="mailto:wenlei@fb.com" target="_blank">wenlei@fb.com</a>>, Kazu Hirata <<a href="mailto:kazu@google.com" target="_blank">kazu@google.com</a>>, Chandler Carruth <<a href="mailto:chandlerc@gmail.com" target="_blank">chandlerc@gmail.com</a>>, Wei Mi <<a href="mailto:wmi@google.com" target="_blank">wmi@google.com</a>>, Easwaran Raman <<a href="mailto:eraman@google.com" target="_blank">eraman@google.com</a>>, llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>>, <a href="mailto:bhuvanendra.kumarn@amd.com" target="_blank">bhuvanendra.kumarn@amd.com</a>
<<a href="mailto:bhuvanendra.kumarn@amd.com" target="_blank">bhuvanendra.kumarn@amd.com</a>>, <a href="mailto:88888yl@gmail.com" target="_blank">88888yl@gmail.com</a> <<a href="mailto:88888yl@gmail.com" target="_blank">88888yl@gmail.com</a>>, <a href="mailto:dougpuob@gmail.com" target="_blank">dougpuob@gmail.com</a> <<a href="mailto:dougpuob@gmail.com" target="_blank">dougpuob@gmail.com</a>>, David Green <<a href="mailto:david.green@arm.com" target="_blank">david.green@arm.com</a>><br>
<b>Subject: </b>Re: [PATCH] D98481: [Inliner] Do not inline mutual-recursive functions to avoid exponential size growth.<u></u><u></u></span></p>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="margin-left:0.5in"><span style="font-size:12pt;font-family:"Courier New";color:black"><u></u> <u></u></span></p>
</div>
</div>
<p class="MsoNormal" style="margin-left:0.5in"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal" style="margin-left:0.5in">On Tue, Mar 16, 2021 at 11:43 PM Hongtao Yu via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal" style="margin-right:0in;margin-bottom:12pt;margin-left:0.5in">
hoy added a comment.<br>
<br>
A cap sounds good to me, since that's something we've been looking for for a long time. Regarding the cap, what kind of cap do you think will be appropriate? A cap on function size growth or a cap on how many times an original callsite can be inlined iteratively?
Regarding the later, I was wondering what's a good way to track a callsite across SCC and function passes.<u></u><u></u></p>
</blockquote>
<div>
<p class="MsoNormal" style="margin-left:0.5in"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:0.5in"><span style="font-size:12pt;font-family:"Courier New";color:black">I think the latter -- but in a local sense. For callsite a-->b, have a cap on the total number of callsites that can be inlined into 'a' iteratively.
When the cap is reached, break out the worklist loop.<u></u><u></u></span></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal" style="margin-right:0in;margin-bottom:12pt;margin-left:0.5in">
<br>
Repository:<br>
rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://reviews.llvm.org/D98481/new/" target="_blank">https://reviews.llvm.org/D98481/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D98481" target="_blank">https://reviews.llvm.org/D98481</a><u></u><u></u></p>
</blockquote>
</div>
</div>
</div>
</div>
</blockquote></div>