<div dir="ltr">Would llvm::any_of be even better?<div><br clear="all"><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature">~Craig</div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Mar 16, 2021 at 4:49 AM via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: serge-sans-paille<br>
Date: 2021-03-16T12:49:19+01:00<br>
New Revision: 35368bbdbb6f87543c3ea4c7f70c113954ce1bef<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/35368bbdbb6f87543c3ea4c7f70c113954ce1bef" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/35368bbdbb6f87543c3ea4c7f70c113954ce1bef</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/35368bbdbb6f87543c3ea4c7f70c113954ce1bef.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/35368bbdbb6f87543c3ea4c7f70c113954ce1bef.diff</a><br>
<br>
LOG: [NFC] Replace loop by idiomatic llvm::find_if<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/lib/CodeGen/TwoAddressInstructionPass.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/llvm/lib/CodeGen/TwoAddressInstructionPass.cpp b/llvm/lib/CodeGen/TwoAddressInstructionPass.cpp<br>
index a011b03d747c..bd20f32ee253 100644<br>
--- a/llvm/lib/CodeGen/TwoAddressInstructionPass.cpp<br>
+++ b/llvm/lib/CodeGen/TwoAddressInstructionPass.cpp<br>
@@ -1357,11 +1357,9 @@ void<br>
 TwoAddressInstructionPass::processTiedPairs(MachineInstr *MI,<br>
                                             TiedPairList &TiedPairs,<br>
                                             unsigned &Dist) {<br>
-  bool IsEarlyClobber = false;<br>
-  for (unsigned tpi = 0, tpe = TiedPairs.size(); tpi != tpe; ++tpi) {<br>
-    const MachineOperand &DstMO = MI->getOperand(TiedPairs[tpi].second);<br>
-    IsEarlyClobber |= DstMO.isEarlyClobber();<br>
-  }<br>
+  bool IsEarlyClobber = llvm::find_if(TiedPairs, [MI](auto const &TP) {<br>
+                          return MI->getOperand(TP.second).isEarlyClobber();<br>
+                        }) != TiedPairs.end();<br>
<br>
   bool RemovedKillFlag = false;<br>
   bool AllUsesCopied = true;<br>
@@ -1369,9 +1367,9 @@ TwoAddressInstructionPass::processTiedPairs(MachineInstr *MI,<br>
   SlotIndex LastCopyIdx;<br>
   Register RegB = 0;<br>
   unsigned SubRegB = 0;<br>
-  for (unsigned tpi = 0, tpe = TiedPairs.size(); tpi != tpe; ++tpi) {<br>
-    unsigned SrcIdx = TiedPairs[tpi].first;<br>
-    unsigned DstIdx = TiedPairs[tpi].second;<br>
+  for (auto &TP : TiedPairs) {<br>
+    unsigned SrcIdx = TP.first;<br>
+    unsigned DstIdx = TP.second;<br>
<br>
     const MachineOperand &DstMO = MI->getOperand(DstIdx);<br>
     Register RegA = DstMO.getReg();<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>