I had commented on the original diff for some of those same reasons: <a href="https://reviews.llvm.org/D98224#2618043">https://reviews.llvm.org/D98224#2618043</a> <div><br></div><div>In future I'll include the same info in the revert too.</div><div><br></div><div>Dave</div><div><br>On Monday, March 15, 2021, David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">please include some details about why a patch is being reverted in the commit description - it helps folks understand if a patch would be relevant to some issue they're investigating, or avoid making the same mistake in a later/similar change, etc<div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Mar 10, 2021 at 2:47 PM Dave Lee via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Dave Lee<br>
Date: 2021-03-10T14:47:08-08:00<br>
New Revision: 683e89722aa0fd9afd41fb0799e46e<wbr>1b28db1de6<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/683e89722aa0fd9afd41fb0799e46e1b28db1de6" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-<wbr>project/commit/<wbr>683e89722aa0fd9afd41fb0799e46e<wbr>1b28db1de6</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/683e89722aa0fd9afd41fb0799e46e1b28db1de6.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-<wbr>project/commit/<wbr>683e89722aa0fd9afd41fb0799e46e<wbr>1b28db1de6.diff</a><br>
<br>
LOG: Revert "[cmake] Enable -Werror=return-type"<br>
<br>
This reverts commit ce94a161651d0edd313d0fa65571eb<wbr>53d3a34d13.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/cmake/modules/<wbr>HandleLLVMOptions.cmake<br>
<br>
Removed: <br>
<br>
<br>
<br>
##############################<wbr>##############################<wbr>####################<br>
diff  --git a/llvm/cmake/modules/<wbr>HandleLLVMOptions.cmake b/llvm/cmake/modules/<wbr>HandleLLVMOptions.cmake<br>
index 911275f21124..32fb4e10e31e 100644<br>
--- a/llvm/cmake/modules/<wbr>HandleLLVMOptions.cmake<br>
+++ b/llvm/cmake/modules/<wbr>HandleLLVMOptions.cmake<br>
@@ -745,10 +745,6 @@ if (LLVM_ENABLE_WARNINGS AND (LLVM_COMPILER_IS_GCC_<wbr>COMPATIBLE OR CLANG_CL))<br>
<br>
   # Enable -Wstring-conversion to catch misuse of string literals.<br>
   add_flag_if_supported("-<wbr>Wstring-conversion" STRING_CONVERSION_FLAG)<br>
-<br>
-  # Enable -Werror=return-type if available, to catch functions that contain<br>
-  # control paths that do not return a value.<br>
-  add_flag_if_supported("-<wbr>Werror=return-type" WERROR_RETURN_TYPE)<br>
 endif (LLVM_ENABLE_WARNINGS AND (LLVM_COMPILER_IS_GCC_<wbr>COMPATIBLE OR CLANG_CL))<br>
<br>
 if (LLVM_COMPILER_IS_GCC_<wbr>COMPATIBLE AND NOT LLVM_ENABLE_WARNINGS)<br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-<wbr>bin/mailman/listinfo/llvm-<wbr>commits</a><br>
</blockquote></div>
</blockquote></div>