<div dir="ltr"><div>It's helpful to put a reason for a revert into the commit message.</div><br clear="all"><div><div dir="ltr" data-smartmail="gmail_signature">~Craig</div></div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Feb 19, 2021 at 6:59 PM Dávid Bolvanský via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Dávid Bolvanský<br>
Date: 2021-02-20T03:58:53+01:00<br>
New Revision: 68e6025cf7e37f6da66dfe4e6484fcc921237b42<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/68e6025cf7e37f6da66dfe4e6484fcc921237b42" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/68e6025cf7e37f6da66dfe4e6484fcc921237b42</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/68e6025cf7e37f6da66dfe4e6484fcc921237b42.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/68e6025cf7e37f6da66dfe4e6484fcc921237b42.diff</a><br>
<br>
LOG: Revert "[BuildLibcalls] Mark some libcalls with inaccessiblememonly and inaccessiblemem_or_argmemonly"<br>
<br>
This reverts commit 05d891a19e45687090edcfccfbad334911659eb0.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/lib/Transforms/Utils/BuildLibCalls.cpp<br>
    llvm/test/Transforms/InferFunctionAttrs/annotate.ll<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/llvm/lib/Transforms/Utils/BuildLibCalls.cpp b/llvm/lib/Transforms/Utils/BuildLibCalls.cpp<br>
index 9b6ac3a31e41..dba5403f272a 100644<br>
--- a/llvm/lib/Transforms/Utils/BuildLibCalls.cpp<br>
+++ b/llvm/lib/Transforms/Utils/BuildLibCalls.cpp<br>
@@ -910,7 +910,6 @@ bool llvm::inferLibFuncAttributes(Function &F, const TargetLibraryInfo &TLI) {<br>
     return Changed;<br>
   case LibFunc_dunder_strdup:<br>
   case LibFunc_dunder_strndup:<br>
-    Changed |= setOnlyAccessesInaccessibleMemOrArgMem(F);<br>
     Changed |= setDoesNotThrow(F);<br>
     Changed |= setRetDoesNotAlias(F);<br>
     Changed |= setWillReturn(F);<br>
@@ -996,20 +995,6 @@ bool llvm::inferLibFuncAttributes(Function &F, const TargetLibraryInfo &TLI) {<br>
     Changed |= setDoesNotCapture(F, 0);<br>
     Changed |= setDoesNotCapture(F, 1);<br>
     return Changed;<br>
-  case LibFunc_Znwj: // new(unsigned int)<br>
-  case LibFunc_Znwm: // new(unsigned long)<br>
-  case LibFunc_Znaj: // new[](unsigned int)<br>
-  case LibFunc_Znam: // new[](unsigned long)<br>
-  case LibFunc_msvc_new_int: // new(unsigned int)<br>
-  case LibFunc_msvc_new_longlong: // new(unsigned long long)<br>
-  case LibFunc_msvc_new_array_int: // new[](unsigned int)<br>
-  case LibFunc_msvc_new_array_longlong: // new[](unsigned long long)<br>
-    Changed |= setOnlyAccessesInaccessibleMemory(F);<br>
-    // Operator new always returns a nonnull noalias pointer<br>
-    Changed |= setRetNoUndef(F);<br>
-    Changed |= setRetNonNull(F);<br>
-    Changed |= setRetDoesNotAlias(F);<br>
-    return Changed;<br>
   // TODO: add LibFunc entries for:<br>
   // case LibFunc_memset_pattern4:<br>
   // case LibFunc_memset_pattern8:<br>
<br>
diff  --git a/llvm/test/Transforms/InferFunctionAttrs/annotate.ll b/llvm/test/Transforms/InferFunctionAttrs/annotate.ll<br>
index e866e12c0e68..5c6ec0b683ca 100644<br>
--- a/llvm/test/Transforms/InferFunctionAttrs/annotate.ll<br>
+++ b/llvm/test/Transforms/InferFunctionAttrs/annotate.ll<br>
@@ -448,7 +448,7 @@ declare i32 @fputs(i8*, %opaque*)<br>
 ; CHECK: declare noundef i64 @fread(i8* nocapture noundef, i64 noundef, i64 noundef, %opaque* nocapture noundef) [[NOFREE_NOUNWIND]]<br>
 declare i64 @fread(i8*, i64, i64, %opaque*)<br>
<br>
-; CHECK: declare void @free(i8* nocapture noundef) [[INACCESSIBLEMEMORARGMEMONLY_NOUNWIND:#[0-9]+]]<br>
+; CHECK: declare void @free(i8* nocapture noundef) [[NOUNWIND:#[0-9]+]]<br>
 declare void @free(i8*)<br>
<br>
 ; CHECK: declare double @frexp(double, i32* nocapture) [[NOFREE_NOUNWIND_WILLRETURN]]<br>
@@ -727,7 +727,7 @@ declare i64 @read(i32, i8*, i64)<br>
 ; CHECK: declare noundef i64 @readlink(i8* nocapture noundef readonly, i8* nocapture noundef, i64 noundef) [[NOFREE_NOUNWIND]]<br>
 declare i64 @readlink(i8*, i8*, i64)<br>
<br>
-; CHECK: declare noalias noundef i8* @realloc(i8* nocapture, i64) [[INACCESSIBLEMEMORARGMEMONLY_NOUNWIND]]<br>
+; CHECK: declare noalias noundef i8* @realloc(i8* nocapture, i64) [[NOUNWIND]]<br>
 declare i8* @realloc(i8*, i64)<br>
<br>
 ; CHECK: declare noundef i8* @reallocf(i8*, i64)<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>