<div dir="ltr">Ah, makes sense- thanks!</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jan 6, 2021 at 7:48 AM Krzysztof Parzyszek <<a href="mailto:kparzysz@quicinc.com">kparzysz@quicinc.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="EN-US" style="overflow-wrap: break-word;">
<div class="gmail-m_3348742290626341285WordSection1">
<p class="MsoNormal">This function (and one more like it) cannot be a non-member (not without adding extra parameters to it). I did wrap them in ifndef NDEBUG though in
<a href="https://reviews.llvm.org/rG46975b5b29e2" target="_blank">https://reviews.llvm.org/rG46975b5b29e2</a>.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><span style="font-size:9pt;font-family:Consolas">-- </span>
<span style="font-size:9pt;font-family:Consolas"><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:8pt;font-family:Consolas">Krzysztof Parzyszek
<a href="mailto:kparzysz@quicinc.com" target="_blank"><span style="color:rgb(5,99,193)">kparzysz@quicinc.com</span></a> AI tools development<u></u><u></u></span></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(225,225,225);padding:3pt 0in 0in">
<p class="MsoNormal"><b>From:</b> David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> <br>
<b>Sent:</b> Tuesday, January 5, 2021 7:13 PM<br>
<b>To:</b> Krzysztof Parzyszek <<a href="mailto:kparzysz@quicinc.com" target="_blank">kparzysz@quicinc.com</a>>; Krzysztof Parzyszek <<a href="mailto:llvmlistbot@llvm.org" target="_blank">llvmlistbot@llvm.org</a>><br>
<b>Cc:</b> llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>><br>
<b>Subject:</b> [EXT] Re: [llvm] ee11bf3 - [Hexagon] Silence unused function warning with gcc10, NFC<u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">FWIW, I'd suggest making this a non-member if possible, and wrapping it in an #ifndef NDEBUG as a lot of other debug/assert helper code is written.<u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Tue, Jan 5, 2021 at 12:12 PM Krzysztof Parzyszek via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal"><br>
Author: Krzysztof Parzyszek<br>
Date: 2021-01-05T14:11:45-06:00<br>
New Revision: ee11bf316f6be9dba29026b332fcde1dc3be4f9d<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/ee11bf316f6be9dba29026b332fcde1dc3be4f9d" target="_blank">
https://github.com/llvm/llvm-project/commit/ee11bf316f6be9dba29026b332fcde1dc3be4f9d</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/ee11bf316f6be9dba29026b332fcde1dc3be4f9d.diff" target="_blank">
https://github.com/llvm/llvm-project/commit/ee11bf316f6be9dba29026b332fcde1dc3be4f9d.diff</a><br>
<br>
LOG: [Hexagon] Silence unused function warning with gcc10, NFC<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff --git a/llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp b/llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp<br>
index 056a5a83a0a6..05269d37f812 100644<br>
--- a/llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp<br>
+++ b/llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp<br>
@@ -118,7 +118,7 @@ class HexagonVectorCombine {<br>
<br>
private:<br>
bool isByteVecTy(Type *Ty) const;<br>
- bool isSectorTy(Type *Ty) const;<br>
+ bool isSectorTy(Type *Ty) const LLVM_ATTRIBUTE_UNUSED;<br>
Value *getElementRange(IRBuilder<> &Builder, Value *Lo, Value *Hi, int Start,<br>
int Length) const;<br>
};<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><u></u><u></u></p>
</blockquote>
</div>
</div>
</div>
</blockquote></div>