<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi,<div class=""><br class=""></div><div class="">Is this commit or any related to do responsible for these bot failures? <a href="http://green.lab.llvm.org/green/job/clang-stage1-RA/17129" class="">http://green.lab.llvm.org/green/job/clang-stage1-RA/17129</a><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Amara</div><div class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Dec 16, 2020, at 11:59 AM, Mitch Phillips via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class=""><br class="">Author: Mitch Phillips<br class="">Date: 2020-12-16T11:59:10-08:00<br class="">New Revision: 30d292ddbb7ec84b422738cf52ee0cf49b0369f3<br class=""><br class="">URL: <a href="https://github.com/llvm/llvm-project/commit/30d292ddbb7ec84b422738cf52ee0cf49b0369f3" class="">https://github.com/llvm/llvm-project/commit/30d292ddbb7ec84b422738cf52ee0cf49b0369f3</a><br class="">DIFF: <a href="https://github.com/llvm/llvm-project/commit/30d292ddbb7ec84b422738cf52ee0cf49b0369f3.diff" class="">https://github.com/llvm/llvm-project/commit/30d292ddbb7ec84b422738cf52ee0cf49b0369f3.diff</a><br class=""><br class="">LOG: [sanitizer-common] Pickup llvm-symbolizer from $OUT/bin IFF exists.<br class=""><br class="">Fix-forward for D93352.<br class=""><br class="">Slight rework of the same idea, pickup the external symbolizer from the<br class="">binary directory iff it exists.<br class=""><br class="">Added: <br class=""><br class=""><br class="">Modified: <br class=""> compiler-rt/test/sanitizer_common/lit.common.cfg.py<br class=""> compiler-rt/test/sanitizer_common/lit.site.cfg.py.in<br class=""><br class="">Removed: <br class=""><br class=""><br class=""><br class="">################################################################################<br class="">diff --git a/compiler-rt/test/sanitizer_common/lit.common.cfg.py b/compiler-rt/test/sanitizer_common/lit.common.cfg.py<br class="">index f7c526b6b37b..1f037c00eb15 100644<br class="">--- a/compiler-rt/test/sanitizer_common/lit.common.cfg.py<br class="">+++ b/compiler-rt/test/sanitizer_common/lit.common.cfg.py<br class="">@@ -46,10 +46,9 @@<br class=""> # If the user has a poisoned *SAN_SYMBOLIZER_PATH (like what's setup by<br class=""> # build/envsetup.sh on Android), then they can end up with an out-of-date<br class=""> # symbolizer for the tests. Ensure they get the one from the recent build tree.<br class="">-symbolizer_path="''"<br class="">-if len(config.binary_path):<br class="">- symbolizer_path = os.path.join(config.binary_path, "llvm-symbolizer")<br class="">-default_tool_options += ['external_symbolizer_path=' + symbolizer_path]<br class="">+symbolizer_path = os.path.join(config.binary_path, "bin", "llvm-symbolizer")<br class="">+if os.path.exists(symbolizer_path):<br class="">+ default_tool_options += ['external_symbolizer_path=' + symbolizer_path]<br class=""><br class=""> default_tool_options_str = ':'.join(default_tool_options)<br class=""> if default_tool_options_str:<br class=""><br class="">diff --git a/compiler-rt/test/sanitizer_common/lit.site.cfg.py.in b/compiler-rt/test/sanitizer_common/lit.site.cfg.py.in<br class="">index 3ff7c44aeab4..fa7e54e51e27 100644<br class="">--- a/compiler-rt/test/sanitizer_common/lit.site.cfg.py.in<br class="">+++ b/compiler-rt/test/sanitizer_common/lit.site.cfg.py.in<br class="">@@ -5,7 +5,7 @@ config.name_suffix = "@CONFIG_NAME@"<br class=""> config.tool_name = "@SANITIZER_COMMON_LIT_TEST_MODE@"<br class=""> config.target_cflags = "@SANITIZER_COMMON_TEST_TARGET_CFLAGS@"<br class=""> config.target_arch = "@SANITIZER_COMMON_TEST_TARGET_ARCH@"<br class="">-config.binary_path = "@CMAKE_RUNTIME_OUTPUT_DIRECTORY@"<br class="">+config.binary_path = "@LLVM_BINARY_DIR@"<br class=""><br class=""> # Load common config for all compiler-rt lit tests.<br class=""> lit_config.load_config(config, "@COMPILER_RT_BINARY_DIR@/test/lit.common.configured")<br class=""><br class=""><br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br class=""></div></div></blockquote></div><br class=""></div></div></body></html>