<div dir="ltr">Any idea if this is the most suitable fix? Is "Bits" representing negative values? If not, perhaps it'd be more appropriate to remove the >= 0 comparison, rather than to change the type?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Dec 14, 2020 at 8:09 AM via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: diggerlin<br>
Date: 2020-12-14T11:08:40-05:00<br>
New Revision: 15f2d4f198380762e9fcf6b456d405078b87ae7a<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/15f2d4f198380762e9fcf6b456d405078b87ae7a" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/15f2d4f198380762e9fcf6b456d405078b87ae7a</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/15f2d4f198380762e9fcf6b456d405078b87ae7a.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/15f2d4f198380762e9fcf6b456d405078b87ae7a.diff</a><br>
<br>
LOG: [AIX] Fixed "comparison of unsigned expression >= 0 is always true" gcc warnings.<br>
<br>
Summary:<br>
<br>
fixed a  Fixed "comparison of unsigned expression >= 0 is always true" gcc warnings.<br>
<a href="http://lab.llvm.org:8011/#/builders/5/builds/2407/steps/2/logs/stdio" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/#/builders/5/builds/2407/steps/2/logs/stdio</a><br>
<br>
the error caused by patch <a href="https://reviews.llvm.org/D92398" rel="noreferrer" target="_blank">https://reviews.llvm.org/D92398</a><br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/lib/Target/PowerPC/PPCMachineFunctionInfo.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/llvm/lib/Target/PowerPC/PPCMachineFunctionInfo.cpp b/llvm/lib/Target/PowerPC/PPCMachineFunctionInfo.cpp<br>
index 02a425044c75..d364eb9d3996 100644<br>
--- a/llvm/lib/Target/PowerPC/PPCMachineFunctionInfo.cpp<br>
+++ b/llvm/lib/Target/PowerPC/PPCMachineFunctionInfo.cpp<br>
@@ -67,7 +67,7 @@ bool PPCFunctionInfo::isLiveInZExt(Register VReg) const {<br>
<br>
 void PPCFunctionInfo::appendParameterType(ParamType Type) {<br>
   uint32_t CopyParamType = ParameterType;<br>
-  unsigned Bits = 0;<br>
+  int Bits = 0;<br>
<br>
   // If it is fixed type, we only need to increase the FixedParamNum, for<br>
   // the bit encode of fixed type is bit of zero, we do not need to change the<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>