<div dir="ltr">Android fixed by <a href="https://github.com/llvm/llvm-project/commit/776a15d8aecad2768f1391092099e9b173b8148b">https://github.com/llvm/llvm-project/commit/776a15d8aecad2768f1391092099e9b173b8148b</a><br><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, 27 Oct 2020 at 23:49, Roman Lebedev <<a href="mailto:lebedev.ri@gmail.com">lebedev.ri@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Nice. Can you say what fixed them?<br>
<br>
Roman<br>
<br>
On Wed, Oct 28, 2020 at 9:44 AM Vitaly Buka via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
><br>
> Author: Vitaly Buka<br>
> Date: 2020-10-27T23:43:50-07:00<br>
> New Revision: 58828f6a93cd290cde2bf657a7c96a7399a328c1<br>
><br>
> URL: <a href="https://github.com/llvm/llvm-project/commit/58828f6a93cd290cde2bf657a7c96a7399a328c1" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/58828f6a93cd290cde2bf657a7c96a7399a328c1</a><br>
> DIFF: <a href="https://github.com/llvm/llvm-project/commit/58828f6a93cd290cde2bf657a7c96a7399a328c1.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/58828f6a93cd290cde2bf657a7c96a7399a328c1.diff</a><br>
><br>
> LOG: [NFC][UBSAN] Remove XFAIL from fixed tests<br>
><br>
> Added:<br>
><br>
><br>
> Modified:<br>
>     compiler-rt/test/ubsan/TestCases/ImplicitConversion/integer-sign-change-blacklist.c<br>
>     compiler-rt/test/ubsan/TestCases/ImplicitConversion/signed-integer-truncation-blacklist.c<br>
>     compiler-rt/test/ubsan/TestCases/ImplicitConversion/signed-integer-truncation-or-sign-change-blacklist.c<br>
>     compiler-rt/test/ubsan/TestCases/ImplicitConversion/unsigned-integer-truncation-blacklist.c<br>
><br>
> Removed:<br>
><br>
><br>
><br>
> ################################################################################<br>
> diff  --git a/compiler-rt/test/ubsan/TestCases/ImplicitConversion/integer-sign-change-blacklist.c b/compiler-rt/test/ubsan/TestCases/ImplicitConversion/integer-sign-change-blacklist.c<br>
> index c51296e2213c..8acc516fcaf1 100644<br>
> --- a/compiler-rt/test/ubsan/TestCases/ImplicitConversion/integer-sign-change-blacklist.c<br>
> +++ b/compiler-rt/test/ubsan/TestCases/ImplicitConversion/integer-sign-change-blacklist.c<br>
> @@ -1,6 +1,3 @@<br>
> -// FIXME: <a href="https://code.google.com/p/address-sanitizer/issues/detail?id=316" rel="noreferrer" target="_blank">https://code.google.com/p/address-sanitizer/issues/detail?id=316</a><br>
> -// I'm not sure this is actually *that* issue, but this seems oddly similar to the other XFAIL'ed cases.<br>
> -// XFAIL: android<br>
>  // UNSUPPORTED: ios<br>
><br>
>  // RUN: %clang -fsanitize=implicit-integer-sign-change -fno-sanitize-recover=implicit-integer-sign-change                           -O0 %s -o %t && not %run %t 2>&1 | FileCheck %s --implicit-check-not="implicit conversion"<br>
><br>
> diff  --git a/compiler-rt/test/ubsan/TestCases/ImplicitConversion/signed-integer-truncation-blacklist.c b/compiler-rt/test/ubsan/TestCases/ImplicitConversion/signed-integer-truncation-blacklist.c<br>
> index 1d1fe4ba1259..4598fb2e2a99 100644<br>
> --- a/compiler-rt/test/ubsan/TestCases/ImplicitConversion/signed-integer-truncation-blacklist.c<br>
> +++ b/compiler-rt/test/ubsan/TestCases/ImplicitConversion/signed-integer-truncation-blacklist.c<br>
> @@ -1,6 +1,3 @@<br>
> -// FIXME: <a href="https://code.google.com/p/address-sanitizer/issues/detail?id=316" rel="noreferrer" target="_blank">https://code.google.com/p/address-sanitizer/issues/detail?id=316</a><br>
> -// I'm not sure this is actually *that* issue, but this seems oddly similar to the other XFAIL'ed cases.<br>
> -// XFAIL: android<br>
>  // UNSUPPORTED: ios<br>
><br>
>  // RUN: %clang -fsanitize=implicit-integer-truncation -fno-sanitize-recover=implicit-integer-truncation                           -O0 %s -o %t && not %run %t 2>&1 | FileCheck %s --implicit-check-not="implicit conversion"<br>
><br>
> diff  --git a/compiler-rt/test/ubsan/TestCases/ImplicitConversion/signed-integer-truncation-or-sign-change-blacklist.c b/compiler-rt/test/ubsan/TestCases/ImplicitConversion/signed-integer-truncation-or-sign-change-blacklist.c<br>
> index 3c2a328ae9a0..e613f75c988d 100644<br>
> --- a/compiler-rt/test/ubsan/TestCases/ImplicitConversion/signed-integer-truncation-or-sign-change-blacklist.c<br>
> +++ b/compiler-rt/test/ubsan/TestCases/ImplicitConversion/signed-integer-truncation-or-sign-change-blacklist.c<br>
> @@ -1,6 +1,3 @@<br>
> -// FIXME: <a href="https://code.google.com/p/address-sanitizer/issues/detail?id=316" rel="noreferrer" target="_blank">https://code.google.com/p/address-sanitizer/issues/detail?id=316</a><br>
> -// I'm not sure this is actually *that* issue, but this seems oddly similar to the other XFAIL'ed cases.<br>
> -// XFAIL: android<br>
>  // UNSUPPORTED: ios<br>
><br>
>  // All of these don't actually silence it:<br>
><br>
> diff  --git a/compiler-rt/test/ubsan/TestCases/ImplicitConversion/unsigned-integer-truncation-blacklist.c b/compiler-rt/test/ubsan/TestCases/ImplicitConversion/unsigned-integer-truncation-blacklist.c<br>
> index 6ee572dbc8a2..2927e4bb2b9c 100644<br>
> --- a/compiler-rt/test/ubsan/TestCases/ImplicitConversion/unsigned-integer-truncation-blacklist.c<br>
> +++ b/compiler-rt/test/ubsan/TestCases/ImplicitConversion/unsigned-integer-truncation-blacklist.c<br>
> @@ -1,6 +1,3 @@<br>
> -// FIXME: <a href="https://code.google.com/p/address-sanitizer/issues/detail?id=316" rel="noreferrer" target="_blank">https://code.google.com/p/address-sanitizer/issues/detail?id=316</a><br>
> -// I'm not sure this is actually *that* issue, but this seems oddly similar to the other XFAIL'ed cases.<br>
> -// XFAIL: android<br>
>  // UNSUPPORTED: ios<br>
><br>
>  // RUN: %clang -fsanitize=implicit-integer-truncation -fno-sanitize-recover=implicit-integer-truncation                           -O0 %s -o %t && not %run %t 2>&1 | FileCheck %s --implicit-check-not="implicit conversion"<br>
><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>