<div dir="ltr">It's good to include some details on why a patch is reverted in the patch description for context/readers/history.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Oct 22, 2020 at 9:50 AM Arthur Eubanks via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Arthur Eubanks<br>
Date: 2020-10-22T09:49:42-07:00<br>
New Revision: 87520657b814227625149763ba750a56ae481448<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/87520657b814227625149763ba750a56ae481448" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/87520657b814227625149763ba750a56ae481448</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/87520657b814227625149763ba750a56ae481448.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/87520657b814227625149763ba750a56ae481448.diff</a><br>
<br>
LOG: Revert "[Docs] Clarify that FunctionPasses can't add/remove declarations"<br>
<br>
This reverts commit 710676cf3a3c6f6ddf2f18e24cac017d20dac1ff.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/docs/WritingAnLLVMPass.rst<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/llvm/docs/WritingAnLLVMPass.rst b/llvm/docs/WritingAnLLVMPass.rst<br>
index 5d8a9d645fa7..7a24659e6294 100644<br>
--- a/llvm/docs/WritingAnLLVMPass.rst<br>
+++ b/llvm/docs/WritingAnLLVMPass.rst<br>
@@ -474,8 +474,7 @@ external functions.<br>
 To be explicit, ``FunctionPass`` subclasses are not allowed to:<br>
<br>
 #. Inspect or modify a ``Function`` other than the one currently being processed.<br>
-#. Add or remove ``Function``\ s from the current ``Module``, including<br>
-   declarations.<br>
+#. Add or remove ``Function``\ s from the current ``Module``.<br>
 #. Add or remove global variables from the current ``Module``.<br>
 #. Maintain state across invocations of :ref:`runOnFunction<br>
    <writing-an-llvm-pass-runOnFunction>` (including global data).<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>