<div dir="ltr">Thanks for the cleanup - sorry I missed it!</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Oct 15, 2020 at 7:10 AM Jeremy Morse via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Jeremy Morse<br>
Date: 2020-10-15T15:09:33+01:00<br>
New Revision: 5e656ee48bccc73f1328db1770770acaec90a7c9<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/5e656ee48bccc73f1328db1770770acaec90a7c9" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/5e656ee48bccc73f1328db1770770acaec90a7c9</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/5e656ee48bccc73f1328db1770770acaec90a7c9.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/5e656ee48bccc73f1328db1770770acaec90a7c9.diff</a><br>
<br>
LOG: Add "not" to an llvm-symbolizer test that expects to fail<br>
<br>
In a7b209a6d40d77b, llvm-symbolizer was adjusted to return a failure status<br>
code when it produced an error, to flag up DWARF parsing problems. The<br>
test for missing PDB file is analogous, and returns a failure status now<br>
too.<br>
<br>
This should fix the llvm-clang-win-x-armv7l buildbot croaking:<br>
<br>
  <a href="http://lab.llvm.org:8011/#/builders/60/builds/77" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/#/builders/60/builds/77</a><br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/test/tools/llvm-symbolizer/pdb/missing_pdb.test<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/llvm/test/tools/llvm-symbolizer/pdb/missing_pdb.test b/llvm/test/tools/llvm-symbolizer/pdb/missing_pdb.test<br>
index b83b46a75213..7e7fa79c4b38 100644<br>
--- a/llvm/test/tools/llvm-symbolizer/pdb/missing_pdb.test<br>
+++ b/llvm/test/tools/llvm-symbolizer/pdb/missing_pdb.test<br>
@@ -1,4 +1,4 @@<br>
-RUN: llvm-symbolizer 0x401000 0x401001 -obj="%p/Inputs/missing_pdb.exe" 2>%t.err \<br>
+RUN: not llvm-symbolizer 0x401000 0x401001 -obj="%p/Inputs/missing_pdb.exe" 2>%t.err \<br>
 RUN:    | FileCheck %s<br>
 RUN: FileCheck --check-prefix=ERROR %s < %t.err<br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>