<div dir="ltr">Release+Asserts on x86_64-linux and the debug-info-codeview-buildinfo.c test. Sorry if the latter wasn't clear :)<div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jul 10, 2020 at 4:12 PM Alexandre Ganea <<a href="mailto:alexandre.ganea@ubisoft.com">alexandre.ganea@ubisoft.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="EN-CA">
<div class="gmail-m_7988818421256221460WordSection1">
<p class="MsoNormal"><span>Thanks for letting me know Eric. What test fails exactly? What config?<u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<p class="MsoNormal"><b>De :</b> Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>> <br>
<b>Envoyé :</b> July 10, 2020 7:04 PM<br>
<b>À :</b> <a href="mailto:reviews%2BD80833%2Bpublic%2Bda87cf0eabdca5a2@reviews.llvm.org" target="_blank">reviews+D80833+public+da87cf0eabdca5a2@reviews.llvm.org</a>; Alexandre Ganea via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>><br>
<b>Cc :</b> Alexandre Ganea <<a href="mailto:alexandre.ganea@ubisoft.com" target="_blank">alexandre.ganea@ubisoft.com</a>>; Hans Wennborg <<a href="mailto:hans@chromium.org" target="_blank">hans@chromium.org</a>>; Adrian McCarthy <<a href="mailto:amccarth@google.com" target="_blank">amccarth@google.com</a>>; Martin Storsjo <<a href="mailto:martin@martin.st" target="_blank">martin@martin.st</a>>; Amy Huang <<a href="mailto:akhuang@google.com" target="_blank">akhuang@google.com</a>>; <a href="mailto:dmajor@mozilla.com" target="_blank">dmajor@mozilla.com</a>; <a href="mailto:john.reagan@vmssoftware.com" target="_blank">john.reagan@vmssoftware.com</a>; <a href="mailto:zturner@roblox.com" target="_blank">zturner@roblox.com</a>;
<a href="mailto:88888yl@gmail.com" target="_blank">88888yl@gmail.com</a>; llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>>; <a href="mailto:stefan.reinalter@molecular-matters.com" target="_blank">stefan.reinalter@molecular-matters.com</a>; Ulrich Weigand <<a href="mailto:ulrich.weigand@de.ibm.com" target="_blank">ulrich.weigand@de.ibm.com</a>>; <a href="mailto:mlekena@skidmore.edu" target="_blank">mlekena@skidmore.edu</a>; Clang Commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>>; Han Shen <<a href="mailto:shenhan@google.com" target="_blank">shenhan@google.com</a>><br>
<b>Objet :</b> Re: [PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">I'm seeing tests fail with a crash. Can we revert the patch and attempted fixes and start working from there?<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Stacktrace for the curious :)<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"> @ 0x56420187cbbe llvm::MCStreamer::emitIntValue()<br>
@ 0x5641fec38899 llvm::MCStreamer::emitInt16()<br>
@ 0x5641ff73b337 llvm::CodeViewDebug::emitCompilerInformation()<br>
@ 0x5641ff73ac73 llvm::CodeViewDebug::endModule()<br>
@ 0x5641ff718e83 llvm::AsmPrinter::doFinalization()<br>
@ 0x5642016fd9ca llvm::FPPassManager::doFinalization()<br>
@ 0x5642016f954e (anonymous namespace)::MPPassManager::runOnModule()<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">-eric<u></u><u></u></p>
</div>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Tue, Jun 30, 2020 at 11:56 AM Alexandre Ganea via Phabricator via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0cm 0cm 0cm 6pt;margin:5pt 0cm 5pt 4.8pt">
<p class="MsoNormal">aganea added a comment.<br>
<br>
In D80833#2109172 <<a href="https://reviews.llvm.org/D80833#2109172" target="_blank">https://reviews.llvm.org/D80833#2109172</a>>, @uweigand wrote:<br>
<br>
> Hmm, with clang-cl it seems the driver is trying to use this:<br>
> Target: s390x-pc-windows-msvc<br>
> which of course doesn't exist. Not sure what is supposed to be happening here, but it seems that it's falling back on s390x-linux since on s390x, Linux is currently the only supported OS.<br>
<br>
<br>
I'm seeing some of the tests are setting the target explicitly `%clang_cl --target=x86_64-windows-msvc`. Would that work on your machine? Or should I do `UNSUPPORTED: s390x` ?<br>
<br>
<br>
Repository:<br>
rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://reviews.llvm.org/D80833/new/" target="_blank">https://reviews.llvm.org/D80833/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D80833" target="_blank">https://reviews.llvm.org/D80833</a><br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><u></u><u></u></p>
</blockquote>
</div>
</div>
</div>
</blockquote></div>