<div dir="ltr"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Jun 20, 2020 at 3:27 PM Eric Christopher via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Eric Christopher<br>
Date: 2020-06-20T00:51:18-07:00<br>
New Revision: ae2fa770e1c37d959ff7bf414725f1c7615a5546<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/ae2fa770e1c37d959ff7bf414725f1c7615a5546" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/ae2fa770e1c37d959ff7bf414725f1c7615a5546</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/ae2fa770e1c37d959ff7bf414725f1c7615a5546.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/ae2fa770e1c37d959ff7bf414725f1c7615a5546.diff</a><br>
<br>
LOG: [docs/examples] As part of using inclusive language within the llvm<br>
project, migrate away from the use of blacklist and whitelist.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
llvm/docs/HowToAddABuilder.rst<br>
llvm/docs/ORCv2.rst<br>
llvm/docs/Proposals/GitHubMove.rst<br>
llvm/docs/Statepoints.rst<br>
llvm/examples/OrcV2Examples/OrcV2CBindingsReflectProcessSymbols/OrcV2CBindingsReflectProcessSymbols.c<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff --git a/llvm/docs/HowToAddABuilder.rst b/llvm/docs/HowToAddABuilder.rst<br>
index 6912d2c14b6b..a30073d92510 100644<br>
--- a/llvm/docs/HowToAddABuilder.rst<br>
+++ b/llvm/docs/HowToAddABuilder.rst<br>
@@ -91,7 +91,7 @@ Here are the steps you can follow to do so:<br>
Please make sure your builder name and its builddir are unique through the<br>
file.<br>
<br>
- It is possible to whitelist email addresses to unconditionally receive<br>
+ It is possible to allow email addresses to unconditionally receive<br>
notifications on build failure; for this you'll need to add an<br>
``InformativeMailNotifier`` to ``buildbot/osuosl/master/config/status.py``.<br>
This is particularly useful for the staging buildmaster which is silent<br>
<br>
diff --git a/llvm/docs/ORCv2.rst b/llvm/docs/ORCv2.rst<br>
index f5a07e6d5211..5257ba9d9203 100644<br>
--- a/llvm/docs/ORCv2.rst<br>
+++ b/llvm/docs/ORCv2.rst<br>
@@ -729,7 +729,7 @@ For example, to load the whole interface of a runtime library:<br>
// at '/path/to/lib'.<br>
CompileLayer.add(JD, loadModule(...));<br>
<br>
-Or, to expose a whitelisted set of symbols from the main process:<br>
+Or, to expose a allowed set of symbols from the main process:<br></blockquote><div>s/a allowed/an allowed/;<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
.. code-block:: c++<br>
<br>
@@ -738,20 +738,20 @@ Or, to expose a whitelisted set of symbols from the main process:<br>
<br>
auto &JD = ES.createJITDylib("main");<br>
<br>
- DenseSet<SymbolStringPtr> Whitelist({<br>
+ DenseSet<SymbolStringPtr> AllowList({<br>
Mangle("puts"),<br>
Mangle("gets")<br>
});<br>
<br>
// Use GetForCurrentProcess with a predicate function that checks the<br>
- // whitelist.<br>
+ // allowed list.<br>
JD.setGenerator(<br>
DynamicLibrarySearchGenerator::GetForCurrentProcess(<br>
DL.getGlobalPrefix(),<br>
- [&](const SymbolStringPtr &S) { return Whitelist.count(S); }));<br>
+ [&](const SymbolStringPtr &S) { return AllowList.count(S); }));<br>
<br>
// IR added to JD can now link against any symbols exported by the process<br>
- // and contained in the whitelist.<br>
+ // and contained in the list.<br>
CompileLayer.add(JD, loadModule(...));<br>
<br>
Future Features<br>
<br>
diff --git a/llvm/docs/Proposals/GitHubMove.rst b/llvm/docs/Proposals/GitHubMove.rst<br>
index 858f88a84d8b..d11dbe260c5c 100644<br>
--- a/llvm/docs/Proposals/GitHubMove.rst<br>
+++ b/llvm/docs/Proposals/GitHubMove.rst<br>
@@ -141,9 +141,9 @@ Unfortunately, GitHub does not support server side hooks to enforce such a<br>
policy. We must rely on the community to avoid pushing merge commits.<br>
<br>
GitHub offers a feature called `Status Checks`: a branch protected by<br>
-`status checks` requires commits to be whitelisted before the push can happen.<br>
+`status checks` requires commits to be explicitly allowed before the push can happen.<br>
We could supply a pre-push hook on the client side that would run and check the<br>
-history, before whitelisting the commit being pushed [statuschecks]_.<br>
+history, before allowing the commit being pushed [statuschecks]_.<br>
However this solution would be somewhat fragile (how do you update a script<br>
installed on every developer machine?) and prevents SVN access to the<br>
repository.<br>
<br>
diff --git a/llvm/docs/Statepoints.rst b/llvm/docs/Statepoints.rst<br>
index 034cbff65c95..f55445a1063c 100644<br>
--- a/llvm/docs/Statepoints.rst<br>
+++ b/llvm/docs/Statepoints.rst<br>
@@ -772,7 +772,7 @@ relocation sequence, including all required ``gc.relocates``.<br>
<br>
Note that by default, this pass only runs for the "statepoint-example" or <br>
"core-clr" gc strategies. You will need to add your custom strategy to this <br>
-whitelist or use one of the predefined ones. <br>
+list or use one of the predefined ones. <br>
<br>
As an example, given this code:<br>
<br>
<br>
diff --git a/llvm/examples/OrcV2Examples/OrcV2CBindingsReflectProcessSymbols/OrcV2CBindingsReflectProcessSymbols.c b/llvm/examples/OrcV2Examples/OrcV2CBindingsReflectProcessSymbols/OrcV2CBindingsReflectProcessSymbols.c<br>
index a9c65103c2c6..790f153260ee 100644<br>
--- a/llvm/examples/OrcV2Examples/OrcV2CBindingsReflectProcessSymbols/OrcV2CBindingsReflectProcessSymbols.c<br>
+++ b/llvm/examples/OrcV2Examples/OrcV2CBindingsReflectProcessSymbols/OrcV2CBindingsReflectProcessSymbols.c<br>
@@ -27,14 +27,14 @@ int32_t add(int32_t X, int32_t Y) { return X + Y; }<br>
<br>
int32_t mul(int32_t X, int32_t Y) { return X * Y; }<br>
<br>
-int whitelistedSymbols(LLVMOrcSymbolStringPoolEntryRef Sym, void *Ctx) {<br>
- assert(Ctx && "Cannot call whitelistedSymbols with a null context");<br>
+int allowedSymbols(LLVMOrcSymbolStringPoolEntryRef Sym, void *Ctx) {<br>
+ assert(Ctx && "Cannot call allowedSymbols with a null context");<br>
<br>
- LLVMOrcSymbolStringPoolEntryRef *Whitelist =<br>
+ LLVMOrcSymbolStringPoolEntryRef *AllowList =<br>
(LLVMOrcSymbolStringPoolEntryRef *)Ctx;<br>
<br>
- // If Sym appears in the whitelist then return true.<br>
- LLVMOrcSymbolStringPoolEntryRef *P = Whitelist;<br>
+ // If Sym appears in the allowed list then return true.<br>
+ LLVMOrcSymbolStringPoolEntryRef *P = AllowList;<br>
while (*P) {<br>
if (Sym == *P)<br>
return 1;<br>
@@ -134,11 +134,11 @@ int main(int argc, char *argv[]) {<br>
}<br>
}<br>
<br>
- // Build a filter to allow JIT'd code to only access whitelisted symbols.<br>
+ // Build a filter to allow JIT'd code to only access allowed symbols.<br>
// This filter is optional: If a null value is suppled for the Filter<br>
// argument to LLVMOrcCreateDynamicLibrarySearchGeneratorForProcess then<br>
// all process symbols will be reflected.<br>
- LLVMOrcSymbolStringPoolEntryRef Whitelist[] = {<br>
+ LLVMOrcSymbolStringPoolEntryRef AllowList[] = {<br>
LLVMOrcLLJITMangleAndIntern(J, "mul"),<br>
LLVMOrcLLJITMangleAndIntern(J, "add"), 0};<br>
<br>
@@ -147,7 +147,7 @@ int main(int argc, char *argv[]) {<br>
LLVMErrorRef Err;<br>
if ((Err = LLVMOrcCreateDynamicLibrarySearchGeneratorForProcess(<br>
&ProcessSymbolsGenerator, LLVMOrcLLJITGetGlobalPrefix(J),<br>
- whitelistedSymbols, Whitelist))) {<br>
+ allowedSymbols, AllowList))) {<br>
MainResult = handleError(Err);<br>
goto jit_cleanup;<br>
}<br>
@@ -192,9 +192,9 @@ int main(int argc, char *argv[]) {<br>
<br>
jit_cleanup:<br>
// Release all symbol string pool entries that we have allocated. In this<br>
- // example that's just our whitelist entries.<br>
+ // example that's just our allowed entries.<br>
{<br>
- LLVMOrcSymbolStringPoolEntryRef *P = Whitelist;<br>
+ LLVMOrcSymbolStringPoolEntryRef *P = AllowList;<br>
while (*P)<br>
LLVMOrcReleaseSymbolStringPoolEntry(*P++);<br>
}<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>