<div dir="ltr">Hi David,<div><br></div><div>I pushed the change as <a href="https://github.com/llvm/llvm-project/commit/6b9e1022436336b4ee7fa425f641f1cdcbd8f839">https://github.com/llvm/llvm-project/commit/6b9e1022436336b4ee7fa425f641f1cdcbd8f839</a></div><div><br></div><div>Thanks</div><div>Yvan</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 1 Jun 2020 at 20:41, David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Ping<br>
<br>
On Tue, May 19, 2020 at 11:41 AM David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:<br>
><br>
> Ah, thanks!<br>
><br>
> Could it be taken a step further and statically allocated instead of dynamically allocated?<br>
> Replacing:<br>
> auto Costs = std::make_unique<OutlinerCosts>(Subtarget);<br>
> with:<br>
> OutlinerCosts Costs(Subtarget);<br>
><br>
> ?<br>
> On Mon, May 18, 2020 at 11:36 PM Yvan Roux <<a href="mailto:yvan.roux@linaro.org" target="_blank">yvan.roux@linaro.org</a>> wrote:<br>
>><br>
>> Hi David,<br>
>><br>
>> On Mon, 18 May 2020 at 21:50, David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:<br>
>>><br>
>>> Any chance of using unique_ptr (or non-dynamic allocation), etc, to simplify this memory management?<br>
>><br>
>><br>
>> Yes I replaced it by make_unique shorty after this commit here:<br>
>> <a href="https://github.com/llvm/llvm-project/commit/3648dde3ddd3cc0ba862017d494b7ede6054631c" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/3648dde3ddd3cc0ba862017d494b7ede6054631c</a><br>
>><br>
>> Cheers,<br>
>> Yvan<br>
>><br>
>>><br>
>>><br>
>>> On Fri, May 15, 2020 at 7:27 AM Yvan Roux via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
>>>><br>
>>>><br>
>>>> Author: Yvan Roux<br>
>>>> Date: 2020-05-15T16:27:14+02:00<br>
>>>> New Revision: 96c4460a0be6f5f66a02eac7fe796e49768001a4<br>
>>>><br>
>>>> URL: <a href="https://github.com/llvm/llvm-project/commit/96c4460a0be6f5f66a02eac7fe796e49768001a4" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/96c4460a0be6f5f66a02eac7fe796e49768001a4</a><br>
>>>> DIFF: <a href="https://github.com/llvm/llvm-project/commit/96c4460a0be6f5f66a02eac7fe796e49768001a4.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/96c4460a0be6f5f66a02eac7fe796e49768001a4.diff</a><br>
>>>><br>
>>>> LOG: [ARM][MachineOutliner] Fix memory leak.<br>
>>>><br>
>>>> Fix sanitizer bots after 0e4827aa4e4ae25813f66d3b872db67d93813009<br>
>>>><br>
>>>> Added:<br>
>>>><br>
>>>><br>
>>>> Modified:<br>
>>>>     llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp<br>
>>>><br>
>>>> Removed:<br>
>>>><br>
>>>><br>
>>>><br>
>>>> ################################################################################<br>
>>>> diff  --git a/llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp b/llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp<br>
>>>> index c160843fcdba..20df55f55bc8 100644<br>
>>>> --- a/llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp<br>
>>>> +++ b/llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp<br>
>>>> @@ -5668,6 +5668,7 @@ outliner::OutlinedFunction ARMBaseInstrInfo::getOutliningCandidateInfo(<br>
>>>>    } else<br>
>>>>      return outliner::OutlinedFunction();<br>
>>>><br>
>>>> +  delete Costs;<br>
>>>>    return outliner::OutlinedFunction(RepeatedSequenceLocs, SequenceSize,<br>
>>>>                                      NumBytesToCreateFrame, FrameID);<br>
>>>>  }<br>
>>>><br>
>>>><br>
>>>><br>
>>>> _______________________________________________<br>
>>>> llvm-commits mailing list<br>
>>>> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
>>>> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>