<div dir="ltr">Thanks for the comments!<div><br></div><div>I don't have a big-endian machine, so I'll find someone to help check what the remaining endianness issues are.</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jun 3, 2020 at 8:18 PM Hubert Tong <<a href="mailto:hubert.reinterpretcast@gmail.com">hubert.reinterpretcast@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jun 3, 2020 at 10:59 PM Fangrui Song via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Fangrui Song<br>
Date: 2020-06-03T19:58:28-07:00<br>
New Revision: c1ea672ddb919c50118f4031845af6bb9be95454<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/c1ea672ddb919c50118f4031845af6bb9be95454" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/c1ea672ddb919c50118f4031845af6bb9be95454</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/c1ea672ddb919c50118f4031845af6bb9be95454.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/c1ea672ddb919c50118f4031845af6bb9be95454.diff</a><br>
<br>
LOG: [gcov] Delete XFAIL: host-byteorder-big-endian<br>
<br>
Add two to function-numbering.ll and exit-block.ll<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
llvm/test/Transforms/GCOVProfiling/exit-block.ll<br>
llvm/test/Transforms/GCOVProfiling/function-numbering.ll<br>
llvm/test/Transforms/SampleProfile/gcc-simple.ll<br>
llvm/test/Transforms/SampleProfile/indirect-call-gcc.ll<br>
llvm/test/tools/llvm-cov/gcov-4.7.c<br>
llvm/test/tools/llvm-cov/gcov-8.c<br>
llvm/test/tools/llvm-cov/gcov-9.c<br>
llvm/test/tools/llvm-profdata/gcc-gcov-sample-profile.test<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff --git a/llvm/test/Transforms/GCOVProfiling/exit-block.ll b/llvm/test/Transforms/GCOVProfiling/exit-block.ll<br>
index 202479e72e0c..5ab3dcc9f499 100644<br>
--- a/llvm/test/Transforms/GCOVProfiling/exit-block.ll<br>
+++ b/llvm/test/Transforms/GCOVProfiling/exit-block.ll<br>
@@ -2,6 +2,7 @@<br>
; RUN: rm -rf %t && mkdir -p %t<br>
; RUN: echo '!19 = !{!"%/t/exit-block.ll", !0}' > %t/1<br>
; RUN: cat %s %t/1 > %t/2<br>
+; XFAIL: host-byteorder-big-endian<br>
<br>
; By default, the exit block is the second.<br>
; RUN: opt -insert-gcov-profiling -disable-output %t/2<br>
<br>
diff --git a/llvm/test/Transforms/GCOVProfiling/function-numbering.ll b/llvm/test/Transforms/GCOVProfiling/function-numbering.ll<br>
index 973b29f590c4..533bb0a38f7c 100644<br>
--- a/llvm/test/Transforms/GCOVProfiling/function-numbering.ll<br>
+++ b/llvm/test/Transforms/GCOVProfiling/function-numbering.ll<br>
@@ -1,5 +1,6 @@<br>
; Test that GCOV instrumentation numbers functions correctly when some<br>
; functions aren't emitted.<br>
+; XFAIL: host-byteorder-big-endian<br>
<br>
; Inject metadata to set the .gcno file location<br>
; RUN: rm -rf %t && mkdir -p %t<br>
<br>
diff --git a/llvm/test/Transforms/SampleProfile/gcc-simple.ll b/llvm/test/Transforms/SampleProfile/gcc-simple.ll<br>
index f778124c2200..71ff19ff1f48 100644<br>
--- a/llvm/test/Transforms/SampleProfile/gcc-simple.ll<br>
+++ b/llvm/test/Transforms/SampleProfile/gcc-simple.ll<br>
@@ -1,6 +1,6 @@<br>
; RUN: opt < %s -sample-profile -sample-profile-file=%S/Inputs/gcc-simple.afdo -S | FileCheck %s<br>
; RUN: opt < %s -passes=sample-profile -sample-profile-file=%S/Inputs/gcc-simple.afdo -S | FileCheck %s<br>
-; XFAIL: host-byteorder-big-endian<br>
+;<br>
; Original code:<br>
;<br>
; #include <stdlib.h><br>
<br>
diff --git a/llvm/test/Transforms/SampleProfile/indirect-call-gcc.ll b/llvm/test/Transforms/SampleProfile/indirect-call-gcc.ll<br>
index 5298fab44ab1..a9b3eaacff7b 100644<br>
--- a/llvm/test/Transforms/SampleProfile/indirect-call-gcc.ll<br>
+++ b/llvm/test/Transforms/SampleProfile/indirect-call-gcc.ll<br>
@@ -4,7 +4,6 @@<br>
; format profile.<br>
; It is expected to fail on certain architectures as gcc profile reader does<br>
; not work.<br></blockquote><div>The comments should be updated too.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
-; XFAIL: host-byteorder-big-endian<br>
<br>
define void @test(void ()*) #0 !dbg !3 {<br>
%2 = alloca void ()*<br>
<br>
diff --git a/llvm/test/tools/llvm-cov/gcov-4.7.c b/llvm/test/tools/llvm-cov/gcov-4.7.c<br>
index ab08883bde7e..594382bf2900 100644<br>
--- a/llvm/test/tools/llvm-cov/gcov-4.7.c<br>
+++ b/llvm/test/tools/llvm-cov/gcov-4.7.c<br>
@@ -33,5 +33,3 @@ int main() { // GCOV: #####: [[@LINE]]<br>
// HEADER-NEXT: -: 0:Runs:1{{$}}<br>
// HEADER-NEXT: -: 0:Programs:1<br>
// HEADER-NEXT: -: 1:/// Test that llvm-cov<br>
-<br>
-// XFAIL: host-byteorder-big-endian<br>
<br>
diff --git a/llvm/test/tools/llvm-cov/gcov-8.c b/llvm/test/tools/llvm-cov/gcov-8.c<br>
index f8cdd18f99bd..4ac9cd671fe2 100644<br>
--- a/llvm/test/tools/llvm-cov/gcov-8.c<br>
+++ b/llvm/test/tools/llvm-cov/gcov-8.c<br>
@@ -33,5 +33,3 @@ int main() { // GCOV: 1: [[@LINE]]:int<br>
// HEADER-NEXT: -: 0:Runs:1{{$}}<br>
// HEADER-NEXT: -: 0:Programs:1<br>
// HEADER-NEXT: -: 1:/// Test that llvm-cov<br>
-<br>
-// XFAIL: host-byteorder-big-endian<br>
<br>
diff --git a/llvm/test/tools/llvm-cov/gcov-9.c b/llvm/test/tools/llvm-cov/gcov-9.c<br>
index 6e631cb078cf..db6190ad5fbb 100644<br>
--- a/llvm/test/tools/llvm-cov/gcov-9.c<br>
+++ b/llvm/test/tools/llvm-cov/gcov-9.c<br>
@@ -32,5 +32,3 @@ int main() { // GCOV: 1: [[@LINE]]:int<br>
// HEADER-NEXT: -: 0:Data:gcov-9.gcda<br>
// HEADER-NEXT: -: 0:Runs:1{{$}}<br>
// HEADER-NEXT: -: 1:/// Test that llvm-cov<br>
-<br>
-// XFAIL: host-byteorder-big-endian<br>
<br>
diff --git a/llvm/test/tools/llvm-profdata/gcc-gcov-sample-profile.test b/llvm/test/tools/llvm-profdata/gcc-gcov-sample-profile.test<br>
index 42ae5d233092..5f6c2a221eb2 100644<br>
--- a/llvm/test/tools/llvm-profdata/gcc-gcov-sample-profile.test<br>
+++ b/llvm/test/tools/llvm-profdata/gcc-gcov-sample-profile.test<br>
@@ -1,8 +1,6 @@<br>
The input gcov file has been generated on a little endian machine. Expect<br>
failures on big endian systems.<br></blockquote><div>Same here. Maybe check all of the files?<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
-XFAIL: host-byteorder-big-endian<br>
-<br>
Tests for sample profiles encoded in GCC's gcov format.<br>
<br>
1- Show all functions. This profile has a single main() function with several<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr">宋方睿</div></div>