<div dir="ltr">Thanks Dave!<div><br></div><div>-- Lang.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, May 26, 2020 at 12:32 PM David Blaikie via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">dblaikie added inline comments.<br>
<br>
<br>
================<br>
Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_x86_64.cpp:100<br>
+        Value = SymRef.getValue();<br>
+        LLVM_DEBUG({<br>
+          dbgs() << "  ";<br>
----------------<br>
abhinavgaba wrote:<br>
> `Binding` and `Value` are read only inside this `LLVM_DEBUG`, making them unread if debug messages are disabled.<br>
> <br>
>   error: variable ‘Binding’ set but not used [-Werror=unused-but-set-variable]<br>
Usually easier to commit fixes for things like this directly, rather than going through a round of feedback, waiting for someone to fix, etc.<br>
<br>
I've fixed this in fca76b79456c916fd2ce193ef76d6e795bd9c105<br>
<br>
<br>
Repository:<br>
  rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D79832/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D79832/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D79832" rel="noreferrer" target="_blank">https://reviews.llvm.org/D79832</a><br>
<br>
<br>
<br>
</blockquote></div>