<html><body><p><font size="2">Added a test and better description of the problem in </font><font color="#202124" face="Helvetica">rG0fee91a187d9</font><font size="2">.</font><br><br><img width="16" height="16" src="cid:1__=8FBB0FEBDFE1F9238f9e8a93df938690918c8FB@" border="0" alt="Inactive hide details for Roman Lebedev ---2020/05/30 02:47:45 PM---Test? Patch commit message isn't very detailed - what's the"><font size="2" color="#424282">Roman Lebedev ---2020/05/30 02:47:45 PM---Test? Patch commit message isn't very detailed - what's the actual problem</font><br><br><font size="2" color="#5F5F5F">From: </font><font size="2">Roman Lebedev <lebedev.ri@gmail.com></font><br><font size="2" color="#5F5F5F">To: </font><font size="2">Whitney Tsang <whitneyt@ca.ibm.com>, Whitney Tsang <llvmlistbot@llvm.org></font><br><font size="2" color="#5F5F5F">Cc: </font><font size="2">llvm-commits@lists.llvm.org</font><br><font size="2" color="#5F5F5F">Date: </font><font size="2">2020/05/30 02:47 PM</font><br><font size="2" color="#5F5F5F">Subject: </font><font size="2">[EXTERNAL] Re: [llvm] 7873376 - [LoopUnroll] Fix build failure for allyesconfig.</font><br><hr width="100%" size="2" align="left" noshade style="color:#8091A5; "><br><br><br><tt><font size="2">Test?<br>Patch commit message isn't very detailed - what's the actual problem<br>with previous code?<br><br>On Sat, May 30, 2020 at 9:41 PM Whitney Tsang via llvm-commits<br><llvm-commits@lists.llvm.org> wrote:<br>><br>><br>> Author: Whitney Tsang<br>> Date: 2020-05-30T18:32:47Z<br>> New Revision: 7873376bb36b4f9646fbc26d6da88e2edbf796e4<br>><br>> URL: </font></tt><tt><font size="2"><a href="https://github.com/llvm/llvm-project/commit/7873376bb36b4f9646fbc26d6da88e2edbf796e4">https://github.com/llvm/llvm-project/commit/7873376bb36b4f9646fbc26d6da88e2edbf796e4</a></font></tt><tt><font size="2"> <br>> DIFF: </font></tt><tt><font size="2"><a href="https://github.com/llvm/llvm-project/commit/7873376bb36b4f9646fbc26d6da88e2edbf796e4.diff">https://github.com/llvm/llvm-project/commit/7873376bb36b4f9646fbc26d6da88e2edbf796e4.diff</a></font></tt><tt><font size="2"> <br>><br>> LOG: [LoopUnroll] Fix build failure for allyesconfig.<br>><br>> Differential Revision: </font></tt><tt><font size="2"><a href="https://reviews.llvm.org/D80477">https://reviews.llvm.org/D80477</a></font></tt><tt><font size="2"> .<br>><br>> Added:<br>><br>><br>> Modified:<br>> llvm/lib/Transforms/Utils/LoopUnroll.cpp<br>><br>> Removed:<br>><br>><br>><br>> ################################################################################<br>> diff --git a/llvm/lib/Transforms/Utils/LoopUnroll.cpp b/llvm/lib/Transforms/Utils/LoopUnroll.cpp<br>> index 06e9f7ff2f53..861fc7d46ffe 100644<br>> --- a/llvm/lib/Transforms/Utils/LoopUnroll.cpp<br>> +++ b/llvm/lib/Transforms/Utils/LoopUnroll.cpp<br>> @@ -818,10 +818,10 @@ LoopUnrollResult llvm::UnrollLoop(Loop *L, UnrollLoopOptions ULO, LoopInfo *LI,<br>> // For loops exiting from non latch exiting block, we limit the<br>> // supported loops to have a single exiting block.<br>> NewIDom = TermBlocks.back();<br>> - for (BasicBlock *Iter : TermBlocks) {<br>> - Instruction *Term = Iter->getTerminator();<br>> + for (unsigned i = 0, e = TermBlocks.size(); i != e; ++i) {<br>> + Instruction *Term = TermBlocks[i]->getTerminator();<br>> if (isa<BranchInst>(Term) && cast<BranchInst>(Term)->isConditional()) {<br>> - NewIDom = Iter;<br>> + NewIDom = DT->findNearestCommonDominator(TermBlocks[i], Latches[i]);<br>> break;<br>> }<br>> }<br>><br>><br>><br>> _______________________________________________<br>> llvm-commits mailing list<br>> llvm-commits@lists.llvm.org<br>> </font></tt><tt><font size="2"><a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a></font></tt><tt><font size="2"> <br><br></font></tt><br><br><BR>
</body></html>