<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}
p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>Hi Petr,<br></div><div><br></div><div>I'm about to revert this and fix a couple other weekend breakages. Try again in 10 minutes.<br></div><div><br></div><div>Dave<br></div><div><br></div><div>On Sat, Apr 4, 2020, at 6:07 PM, Petr Hosek via llvm-commits wrote:<br></div><blockquote type="cite" id="qt"><div dir="ltr"><div>We're also seeing the breakage when new pass manager is enabled by default. Can we revert this please?<br></div><div><br></div><div class="qt-gmail_quote"><div dir="ltr" class="qt-gmail_attr">On Sat, Apr 4, 2020 at 5:21 AM David Zarzycki via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="qt-gmail_quote" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204, 204, 204);padding-left:1ex;"><div>Hi Paul,<br></div><div><br></div><div>This breaks the first phase of my test bot/script. Can we please revert this? This isn't all of the output, but hopefully what follows is helpful:<br></div><div><br></div><div>BISECT: NOT running pass (152) Stack Slot Coloring on function (f4)<br></div><div>BISECT: NOT running pass (153) Machine Copy Propagation Pass on function (f4)<br></div><div>BISECT: NOT running pass (154) Machine Loop Invariant Code Motion on function (f4)<br></div><div>BISECT: NOT running pass (155) PostRA Machine Sink on function (f4)<br></div><div>BISECT: NOT running pass (156) Shrink Wrapping analysis on function (f4)<br></div><div>BISECT: NOT running pass (157) Control Flow Optimizer on function (f4)<br></div><div>BISECT: NOT running pass (158) Tail Duplication on function (f4)<br></div><div>BISECT: NOT running pass (159) Machine Copy Propagation Pass on function (f4)<br></div><div>BISECT: NOT running pass (160) Post RA top-down list latency scheduler on function (f4)<br></div><div>BISECT: NOT running pass (161) Branch Probability Basic Block Placement on function (f4)<br></div><div>BISECT: NOT running pass (162) X86 Execution Dependency Fix on function (f4)<br></div><div>BISECT: NOT running pass (163) BreakFalseDeps on function (f4)<br></div><div>BISECT: NOT running pass (164) X86 Byte/Word Instruction Fixup on function (f4)<br></div><div>BISECT: NOT running pass (165) X86 Atom pad short functions on function (f4)<br></div><div>BISECT: NOT running pass (166) X86 LEA Fixup on function (f4)<br></div><div>FileCheck error: '<stdin>' is empty.<br></div><div>FileCheck command line: /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll --check-prefix=CHECK-BISECT-INLINE-HELPER<br></div><div>FileCheck error: '<stdin>' is empty.<br></div><div>FileCheck command line: /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll --check-prefix=CHECK-BISECT-INLINE-HELPER<br></div><div>FileCheck error: '<stdin>' is empty.<br></div><div>FileCheck command line: /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll --check-prefix=CHECK-BISECT-INLINE-HELPER<br></div><div>FileCheck error: '<stdin>' is empty.<br></div><div>FileCheck command line: /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll --check-prefix=CHECK-BISECT-INLINE-HELPER<br></div><div>FileCheck error: '<stdin>' is empty.<br></div><div>FileCheck command line: /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll --check-prefix=CHECK-BISECT-INLINE-HELPER<br></div><div>FileCheck error: '<stdin>' is empty.<br></div><div>FileCheck command line: /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll --check-prefix=CHECK-BISECT-INLINE-HELPER<br></div><div>FileCheck error: '<stdin>' is empty.<br></div><div>FileCheck command line: /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll --check-prefix=CHECK-BISECT-INLINE-HELPER<br></div><div>FileCheck error: '<stdin>' is empty.<br></div><div>FileCheck command line: /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll --check-prefix=CHECK-BISECT-INLINE-HELPER<br></div><div>/home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll:48:31: error: CHECK-BISECT-INLINE-RESULT: expected string not found in input<br></div><div>; CHECK-BISECT-INLINE-RESULT: Last good count: {{[1-9][0-9]*}}<br></div><div> ^<br></div><div><stdin>:1:1: note: scanning from here<br></div><div>opt: ['/tmp/_update_lc/r/bin/opt', '-O2', '-opt-bisect-limit=128', '-S', '/home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll']<br></div><div>^<br></div><div><stdin>:9:1: note: possible intended match here<br></div><div>Last good count: 0<br></div><div>^<br></div><div><br></div><div>--<br></div><div><br></div><div>********************<br></div><div>Testing: 0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..<br></div><div><br></div><div>10 warning(s) in tests<br></div><div><br></div><div>Testing Time: 156.29s<br></div><div>********************<br></div><div>Failing Tests (1):<br></div><div> LLVM :: Other/opt-bisect-legacy-pass-manager.ll<br></div><div><br></div><div> Expected Passes : 45107<br></div><div> Expected Failures : 116<br></div><div> Unsupported Tests : 17400<br></div><div> Unexpected Failures: 1<br></div><div><br></div><div><br></div><div>On Fri, Apr 3, 2020, at 3:37 PM, Paul Robinson via llvm-commits wrote:<br></div><div>> <br></div><div>> Author: Paul Robinson<br></div><div>> Date: 2020-04-03T12:37:13-07:00<br></div><div>> New Revision: 210f40fe9a30212396311d265904b2d73859c53d<br></div><div>> <br></div><div>> URL: <br></div><div>> <a href="https://github.com/llvm/llvm-project/commit/210f40fe9a30212396311d265904b2d73859c53d" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/210f40fe9a30212396311d265904b2d73859c53d</a><br></div><div>> DIFF: <br></div><div>> <a href="https://github.com/llvm/llvm-project/commit/210f40fe9a30212396311d265904b2d73859c53d.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/210f40fe9a30212396311d265904b2d73859c53d.diff</a><br></div><div>> <br></div><div>> LOG: Test had incorrect check for nonzero count<br></div><div>> <br></div><div>> Added: <br></div><div>> <br></div><div>> <br></div><div>> Modified: <br></div><div>> llvm/test/Other/opt-bisect-legacy-pass-manager.ll<br></div><div>> <br></div><div>> Removed: <br></div><div>> <br></div><div>> <br></div><div>> <br></div><div>> ################################################################################<br></div><div>> diff --git a/llvm/test/Other/opt-bisect-legacy-pass-manager.ll <br></div><div>> b/llvm/test/Other/opt-bisect-legacy-pass-manager.ll<br></div><div>> index bf89e80d4960..d73ca80674da 100644<br></div><div>> --- a/llvm/test/Other/opt-bisect-legacy-pass-manager.ll<br></div><div>> +++ b/llvm/test/Other/opt-bisect-legacy-pass-manager.ll<br></div><div>> @@ -45,8 +45,7 @@<br></div><div>> ; The helper script uses this to find the optimization that inlines <br></div><div>> the call.<br></div><div>> ; CHECK-BISECT-INLINE-HELPER: call i32 @f2()<br></div><div>> ; These checks verifies that the optimization was found.<br></div><div>> -; CHECK-BISECT-INLINE-RESULT-NOT: Last good count: 0<br></div><div>> -; CHECK-BISECT-INLINE-RESULT: Last good count: {{[0-9]+}}<br></div><div>> +; CHECK-BISECT-INLINE-RESULT: Last good count: {{[1-9][0-9]*}}<br></div><div>> <br></div><div>> <br></div><div>> ; Test a module pass.<br></div><div>> <br></div><div>> <br></div><div>> <br></div><div>> _______________________________________________<br></div><div>> llvm-commits mailing list<br></div><div>> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br></div><div>> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br></div><div>><br></div><div>_______________________________________________<br></div><div>llvm-commits mailing list<br></div><div><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br></div><div><a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br></div></blockquote></div></div><div>_______________________________________________<br></div><div>llvm-commits mailing list<br></div><div>llvm-commits@lists.llvm.org<br></div><div>https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br></div><div><br></div></blockquote><div><br></div></body></html>