<div dir="ltr"><div>We're also seeing the breakage when new pass manager is enabled by default. Can we revert this please?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Apr 4, 2020 at 5:21 AM David Zarzycki via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Paul,<br>
<br>
This breaks the first phase of my test bot/script. Can we please revert this? This isn't all of the output, but hopefully what follows is helpful:<br>
<br>
BISECT: NOT running pass (152) Stack Slot Coloring on function (f4)<br>
BISECT: NOT running pass (153) Machine Copy Propagation Pass on function (f4)<br>
BISECT: NOT running pass (154) Machine Loop Invariant Code Motion on function (f4)<br>
BISECT: NOT running pass (155) PostRA Machine Sink on function (f4)<br>
BISECT: NOT running pass (156) Shrink Wrapping analysis on function (f4)<br>
BISECT: NOT running pass (157) Control Flow Optimizer on function (f4)<br>
BISECT: NOT running pass (158) Tail Duplication on function (f4)<br>
BISECT: NOT running pass (159) Machine Copy Propagation Pass on function (f4)<br>
BISECT: NOT running pass (160) Post RA top-down list latency scheduler on function (f4)<br>
BISECT: NOT running pass (161) Branch Probability Basic Block Placement on function (f4)<br>
BISECT: NOT running pass (162) X86 Execution Dependency Fix on function (f4)<br>
BISECT: NOT running pass (163) BreakFalseDeps on function (f4)<br>
BISECT: NOT running pass (164) X86 Byte/Word Instruction Fixup on function (f4)<br>
BISECT: NOT running pass (165) X86 Atom pad short functions on function (f4)<br>
BISECT: NOT running pass (166) X86 LEA Fixup on function (f4)<br>
FileCheck error: '<stdin>' is empty.<br>
FileCheck command line: /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll --check-prefix=CHECK-BISECT-INLINE-HELPER<br>
FileCheck error: '<stdin>' is empty.<br>
FileCheck command line: /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll --check-prefix=CHECK-BISECT-INLINE-HELPER<br>
FileCheck error: '<stdin>' is empty.<br>
FileCheck command line: /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll --check-prefix=CHECK-BISECT-INLINE-HELPER<br>
FileCheck error: '<stdin>' is empty.<br>
FileCheck command line: /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll --check-prefix=CHECK-BISECT-INLINE-HELPER<br>
FileCheck error: '<stdin>' is empty.<br>
FileCheck command line: /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll --check-prefix=CHECK-BISECT-INLINE-HELPER<br>
FileCheck error: '<stdin>' is empty.<br>
FileCheck command line: /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll --check-prefix=CHECK-BISECT-INLINE-HELPER<br>
FileCheck error: '<stdin>' is empty.<br>
FileCheck command line: /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll --check-prefix=CHECK-BISECT-INLINE-HELPER<br>
FileCheck error: '<stdin>' is empty.<br>
FileCheck command line: /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll --check-prefix=CHECK-BISECT-INLINE-HELPER<br>
/home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll:48:31: error: CHECK-BISECT-INLINE-RESULT: expected string not found in input<br>
; CHECK-BISECT-INLINE-RESULT: Last good count: {{[1-9][0-9]*}}<br>
^<br>
<stdin>:1:1: note: scanning from here<br>
opt: ['/tmp/_update_lc/r/bin/opt', '-O2', '-opt-bisect-limit=128', '-S', '/home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll']<br>
^<br>
<stdin>:9:1: note: possible intended match here<br>
Last good count: 0<br>
^<br>
<br>
--<br>
<br>
********************<br>
Testing: 0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..<br>
<br>
10 warning(s) in tests<br>
<br>
Testing Time: 156.29s<br>
********************<br>
Failing Tests (1):<br>
LLVM :: Other/opt-bisect-legacy-pass-manager.ll<br>
<br>
Expected Passes : 45107<br>
Expected Failures : 116<br>
Unsupported Tests : 17400<br>
Unexpected Failures: 1<br>
<br>
<br>
On Fri, Apr 3, 2020, at 3:37 PM, Paul Robinson via llvm-commits wrote:<br>
> <br>
> Author: Paul Robinson<br>
> Date: 2020-04-03T12:37:13-07:00<br>
> New Revision: 210f40fe9a30212396311d265904b2d73859c53d<br>
> <br>
> URL: <br>
> <a href="https://github.com/llvm/llvm-project/commit/210f40fe9a30212396311d265904b2d73859c53d" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/210f40fe9a30212396311d265904b2d73859c53d</a><br>
> DIFF: <br>
> <a href="https://github.com/llvm/llvm-project/commit/210f40fe9a30212396311d265904b2d73859c53d.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/210f40fe9a30212396311d265904b2d73859c53d.diff</a><br>
> <br>
> LOG: Test had incorrect check for nonzero count<br>
> <br>
> Added: <br>
> <br>
> <br>
> Modified: <br>
> llvm/test/Other/opt-bisect-legacy-pass-manager.ll<br>
> <br>
> Removed: <br>
> <br>
> <br>
> <br>
> ################################################################################<br>
> diff --git a/llvm/test/Other/opt-bisect-legacy-pass-manager.ll <br>
> b/llvm/test/Other/opt-bisect-legacy-pass-manager.ll<br>
> index bf89e80d4960..d73ca80674da 100644<br>
> --- a/llvm/test/Other/opt-bisect-legacy-pass-manager.ll<br>
> +++ b/llvm/test/Other/opt-bisect-legacy-pass-manager.ll<br>
> @@ -45,8 +45,7 @@<br>
> ; The helper script uses this to find the optimization that inlines <br>
> the call.<br>
> ; CHECK-BISECT-INLINE-HELPER: call i32 @f2()<br>
> ; These checks verifies that the optimization was found.<br>
> -; CHECK-BISECT-INLINE-RESULT-NOT: Last good count: 0<br>
> -; CHECK-BISECT-INLINE-RESULT: Last good count: {{[0-9]+}}<br>
> +; CHECK-BISECT-INLINE-RESULT: Last good count: {{[1-9][0-9]*}}<br>
> <br>
> <br>
> ; Test a module pass.<br>
> <br>
> <br>
> <br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>