<div dir="ltr">The patch description says it causes a crash - could you please add separate test coverage for this fix that demonstrates the crash no longer occurs & tests the behavior that should've been happening instead of the crash? <br><br>Submitting changes without test coverage is a bit problematic & embedding the tests in another functional change makes it harder to assess whether the tests cover the right/new/previous functionality, etc.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 2, 2020 at 6:50 PM Greg Clayton <<a href="mailto:gclayton@fb.com">gclayton@fb.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="EN-US">
<div class="gmail-m_5620310646504732022WordSection1">
<p class="MsoNormal">Not yet, test coverage will come with my upcoming patch that enables –update to work on ELF files.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(181,196,223);padding:3pt 0in 0in">
<p class="MsoNormal"><b><span style="font-size:12pt;color:black">From: </span></b><span style="font-size:12pt;color:black">David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>><br>
<b>Date: </b>Wednesday, March 25, 2020 at 12:50 PM<br>
<b>To: </b>Greg Clayton <<a href="mailto:gclayton@fb.com" target="_blank">gclayton@fb.com</a>>, Greg Clayton <<a href="mailto:llvmlistbot@llvm.org" target="_blank">llvmlistbot@llvm.org</a>><br>
<b>Cc: </b>llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>><br>
<b>Subject: </b>Re: [llvm] eb61ab1 - Fix a copy and paste error that would cause a crash.<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Does this have test coverage?<u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Fri, Mar 6, 2020 at 6:07 PM Greg Clayton via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal"><br>
Author: Greg Clayton<br>
Date: 2020-03-06T18:07:36-08:00<br>
New Revision: eb61ab1bd9af607fc7439edd3b92467b78772b92<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/eb61ab1bd9af607fc7439edd3b92467b78772b92" target="_blank">
https://github.com/llvm/llvm-project/commit/eb61ab1bd9af607fc7439edd3b92467b78772b92</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/eb61ab1bd9af607fc7439edd3b92467b78772b92.diff" target="_blank">
https://github.com/llvm/llvm-project/commit/eb61ab1bd9af607fc7439edd3b92467b78772b92.diff</a><br>
<br>
LOG: Fix a copy and paste error that would cause a crash.<br>
<br>
Summary: The wrong variable was being checked for an error, which mean a llvm::Error went unchecked and crashes dsymutil. Discovered this when trying to feed an ELF file to "dsymutil --update" and running into the crash.<br>
<br>
Reviewers: aprantl, JDevlieghere<br>
<br>
Subscribers: llvm-commits<br>
<br>
Tags: #llvm<br>
<br>
Differential Revision: <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D75777&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=ThRQ77VnKhqKMdoo_7_huw&m=-QqN8drvd_904Cqb5JC6ILIf3nN3DV5pr414AXRAVTo&s=AbBu6TofQozS6_11gbiuShMHwFyB0zNztYWf8Yfz2mo&e=" target="_blank">
https://reviews.llvm.org/D75777</a><br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
llvm/tools/dsymutil/MachODebugMapParser.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff --git a/llvm/tools/dsymutil/MachODebugMapParser.cpp b/llvm/tools/dsymutil/MachODebugMapParser.cpp<br>
index 83703fb13f0a..a9d6c876860c 100644<br>
--- a/llvm/tools/dsymutil/MachODebugMapParser.cpp<br>
+++ b/llvm/tools/dsymutil/MachODebugMapParser.cpp<br>
@@ -383,7 +383,7 @@ ErrorOr<std::vector<std::unique_ptr<DebugMap>>> MachODebugMapParser::parse() {<br>
<br>
auto Objects = ObjectEntry->getObjectsAs<MachOObjectFile>();<br>
if (!Objects) {<br>
- return errorToErrorCode(ObjectEntry.takeError());<br>
+ return errorToErrorCode(Objects.takeError());<br>
}<br>
<br>
std::vector<std::unique_ptr<DebugMap>> Results;<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=ThRQ77VnKhqKMdoo_7_huw&m=-QqN8drvd_904Cqb5JC6ILIf3nN3DV5pr414AXRAVTo&s=JTMfjjLwT8sswuAffXt_Qrsbhmf_5D-mV31KPiAtzUo&e=" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><u></u><u></u></p>
</blockquote>
</div>
</div>
</div>
</blockquote></div>