<div dir="ltr">Johannes - is this code missing some test coverage that would have demonstrated the bug in the code before Reid's fix here?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Feb 14, 2020 at 3:24 PM Reid Kleckner via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Reid Kleckner<br>
Date: 2020-02-14T15:23:49-08:00<br>
New Revision: 1a93285c686a4ad6e4311f55898cb116ca51b5b0<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/1a93285c686a4ad6e4311f55898cb116ca51b5b0" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/1a93285c686a4ad6e4311f55898cb116ca51b5b0</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/1a93285c686a4ad6e4311f55898cb116ca51b5b0.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/1a93285c686a4ad6e4311f55898cb116ca51b5b0.diff</a><br>
<br>
LOG: Fix -Wstring-compare warnings in new OpenMP code<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/lib/Frontend/OpenMP/OMPContext.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/llvm/lib/Frontend/OpenMP/OMPContext.cpp b/llvm/lib/Frontend/OpenMP/OMPContext.cpp<br>
index f4c4bdfad0b6..244448c41012 100644<br>
--- a/llvm/lib/Frontend/OpenMP/OMPContext.cpp<br>
+++ b/llvm/lib/Frontend/OpenMP/OMPContext.cpp<br>
@@ -411,7 +411,7 @@ bool llvm::omp::isValidTraitPropertyForTraitSetAndSelector(<br>
 std::string llvm::omp::listOpenMPContextTraitSets() {<br>
   std::string S;<br>
 #define OMP_TRAIT_SET(Enum, Str)                                               \<br>
-  if (Str != "invalid")                                                        \<br>
+  if (StringRef(Str) != "invalid")                                             \<br>
     S.append("'").append(Str).append("'").append(" ");<br>
 #include "llvm/Frontend/OpenMP/OMPKinds.def"<br>
   S.pop_back();<br>
@@ -421,7 +421,7 @@ std::string llvm::omp::listOpenMPContextTraitSets() {<br>
 std::string llvm::omp::listOpenMPContextTraitSelectors(TraitSet Set) {<br>
   std::string S;<br>
 #define OMP_TRAIT_SELECTOR(Enum, TraitSetEnum, Str, ReqProp)                   \<br>
-  if (TraitSet::TraitSetEnum == Set && Str != "Invalid")                       \<br>
+  if (TraitSet::TraitSetEnum == Set && StringRef(Str) != "Invalid")            \<br>
     S.append("'").append(Str).append("'").append(" ");<br>
 #include "llvm/Frontend/OpenMP/OMPKinds.def"<br>
   S.pop_back();<br>
@@ -434,7 +434,8 @@ llvm::omp::listOpenMPContextTraitProperties(TraitSet Set,<br>
   std::string S;<br>
 #define OMP_TRAIT_PROPERTY(Enum, TraitSetEnum, TraitSelectorEnum, Str)         \<br>
   if (TraitSet::TraitSetEnum == Set &&                                         \<br>
-      TraitSelector::TraitSelectorEnum == Selector && Str != "invalid")        \<br>
+      TraitSelector::TraitSelectorEnum == Selector &&                          \<br>
+      StringRef(Str) != "invalid")                                             \<br>
     S.append("'").append(Str).append("'").append(" ");<br>
 #include "llvm/Frontend/OpenMP/OMPKinds.def"<br>
   S.pop_back();<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>