<div dir="ltr">It's probably handy (to me at least) to describe in the commit message what the substance of the change is, rather than that it addresses some non-specific compiler warnings/errors. (maybe including where this was diagnosed in the body of the commit message, if it's useful/doesn't fit as an addendum at the end of the main message line)</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jan 7, 2020 at 4:03 PM Daniel Sanders via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Daniel Sanders<br>
Date: 2020-01-07T16:02:31-08:00<br>
New Revision: 13922f3e9d0c8a0f2612c5e43c922099bbf74a79<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/13922f3e9d0c8a0f2612c5e43c922099bbf74a79" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/13922f3e9d0c8a0f2612c5e43c922099bbf74a79</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/13922f3e9d0c8a0f2612c5e43c922099bbf74a79.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/13922f3e9d0c8a0f2612c5e43c922099bbf74a79.diff</a><br>
<br>
LOG: Fix warnings as errors that occur on sanitizer-x86_64-linux<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/utils/TableGen/GlobalISel/GIMatchTree.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/llvm/utils/TableGen/GlobalISel/GIMatchTree.cpp b/llvm/utils/TableGen/GlobalISel/GIMatchTree.cpp<br>
index b54a3e071ac0..4884bdadea91 100644<br>
--- a/llvm/utils/TableGen/GlobalISel/GIMatchTree.cpp<br>
+++ b/llvm/utils/TableGen/GlobalISel/GIMatchTree.cpp<br>
@@ -411,7 +411,7 @@ void GIMatchTreeOpcodePartitioner::repartition(<br>
<br>
     // If the opcode is available to test then any opcode predicates will have<br>
     // been enabled too.<br>
-    for (const auto &PIdx : Leaf.value().TestablePredicates.set_bits()) {<br>
+    for (unsigned PIdx : Leaf.value().TestablePredicates.set_bits()) {<br>
       const auto &P = Leaf.value().getPredicate(PIdx);<br>
       SmallVector<const CodeGenInstruction *, 1> OpcodesForThisPredicate;<br>
       if (const auto *OpcodeP = dyn_cast<const GIMatchDagOpcodePredicate>(P)) {<br>
@@ -662,7 +662,7 @@ void GIMatchTreeVRegDefPartitioner::repartition(<br>
     // If this node has an use -> def edge from this operand then this<br>
     // instruction must be in partition 1 (isVRegDef()).<br>
     bool WantsEdge = false;<br>
-    for (const auto &EIdx : Leaf.value().TraversableEdges.set_bits()) {<br>
+    for (unsigned EIdx : Leaf.value().TraversableEdges.set_bits()) {<br>
       const auto &E = Leaf.value().getEdge(EIdx);<br>
       if (E->getFromMI() != InstrInfo->getInstrNode() ||<br>
           E->getFromMO()->getIdx() != OpIdx || E->isDefToUse())<br>
@@ -725,14 +725,14 @@ void GIMatchTreeVRegDefPartitioner::applyForPartition(<br>
   NewInstrID = SubBuilder.allocInstrID();<br>
<br>
   GIMatchTreeBuilder::LeafVec &NewLeaves = SubBuilder.getPossibleLeaves();<br>
-  for (const auto &I : zip(NewLeaves, TraversedEdgesByNewLeaves)) {<br>
+  for (const auto I : zip(NewLeaves, TraversedEdgesByNewLeaves)) {<br>
     auto &Leaf = std::get<0>(I);<br>
     auto &TraversedEdgesForLeaf = std::get<1>(I);<br>
     GIMatchTreeInstrInfo *InstrInfo = Leaf.getInstrInfo(InstrID);<br>
     // Skip any leaves that don't care about this instruction.<br>
     if (!InstrInfo)<br>
       continue;<br>
-    for (const auto &EIdx : TraversedEdgesForLeaf.set_bits()) {<br>
+    for (unsigned EIdx : TraversedEdgesForLeaf.set_bits()) {<br>
       const GIMatchDagEdge *E = Leaf.getEdge(EIdx);<br>
       Leaf.declareInstr(E->getToMI(), NewInstrID);<br>
     }<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>