<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 26 Mar 2020, at 18:48, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">It's probably handy (to me at least) to describe in the commit message what the substance of the change is, rather than that it addresses some non-specific compiler warnings/errors.</div></div></blockquote><div><br class=""></div><div>Sure, I can do that in future.</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class="">(maybe including where this was diagnosed in the body of the commit message, if it's useful/doesn't fit as an addendum at the end of the main message line)</div></div></blockquote><div><br class=""></div>I assume the 'where' there is in terms of source lines rather than the environment it was found in.<br class=""><br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jan 7, 2020 at 4:03 PM Daniel Sanders via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br class="">
Author: Daniel Sanders<br class="">
Date: 2020-01-07T16:02:31-08:00<br class="">
New Revision: 13922f3e9d0c8a0f2612c5e43c922099bbf74a79<br class="">
<br class="">
URL: <a href="https://github.com/llvm/llvm-project/commit/13922f3e9d0c8a0f2612c5e43c922099bbf74a79" rel="noreferrer" target="_blank" class="">https://github.com/llvm/llvm-project/commit/13922f3e9d0c8a0f2612c5e43c922099bbf74a79</a><br class="">
DIFF: <a href="https://github.com/llvm/llvm-project/commit/13922f3e9d0c8a0f2612c5e43c922099bbf74a79.diff" rel="noreferrer" target="_blank" class="">https://github.com/llvm/llvm-project/commit/13922f3e9d0c8a0f2612c5e43c922099bbf74a79.diff</a><br class="">
<br class="">
LOG: Fix warnings as errors that occur on sanitizer-x86_64-linux<br class="">
<br class="">
Added: <br class="">
<br class="">
<br class="">
Modified: <br class="">
llvm/utils/TableGen/GlobalISel/GIMatchTree.cpp<br class="">
<br class="">
Removed: <br class="">
<br class="">
<br class="">
<br class="">
################################################################################<br class="">
diff --git a/llvm/utils/TableGen/GlobalISel/GIMatchTree.cpp b/llvm/utils/TableGen/GlobalISel/GIMatchTree.cpp<br class="">
index b54a3e071ac0..4884bdadea91 100644<br class="">
--- a/llvm/utils/TableGen/GlobalISel/GIMatchTree.cpp<br class="">
+++ b/llvm/utils/TableGen/GlobalISel/GIMatchTree.cpp<br class="">
@@ -411,7 +411,7 @@ void GIMatchTreeOpcodePartitioner::repartition(<br class="">
<br class="">
// If the opcode is available to test then any opcode predicates will have<br class="">
// been enabled too.<br class="">
- for (const auto &PIdx : Leaf.value().TestablePredicates.set_bits()) {<br class="">
+ for (unsigned PIdx : Leaf.value().TestablePredicates.set_bits()) {<br class="">
const auto &P = Leaf.value().getPredicate(PIdx);<br class="">
SmallVector<const CodeGenInstruction *, 1> OpcodesForThisPredicate;<br class="">
if (const auto *OpcodeP = dyn_cast<const GIMatchDagOpcodePredicate>(P)) {<br class="">
@@ -662,7 +662,7 @@ void GIMatchTreeVRegDefPartitioner::repartition(<br class="">
// If this node has an use -> def edge from this operand then this<br class="">
// instruction must be in partition 1 (isVRegDef()).<br class="">
bool WantsEdge = false;<br class="">
- for (const auto &EIdx : Leaf.value().TraversableEdges.set_bits()) {<br class="">
+ for (unsigned EIdx : Leaf.value().TraversableEdges.set_bits()) {<br class="">
const auto &E = Leaf.value().getEdge(EIdx);<br class="">
if (E->getFromMI() != InstrInfo->getInstrNode() ||<br class="">
E->getFromMO()->getIdx() != OpIdx || E->isDefToUse())<br class="">
@@ -725,14 +725,14 @@ void GIMatchTreeVRegDefPartitioner::applyForPartition(<br class="">
NewInstrID = SubBuilder.allocInstrID();<br class="">
<br class="">
GIMatchTreeBuilder::LeafVec &NewLeaves = SubBuilder.getPossibleLeaves();<br class="">
- for (const auto &I : zip(NewLeaves, TraversedEdgesByNewLeaves)) {<br class="">
+ for (const auto I : zip(NewLeaves, TraversedEdgesByNewLeaves)) {<br class="">
auto &Leaf = std::get<0>(I);<br class="">
auto &TraversedEdgesForLeaf = std::get<1>(I);<br class="">
GIMatchTreeInstrInfo *InstrInfo = Leaf.getInstrInfo(InstrID);<br class="">
// Skip any leaves that don't care about this instruction.<br class="">
if (!InstrInfo)<br class="">
continue;<br class="">
- for (const auto &EIdx : TraversedEdgesForLeaf.set_bits()) {<br class="">
+ for (unsigned EIdx : TraversedEdgesForLeaf.set_bits()) {<br class="">
const GIMatchDagEdge *E = Leaf.getEdge(EIdx);<br class="">
Leaf.declareInstr(E->getToMI(), NewInstrID);<br class="">
}<br class="">
<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""></body></html>