<div dir="ltr">Similarly, please don't add initializations for variables that don't need them for runtime correctness as it impedes dynamic analysis tools - prefer annotations, etc, if necessary for static analysis compatibility. </div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jan 7, 2020 at 4:07 AM Simon Pilgrim via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Simon Pilgrim<br>
Date: 2020-01-07T12:06:54Z<br>
New Revision: 6ff1ea3244c543ad24fc99c7f4979db2f2078593<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/6ff1ea3244c543ad24fc99c7f4979db2f2078593" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/6ff1ea3244c543ad24fc99c7f4979db2f2078593</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/6ff1ea3244c543ad24fc99c7f4979db2f2078593.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/6ff1ea3244c543ad24fc99c7f4979db2f2078593.diff</a><br>
<br>
LOG: Fix "use of uninitialized variable" static analyzer warning. NFCI.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/lib/Target/AMDGPU/R600InstrInfo.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/llvm/lib/Target/AMDGPU/R600InstrInfo.cpp b/llvm/lib/Target/AMDGPU/R600InstrInfo.cpp<br>
index 11dd249f8ada..346296c77377 100644<br>
--- a/llvm/lib/Target/AMDGPU/R600InstrInfo.cpp<br>
+++ b/llvm/lib/Target/AMDGPU/R600InstrInfo.cpp<br>
@@ -541,7 +541,7 @@ R600InstrInfo::fitsReadPortLimitations(const std::vector<MachineInstr *> &IG,<br>
<br>
   std::vector<std::vector<std::pair<int, unsigned>>> IGSrcs;<br>
   ValidSwizzle.clear();<br>
-  unsigned ConstCount;<br>
+  unsigned ConstCount = 0;<br>
   BankSwizzle TransBS = ALU_VEC_012_SCL_210;<br>
   for (unsigned i = 0, e = IG.size(); i < e; ++i) {<br>
     IGSrcs.push_back(ExtractSrcs(*IG[i], PV, ConstCount));<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>