<div dir="ltr">Which compiler warned about this? It looks like this would be a bad compiler warning we maybe shuold disable, because the variable is initialized before being used in the code that follows & it's best not to add an unneeded initialization like that - since it thwarts the warning (or msan, etc) from catching real bugs that might be introduced later (if another arg mode was added & wasn't fully handled in the code that came after)<br><br>The other thing might be worth doing is changing those unreachables to assertions... <br><br>assert(ArgVT != MVT::f80 && "Not yet implemented");<br>if (is floating point && size <= 16)<br>  Mode = 2;<br>else<br>  assert(is integer && size <= 32)<br>  Mode = 1<br><br>That might be easier for a compiler to see that it's always initialized before use.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 27, 2020 at 6:29 AM Simon Pilgrim via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Simon Pilgrim<br>
Date: 2020-02-27T14:20:43Z<br>
New Revision: fabe52a7412d850bf06e006db1d53de0500a1853<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/fabe52a7412d850bf06e006db1d53de0500a1853" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/fabe52a7412d850bf06e006db1d53de0500a1853</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/fabe52a7412d850bf06e006db1d53de0500a1853.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/fabe52a7412d850bf06e006db1d53de0500a1853.diff</a><br>
<br>
LOG: Fix uninitialized variable warning. NFC.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/lib/Target/X86/X86ISelLowering.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp<br>
index 1cc9c7b16d78..c2d18e21d07d 100644<br>
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp<br>
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp<br>
@@ -23423,7 +23423,7 @@ SDValue X86TargetLowering::LowerVAARG(SDValue Op, SelectionDAG &DAG) const {<br>
   EVT ArgVT = Op.getNode()->getValueType(0);<br>
   Type *ArgTy = ArgVT.getTypeForEVT(*DAG.getContext());<br>
   uint32_t ArgSize = DAG.getDataLayout().getTypeAllocSize(ArgTy);<br>
-  uint8_t ArgMode;<br>
+  uint8_t ArgMode = 0;<br>
<br>
   // Decide which area this value should be read from.<br>
   // TODO: Implement the AMD64 ABI in its entirety. This simple<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>