<div dir="ltr">Does this have test coverage?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Mar 6, 2020 at 6:07 PM Greg Clayton via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Greg Clayton<br>
Date: 2020-03-06T18:07:36-08:00<br>
New Revision: eb61ab1bd9af607fc7439edd3b92467b78772b92<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/eb61ab1bd9af607fc7439edd3b92467b78772b92" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/eb61ab1bd9af607fc7439edd3b92467b78772b92</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/eb61ab1bd9af607fc7439edd3b92467b78772b92.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/eb61ab1bd9af607fc7439edd3b92467b78772b92.diff</a><br>
<br>
LOG: Fix a copy and paste error that would cause a crash.<br>
<br>
Summary: The wrong variable was being checked for an error, which mean a llvm::Error went unchecked and crashes dsymutil. Discovered this when trying to feed an ELF file to "dsymutil --update" and running into the crash.<br>
<br>
Reviewers: aprantl, JDevlieghere<br>
<br>
Subscribers: llvm-commits<br>
<br>
Tags: #llvm<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D75777" rel="noreferrer" target="_blank">https://reviews.llvm.org/D75777</a><br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/tools/dsymutil/MachODebugMapParser.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/llvm/tools/dsymutil/MachODebugMapParser.cpp b/llvm/tools/dsymutil/MachODebugMapParser.cpp<br>
index 83703fb13f0a..a9d6c876860c 100644<br>
--- a/llvm/tools/dsymutil/MachODebugMapParser.cpp<br>
+++ b/llvm/tools/dsymutil/MachODebugMapParser.cpp<br>
@@ -383,7 +383,7 @@ ErrorOr<std::vector<std::unique_ptr<DebugMap>>> MachODebugMapParser::parse() {<br>
<br>
   auto Objects = ObjectEntry->getObjectsAs<MachOObjectFile>();<br>
   if (!Objects) {<br>
-    return errorToErrorCode(ObjectEntry.takeError());<br>
+    return errorToErrorCode(Objects.takeError());<br>
   }<br>
<br>
   std::vector<std::unique_ptr<DebugMap>> Results;<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>