<div dir="ltr">Looks like it did, and was fixed back to the usual line endings in aca3e70d2bc0dd89b7d486c2a8eac70d8a89e790</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jan 14, 2020 at 1:15 PM Robinson, Paul via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi James,<br>
Did this commit mess up the line endings on DWARFDebugLineTest.cpp?<br>
The diff makes it look like the entire file was modified.<br>
--paulr<br>
<br>
> -----Original Message-----<br>
> From: llvm-commits <<a href="mailto:llvm-commits-bounces@lists.llvm.org" target="_blank">llvm-commits-bounces@lists.llvm.org</a>> On Behalf Of<br>
> James Henderson via llvm-commits<br>
> Sent: Friday, January 10, 2020 10:00 AM<br>
> To: <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> Subject: [lld] 6e3ca96 - [DebugInfo] Improve error message text<br>
> <br>
> <br>
> Author: James Henderson<br>
> Date: 2020-01-10T14:59:58Z<br>
> New Revision: 6e3ca962fafb3d2a31279c49f0cde60eb626a002<br>
> <br>
> URL: <a href="https://github.com/llvm/llvm-" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-</a><br>
> project/commit/6e3ca962fafb3d2a31279c49f0cde60eb626a002<br>
> DIFF: <a href="https://github.com/llvm/llvm-" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-</a><br>
> project/commit/6e3ca962fafb3d2a31279c49f0cde60eb626a002.diff<br>
> <br>
> LOG: [DebugInfo] Improve error message text<br>
> <br>
> Unlike most of our errors in the debug line parser, the "no end of<br>
> sequence" message was missing any reference to which line table it<br>
> refererred to. This change adds the offset to this message.<br>
> <br>
> Reviewed by: dblaikie<br>
> <br>
> Differential Revision: <a href="https://reviews.llvm.org/D72443" rel="noreferrer" target="_blank">https://reviews.llvm.org/D72443</a><br>
> <br>
> Added:<br>
> <br>
> <br>
> Modified:<br>
> lld/test/ELF/undef.s<br>
> llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp<br>
> llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test<br>
> llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp<br>
> <br>
> Removed:<br>
> <br>
> <br>
> <br>
> ##########################################################################<br>
> ######<br>
> diff --git a/lld/test/ELF/undef.s b/lld/test/ELF/undef.s<br>
> index e5ddcb5f52c6..2ca733a26fd7 100644<br>
> --- a/lld/test/ELF/undef.s<br>
> +++ b/lld/test/ELF/undef.s<br>
> @@ -52,7 +52,7 @@<br>
> # is requested, even if that particular part of the line information is<br>
> not currently required.<br>
> # Also show that the warnings are only printed once.<br>
> # CHECK: warning: parsing line table prologue at 0x00000000 should<br>
> have ended at 0x00000038 but it ended at 0x00000037<br>
> -# CHECK-NEXT: warning: last sequence in debug line table is not<br>
> terminated!<br>
> +# CHECK-NEXT: warning: last sequence in debug line table at offset<br>
> 0x0000005b is not terminated<br>
> # CHECK: error: undefined symbol: zed6a<br>
> # CHECK-NEXT: >>> referenced by {{.*}}tmp4.o:(.text+0x0)<br>
> # CHECK: error: undefined symbol: zed6b<br>
> <br>
> diff --git a/llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp<br>
> b/llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp<br>
> index 8e7ce58957d5..73480cecb982 100644<br>
> --- a/llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp<br>
> +++ b/llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp<br>
> @@ -883,9 +883,11 @@ Error DWARFDebugLine::LineTable::parse(<br>
> }<br>
> <br>
> if (!State.Sequence.Empty)<br>
> - RecoverableErrorCallback(<br>
> - createStringError(errc::illegal_byte_sequence,<br>
> - "last sequence in debug line table is not<br>
> terminated!"));<br>
> + RecoverableErrorCallback(createStringError(<br>
> + errc::illegal_byte_sequence,<br>
> + "last sequence in debug line table at offset 0x%8.8" PRIx64<br>
> + " is not terminated",<br>
> + DebugLineOffset));<br>
> <br>
> // Sort all sequences so that address lookup will work faster.<br>
> if (!Sequences.empty()) {<br>
> <br>
> diff --git a/llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test<br>
> b/llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test<br>
> index cb8b2b8f3e4d..6bdc526570fa 100644<br>
> --- a/llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test<br>
> +++ b/llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test<br>
> @@ -158,7 +158,7 @@<br>
> # ALL-NEXT: warning: parsing line table prologue at 0x00000081 should<br>
> have ended at 0x000000b9 but it ended at 0x000000ba<br>
> # ALL-NEXT: warning: parsing line table prologue at 0x000000c9 should<br>
> have ended at 0x00000104 but it ended at 0x00000103<br>
> # OTHER-NEXT: warning: unexpected line op length at offset 0x00000158<br>
> expected 0x02 found 0x01<br>
> -# OTHER-NEXT: warning: last sequence in debug line table is not<br>
> terminated!<br>
> +# OTHER-NEXT: warning: last sequence in debug line table at offset<br>
> 0x00000167 is not terminated<br>
> # ALL-NEXT: warning: parsing line table prologue at 0x000001ad should<br>
> have ended at 0x000001c8 but it ended at 0x000001df<br>
> # ALL-NEXT: warning: parsing line table prologue at 0x000001ed should<br>
> have ended at 0x00000218 but it ended at 0x0000021f<br>
> # ALL-NEXT: warning: parsing line table prologue at 0x0000022d should<br>
> have ended at 0x0000024f but it ended at 0x0000025f<br>
> <br>
> diff --git a/llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp<br>
> b/llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp<br>
> index f29709442d4d..8b405b2b092d 100644<br>
> --- a/llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp<br>
> +++ b/llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp<br>
> @@ -1,761 +1,763 @@<br>
> -//===- DWARFDebugLineTest.cpp -------------------------------------------<br>
> --===//<br>
> -//<br>
> -// Part of the LLVM Project, under the Apache License v2.0 with LLVM<br>
> Exceptions.<br>
> -// See <a href="https://llvm.org/LICENSE.txt" rel="noreferrer" target="_blank">https://llvm.org/LICENSE.txt</a> for license information.<br>
> -// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception<br>
> -//<br>
> -//===--------------------------------------------------------------------<br>
> --===//<br>
> -<br>
> -#include "DwarfGenerator.h"<br>
> -#include "DwarfUtils.h"<br>
> -#include "llvm/DebugInfo/DWARF/DWARFContext.h"<br>
> -#include "llvm/DebugInfo/DWARF/DWARFDebugLine.h"<br>
> -#include "llvm/Object/ObjectFile.h"<br>
> -#include "llvm/Testing/Support/Error.h"<br>
> -#include "gtest/gtest.h"<br>
> -<br>
> -using namespace llvm;<br>
> -using namespace dwarf;<br>
> -using namespace dwarfgen;<br>
> -using namespace object;<br>
> -using namespace utils;<br>
> -using namespace testing;<br>
> -<br>
> -namespace {<br>
> -struct CommonFixture {<br>
> - CommonFixture()<br>
> - : LineData("", true, 0), Recoverable(Error::success()),<br>
> - RecordRecoverable(std::bind(&CommonFixture::recordRecoverable,<br>
> this,<br>
> - std::placeholders::_1)),<br>
> - Unrecoverable(Error::success()),<br>
> -<br>
> RecordUnrecoverable(std::bind(&CommonFixture::recordUnrecoverable, this,<br>
> - std::placeholders::_1)){};<br>
> -<br>
> - ~CommonFixture() {<br>
> - EXPECT_FALSE(Recoverable);<br>
> - EXPECT_FALSE(Unrecoverable);<br>
> - }<br>
> -<br>
> - bool setupGenerator(uint16_t Version = 4) {<br>
> - Triple T = getDefaultTargetTripleForAddrSize(8);<br>
> - if (!isConfigurationSupported(T))<br>
> - return false;<br>
> - auto ExpectedGenerator = Generator::create(T, Version);<br>
> - if (ExpectedGenerator)<br>
> - Gen.reset(ExpectedGenerator->release());<br>
> - return true;<br>
> - }<br>
> -<br>
> - void generate() {<br>
> - Context = createContext();<br>
> - assert(Context != nullptr && "test state is not valid");<br>
> - const DWARFObject &Obj = Context->getDWARFObj();<br>
> - LineData = DWARFDataExtractor(<br>
> - Obj, Obj.getLineSection(),<br>
> - getDefaultTargetTripleForAddrSize(8).isLittleEndian(), 8);<br>
> - }<br>
> -<br>
> - std::unique_ptr<DWARFContext> createContext() {<br>
> - if (!Gen)<br>
> - return nullptr;<br>
> - StringRef FileBytes = Gen->generate();<br>
> - MemoryBufferRef FileBuffer(FileBytes, "dwarf");<br>
> - auto Obj = object::ObjectFile::createObjectFile(FileBuffer);<br>
> - if (Obj)<br>
> - return DWARFContext::create(**Obj);<br>
> - return nullptr;<br>
> - }<br>
> -<br>
> - DWARFDebugLine::SectionParser setupParser() {<br>
> - LineTable < = Gen->addLineTable(DWARF32);<br>
> - LT.addExtendedOpcode(9, DW_LNE_set_address, {{0xadd4e55,<br>
> LineTable::Quad}});<br>
> - LT.addStandardOpcode(DW_LNS_copy, {});<br>
> - LT.addByte(0xaa);<br>
> - LT.addExtendedOpcode(1, DW_LNE_end_sequence, {});<br>
> -<br>
> - LineTable <2 = Gen->addLineTable(DWARF64);<br>
> - LT2.addExtendedOpcode(9, DW_LNE_set_address,<br>
> - {{0x11223344, LineTable::Quad}});<br>
> - LT2.addStandardOpcode(DW_LNS_copy, {});<br>
> - LT2.addByte(0xbb);<br>
> - LT2.addExtendedOpcode(1, DW_LNE_end_sequence, {});<br>
> -<br>
> - generate();<br>
> -<br>
> - return DWARFDebugLine::SectionParser(LineData, *Context, CUs, TUs);<br>
> - }<br>
> -<br>
> - void recordRecoverable(Error Err) {<br>
> - Recoverable = joinErrors(std::move(Recoverable), std::move(Err));<br>
> - }<br>
> - void recordUnrecoverable(Error Err) {<br>
> - Unrecoverable = joinErrors(std::move(Unrecoverable), std::move(Err));<br>
> - }<br>
> -<br>
> - void checkError(ArrayRef<StringRef> ExpectedMsgs, Error Err) {<br>
> - ASSERT_TRUE(Err.operator bool());<br>
> - size_t WhichMsg = 0;<br>
> - Error Remaining =<br>
> - handleErrors(std::move(Err), [&](const ErrorInfoBase &Actual) {<br>
> - ASSERT_LT(WhichMsg, ExpectedMsgs.size());<br>
> - // Use .str(), because googletest doesn't visualise a StringRef<br>
> - // properly.<br>
> - EXPECT_EQ(Actual.message(), ExpectedMsgs[WhichMsg++].str());<br>
> - });<br>
> - EXPECT_EQ(WhichMsg, ExpectedMsgs.size());<br>
> - EXPECT_FALSE(Remaining);<br>
> - }<br>
> -<br>
> - void checkError(StringRef ExpectedMsg, Error Err) {<br>
> - checkError(ArrayRef<StringRef>{ExpectedMsg}, std::move(Err));<br>
> - }<br>
> -<br>
> - void checkGetOrParseLineTableEmitsFatalError(StringRef ExpectedMsg,<br>
> - uint64_t Offset = 0) {<br>
> - auto ExpectedLineTable = Line.getOrParseLineTable(<br>
> - LineData, Offset, *Context, nullptr, RecordRecoverable);<br>
> - EXPECT_FALSE(ExpectedLineTable);<br>
> - EXPECT_FALSE(Recoverable);<br>
> -<br>
> - checkError(ExpectedMsg, ExpectedLineTable.takeError());<br>
> - }<br>
> -<br>
> - void checkGetOrParseLineTableEmitsFatalError(ArrayRef<StringRef><br>
> ExpectedMsgs,<br>
> - uint64_t Offset = 0) {<br>
> - auto ExpectedLineTable = Line.getOrParseLineTable(<br>
> - LineData, Offset, *Context, nullptr, RecordRecoverable);<br>
> - EXPECT_FALSE(ExpectedLineTable);<br>
> - EXPECT_FALSE(Recoverable);<br>
> -<br>
> - checkError(ExpectedMsgs, ExpectedLineTable.takeError());<br>
> - }<br>
> -<br>
> - std::unique_ptr<Generator> Gen;<br>
> - std::unique_ptr<DWARFContext> Context;<br>
> - DWARFDataExtractor LineData;<br>
> - DWARFDebugLine Line;<br>
> - Error Recoverable;<br>
> - std::function<void(Error)> RecordRecoverable;<br>
> - Error Unrecoverable;<br>
> - std::function<void(Error)> RecordUnrecoverable;<br>
> -<br>
> - SmallVector<std::unique_ptr<DWARFUnit>, 2> CUs;<br>
> - SmallVector<std::unique_ptr<DWARFUnit>, 2> TUs;<br>
> -};<br>
> -<br>
> -// Fixtures must derive from "Test", but parameterised fixtures from<br>
> -// "TestWithParam". It does not seem possible to inherit from both, so we<br>
> share<br>
> -// the common state in a separate class, inherited by the two fixture<br>
> classes.<br>
> -struct DebugLineBasicFixture : public Test, public CommonFixture {};<br>
> -<br>
> -struct DebugLineParameterisedFixture<br>
> - : public TestWithParam<std::pair<uint16_t, DwarfFormat>>,<br>
> - public CommonFixture {<br>
> - void SetUp() { std::tie(Version, Format) = GetParam(); }<br>
> -<br>
> - uint16_t Version;<br>
> - DwarfFormat Format;<br>
> -};<br>
> -<br>
> -void checkDefaultPrologue(uint16_t Version, DwarfFormat Format,<br>
> - DWARFDebugLine::Prologue Prologue,<br>
> - uint64_t BodyLength) {<br>
> - // Check version specific fields and values.<br>
> - uint64_t UnitLength;<br>
> - uint64_t PrologueLength;<br>
> - switch (Version) {<br>
> - case 4:<br>
> - PrologueLength = 36;<br>
> - UnitLength = PrologueLength + 2;<br>
> - EXPECT_EQ(Prologue.MaxOpsPerInst, 1u);<br>
> - break;<br>
> - case 2:<br>
> - case 3:<br>
> - PrologueLength = 35;<br>
> - UnitLength = PrologueLength + 2;<br>
> - break;<br>
> - case 5:<br>
> - PrologueLength = 39;<br>
> - UnitLength = PrologueLength + 4;<br>
> - EXPECT_EQ(Prologue.getAddressSize(), 8u);<br>
> - EXPECT_EQ(Prologue.SegSelectorSize, 0u);<br>
> - break;<br>
> - default:<br>
> - llvm_unreachable("unsupported DWARF version");<br>
> - }<br>
> - UnitLength += BodyLength + (Format == DWARF32 ? 4 : 8);<br>
> -<br>
> - EXPECT_EQ(Prologue.TotalLength, UnitLength);<br>
> - EXPECT_EQ(Prologue.PrologueLength, PrologueLength);<br>
> - EXPECT_EQ(Prologue.MinInstLength, 1u);<br>
> - EXPECT_EQ(Prologue.DefaultIsStmt, 1u);<br>
> - EXPECT_EQ(Prologue.LineBase, -5);<br>
> - EXPECT_EQ(Prologue.LineRange, 14u);<br>
> - EXPECT_EQ(Prologue.OpcodeBase, 13u);<br>
> - std::vector<uint8_t> ExpectedLengths = {0, 1, 1, 1, 1, 0, 0, 0, 1, 0,<br>
> 0, 1};<br>
> - EXPECT_EQ(Prologue.StandardOpcodeLengths, ExpectedLengths);<br>
> - ASSERT_EQ(Prologue.IncludeDirectories.size(), 1u);<br>
> - ASSERT_EQ(Prologue.IncludeDirectories[0].getForm(), DW_FORM_string);<br>
> - EXPECT_STREQ(*Prologue.IncludeDirectories[0].getAsCString(), "a dir");<br>
> - ASSERT_EQ(Prologue.FileNames.size(), 1u);<br>
> - ASSERT_EQ(Prologue.FileNames[0].Name.getForm(), DW_FORM_string);<br>
> - EXPECT_STREQ(*Prologue.FileNames[0].Name.getAsCString(), "a file");<br>
> -}<br>
> -<br>
> -TEST_F(DebugLineBasicFixture, GetOrParseLineTableAtInvalidOffset) {<br>
> - if (!setupGenerator())<br>
> - return;<br>
> - generate();<br>
> -<br>
> - checkGetOrParseLineTableEmitsFatalError(<br>
> - "offset 0x00000000 is not a valid debug line section offset", 0);<br>
> - // Repeat to show that an error is reported each time.<br>
> - checkGetOrParseLineTableEmitsFatalError(<br>
> - "offset 0x00000000 is not a valid debug line section offset", 0);<br>
> - // Show that an error is reported for later offsets too.<br>
> - checkGetOrParseLineTableEmitsFatalError(<br>
> - "offset 0x00000001 is not a valid debug line section offset", 1);<br>
> -}<br>
> -<br>
> -TEST_F(DebugLineBasicFixture,<br>
> GetOrParseLineTableAtInvalidOffsetAfterData) {<br>
> - if (!setupGenerator())<br>
> - return;<br>
> -<br>
> - LineTable < = Gen->addLineTable();<br>
> - LT.setCustomPrologue({{0, LineTable::Byte}});<br>
> -<br>
> - generate();<br>
> -<br>
> - checkGetOrParseLineTableEmitsFatalError(<br>
> - "offset 0x00000001 is not a valid debug line section offset", 1);<br>
> -}<br>
> -<br>
> -TEST_P(DebugLineParameterisedFixture, GetOrParseLineTableValidTable) {<br>
> - if (!setupGenerator(Version))<br>
> - return;<br>
> -<br>
> - SCOPED_TRACE("Checking Version " + std::to_string(Version) + ", Format<br>
> " +<br>
> - (Format == DWARF64 ? "DWARF64" : "DWARF32"));<br>
> -<br>
> - LineTable < = Gen->addLineTable(Format);<br>
> - LT.addExtendedOpcode(9, DW_LNE_set_address, {{0xadd4e55,<br>
> LineTable::Quad}});<br>
> - LT.addStandardOpcode(DW_LNS_copy, {});<br>
> - LT.addByte(0xaa);<br>
> - LT.addExtendedOpcode(1, DW_LNE_end_sequence, {});<br>
> -<br>
> - LineTable <2 = Gen->addLineTable(Format);<br>
> - LT2.addExtendedOpcode(9, DW_LNE_set_address, {{0x11223344,<br>
> LineTable::Quad}});<br>
> - LT2.addStandardOpcode(DW_LNS_copy, {});<br>
> - LT2.addByte(0xbb);<br>
> - LT2.addExtendedOpcode(1, DW_LNE_end_sequence, {});<br>
> - LT2.addExtendedOpcode(9, DW_LNE_set_address, {{0x55667788,<br>
> LineTable::Quad}});<br>
> - LT2.addStandardOpcode(DW_LNS_copy, {});<br>
> - LT2.addByte(0xcc);<br>
> - LT2.addExtendedOpcode(1, DW_LNE_end_sequence, {});<br>
> -<br>
> - generate();<br>
> -<br>
> - auto ExpectedLineTable = Line.getOrParseLineTable(LineData, 0,<br>
> *Context,<br>
> - nullptr,<br>
> RecordRecoverable);<br>
> - ASSERT_TRUE(ExpectedLineTable.operator bool());<br>
> - EXPECT_FALSE(Recoverable);<br>
> - const DWARFDebugLine::LineTable *Expected = *ExpectedLineTable;<br>
> - checkDefaultPrologue(Version, Format, Expected->Prologue, 16);<br>
> - EXPECT_EQ(Expected->Sequences.size(), 1u);<br>
> -<br>
> - uint64_t SecondOffset =<br>
> - Expected->Prologue.sizeofTotalLength() + Expected-<br>
> >Prologue.TotalLength;<br>
> - Recoverable = Error::success();<br>
> - auto ExpectedLineTable2 = Line.getOrParseLineTable(<br>
> - LineData, SecondOffset, *Context, nullptr, RecordRecoverable);<br>
> - ASSERT_TRUE(ExpectedLineTable2.operator bool());<br>
> - EXPECT_FALSE(Recoverable);<br>
> - const DWARFDebugLine::LineTable *Expected2 = *ExpectedLineTable2;<br>
> - checkDefaultPrologue(Version, Format, Expected2->Prologue, 32);<br>
> - EXPECT_EQ(Expected2->Sequences.size(), 2u);<br>
> -<br>
> - EXPECT_NE(Expected, Expected2);<br>
> -<br>
> - // Check that if the same offset is requested, the exact same pointer<br>
> is<br>
> - // returned.<br>
> - Recoverable = Error::success();<br>
> - auto ExpectedLineTable3 = Line.getOrParseLineTable(<br>
> - LineData, 0, *Context, nullptr, RecordRecoverable);<br>
> - ASSERT_TRUE(ExpectedLineTable3.operator bool());<br>
> - EXPECT_FALSE(Recoverable);<br>
> - EXPECT_EQ(Expected, *ExpectedLineTable3);<br>
> -<br>
> - Recoverable = Error::success();<br>
> - auto ExpectedLineTable4 = Line.getOrParseLineTable(<br>
> - LineData, SecondOffset, *Context, nullptr, RecordRecoverable);<br>
> - ASSERT_TRUE(ExpectedLineTable4.operator bool());<br>
> - EXPECT_FALSE(Recoverable);<br>
> - EXPECT_EQ(Expected2, *ExpectedLineTable4);<br>
> -<br>
> - // TODO: Add tests that show that the body of the programs have been<br>
> read<br>
> - // correctly.<br>
> -}<br>
> -<br>
> -TEST_F(DebugLineBasicFixture, ErrorForReservedLength) {<br>
> - if (!setupGenerator())<br>
> - return;<br>
> -<br>
> - LineTable < = Gen->addLineTable();<br>
> - LT.setCustomPrologue({{0xfffffff0, LineTable::Long}});<br>
> -<br>
> - generate();<br>
> -<br>
> - checkGetOrParseLineTableEmitsFatalError(<br>
> - "parsing line table prologue at offset 0x00000000 unsupported<br>
> reserved "<br>
> - "unit length found of value 0xfffffff0");<br>
> -}<br>
> -<br>
> -TEST_F(DebugLineBasicFixture, ErrorForLowVersion) {<br>
> - if (!setupGenerator())<br>
> - return;<br>
> -<br>
> - LineTable < = Gen->addLineTable();<br>
> - LT.setCustomPrologue(<br>
> - {{LineTable::Half, LineTable::Long}, {1, LineTable::Half}});<br>
> -<br>
> - generate();<br>
> -<br>
> - checkGetOrParseLineTableEmitsFatalError(<br>
> - "parsing line table prologue at offset "<br>
> - "0x00000000 found unsupported version "<br>
> - "0x01");<br>
> -}<br>
> -<br>
> -TEST_F(DebugLineBasicFixture, ErrorForInvalidV5IncludeDirTable) {<br>
> - if (!setupGenerator(5))<br>
> - return;<br>
> -<br>
> - LineTable < = Gen->addLineTable();<br>
> - LT.setCustomPrologue({<br>
> - {19, LineTable::Long}, // unit length<br>
> - {5, LineTable::Half}, // version<br>
> - {8, LineTable::Byte}, // addr size<br>
> - {0, LineTable::Byte}, // segment selector size<br>
> - {11, LineTable::Long}, // prologue length<br>
> - {1, LineTable::Byte}, // min instruction length<br>
> - {1, LineTable::Byte}, // max ops per instruction<br>
> - {1, LineTable::Byte}, // default is_stmt<br>
> - {0, LineTable::Byte}, // line base<br>
> - {14, LineTable::Byte}, // line range<br>
> - {2, LineTable::Byte}, // opcode base (small to reduce the amount<br>
> of<br>
> - // setup required).<br>
> - {0, LineTable::Byte}, // standard opcode lengths<br>
> - {0, LineTable::Byte}, // directory entry format count (should not<br>
> be<br>
> - // zero).<br>
> - {0, LineTable::ULEB}, // directories count<br>
> - {0, LineTable::Byte}, // file name entry format count<br>
> - {0, LineTable::ULEB} // file name entry count<br>
> - });<br>
> -<br>
> - generate();<br>
> -<br>
> - checkGetOrParseLineTableEmitsFatalError(<br>
> - {"parsing line table prologue at 0x00000000 found an invalid<br>
> directory "<br>
> - "or file table description at 0x00000014",<br>
> - "failed to parse entry content descriptions because no path was<br>
> found"});<br>
> -}<br>
> -<br>
> -TEST_P(DebugLineParameterisedFixture, ErrorForTooLargePrologueLength) {<br>
> - if (!setupGenerator(Version))<br>
> - return;<br>
> -<br>
> - SCOPED_TRACE("Checking Version " + std::to_string(Version) + ", Format<br>
> " +<br>
> - (Format == DWARF64 ? "DWARF64" : "DWARF32"));<br>
> -<br>
> - LineTable < = Gen->addLineTable(Format);<br>
> - DWARFDebugLine::Prologue Prologue = LT.createBasicPrologue();<br>
> - ++Prologue.PrologueLength;<br>
> - LT.setPrologue(Prologue);<br>
> -<br>
> - generate();<br>
> -<br>
> - uint64_t ExpectedEnd =<br>
> - Prologue.TotalLength + 1 + Prologue.sizeofTotalLength();<br>
> - checkGetOrParseLineTableEmitsFatalError(<br>
> - (Twine("parsing line table prologue at 0x00000000 should have ended<br>
> at "<br>
> - "0x000000") +<br>
> - Twine::utohexstr(ExpectedEnd) + " but it ended at 0x000000" +<br>
> - Twine::utohexstr(ExpectedEnd - 1))<br>
> - .str());<br>
> -}<br>
> -<br>
> -TEST_P(DebugLineParameterisedFixture, ErrorForTooShortPrologueLength) {<br>
> - if (!setupGenerator(Version))<br>
> - return;<br>
> -<br>
> - SCOPED_TRACE("Checking Version " + std::to_string(Version) + ", Format<br>
> " +<br>
> - (Format == DWARF64 ? "DWARF64" : "DWARF32"));<br>
> -<br>
> - LineTable < = Gen->addLineTable(Format);<br>
> - DWARFDebugLine::Prologue Prologue = LT.createBasicPrologue();<br>
> - // FIXME: Ideally, we'd test for 1 less than expected, but the code<br>
> does not<br>
> - // currently fail if missing only the terminator of a v2-4 file table.<br>
> - if (Version < 5)<br>
> - Prologue.PrologueLength -= 2;<br>
> - else<br>
> - Prologue.PrologueLength -= 1;<br>
> - LT.setPrologue(Prologue);<br>
> -<br>
> - generate();<br>
> -<br>
> - uint64_t ExpectedEnd =<br>
> - Prologue.TotalLength - 1 + Prologue.sizeofTotalLength();<br>
> - if (Version < 5)<br>
> - --ExpectedEnd;<br>
> - checkGetOrParseLineTableEmitsFatalError(<br>
> - (Twine("parsing line table prologue at 0x00000000 should have ended<br>
> at "<br>
> - "0x000000") +<br>
> - Twine::utohexstr(ExpectedEnd) + " but it ended at 0x000000" +<br>
> - Twine::utohexstr(ExpectedEnd + 1))<br>
> - .str());<br>
> -}<br>
> -<br>
> -INSTANTIATE_TEST_CASE_P(<br>
> - LineTableTestParams, DebugLineParameterisedFixture,<br>
> - Values(std::make_pair(<br>
> - 2, DWARF32), // Test lower-bound of v2-3 fields and<br>
> DWARF32.<br>
> - std::make_pair(3, DWARF32), // Test upper-bound of v2-3<br>
> fields.<br>
> - std::make_pair(4, DWARF64), // Test v4 fields and DWARF64.<br>
> - std::make_pair(5, DWARF32), std::make_pair(5, DWARF64)), );<br>
> -<br>
> -TEST_F(DebugLineBasicFixture, ErrorForInvalidExtendedOpcodeLength) {<br>
> - if (!setupGenerator())<br>
> - return;<br>
> -<br>
> - LineTable < = Gen->addLineTable();<br>
> - // The Length should be 1 for an end sequence opcode.<br>
> - LT.addExtendedOpcode(2, DW_LNE_end_sequence, {});<br>
> -<br>
> - generate();<br>
> -<br>
> - checkGetOrParseLineTableEmitsFatalError(<br>
> - "unexpected line op length at offset "<br>
> - "0x00000030 expected 0x02 found 0x01");<br>
> -}<br>
> -<br>
> -TEST_F(DebugLineBasicFixture, ErrorForUnitLengthTooLarge) {<br>
> - if (!setupGenerator())<br>
> - return;<br>
> -<br>
> - LineTable &Padding = Gen->addLineTable();<br>
> - // Add some padding to show that a non-zero offset is handled<br>
> correctly.<br>
> - Padding.setCustomPrologue({{0, LineTable::Byte}});<br>
> - LineTable < = Gen->addLineTable();<br>
> - LT.addStandardOpcode(DW_LNS_copy, {});<br>
> - LT.addStandardOpcode(DW_LNS_const_add_pc, {});<br>
> - LT.addExtendedOpcode(1, DW_LNE_end_sequence, {});<br>
> - DWARFDebugLine::Prologue Prologue = LT.createBasicPrologue();<br>
> - // Set the total length to 1 higher than the actual length. The program<br>
> body<br>
> - // has size 5.<br>
> - Prologue.TotalLength += 6;<br>
> - LT.setPrologue(Prologue);<br>
> -<br>
> - generate();<br>
> -<br>
> - auto ExpectedLineTable = Line.getOrParseLineTable(LineData, 1,<br>
> *Context,<br>
> - nullptr,<br>
> RecordRecoverable);<br>
> - checkError("line table program with offset 0x00000001 has length<br>
> 0x00000034 "<br>
> - "but only 0x00000033 bytes are available",<br>
> - std::move(Recoverable));<br>
> - ASSERT_THAT_EXPECTED(ExpectedLineTable, Succeeded());<br>
> - EXPECT_EQ((*ExpectedLineTable)->Rows.size(), 2u);<br>
> - EXPECT_EQ((*ExpectedLineTable)->Sequences.size(), 1u);<br>
> -}<br>
> -<br>
> -TEST_F(DebugLineBasicFixture, ErrorForMismatchedAddressSize) {<br>
> - if (!setupGenerator())<br>
> - return;<br>
> -<br>
> - LineTable < = Gen->addLineTable();<br>
> - // The line data extractor expects size 8 (Quad) addresses.<br>
> - LT.addExtendedOpcode(5, DW_LNE_set_address, {{0x11223344,<br>
> LineTable::Long}});<br>
> - LT.addStandardOpcode(DW_LNS_copy, {});<br>
> - LT.addByte(0xaa);<br>
> - LT.addExtendedOpcode(1, DW_LNE_end_sequence, {});<br>
> -<br>
> - generate();<br>
> -<br>
> - checkGetOrParseLineTableEmitsFatalError(<br>
> - "mismatching address size at offset 0x00000030 expected 0x08 found<br>
> 0x04");<br>
> -}<br>
> -<br>
> -TEST_F(DebugLineBasicFixture, CallbackUsedForUnterminatedSequence) {<br>
> - if (!setupGenerator())<br>
> - return;<br>
> -<br>
> - LineTable < = Gen->addLineTable();<br>
> - LT.addExtendedOpcode(9, DW_LNE_set_address,<br>
> - {{0x1122334455667788, LineTable::Quad}});<br>
> - LT.addStandardOpcode(DW_LNS_copy, {});<br>
> - LT.addByte(0xaa);<br>
> - LT.addExtendedOpcode(1, DW_LNE_end_sequence, {});<br>
> - LT.addExtendedOpcode(9, DW_LNE_set_address,<br>
> - {{0x99aabbccddeeff00, LineTable::Quad}});<br>
> - LT.addStandardOpcode(DW_LNS_copy, {});<br>
> - LT.addByte(0xbb);<br>
> - LT.addByte(0xcc);<br>
> -<br>
> - generate();<br>
> -<br>
> - auto ExpectedLineTable = Line.getOrParseLineTable(LineData, 0,<br>
> *Context,<br>
> - nullptr,<br>
> RecordRecoverable);<br>
> - checkError("last sequence in debug line table is not terminated!",<br>
> - std::move(Recoverable));<br>
> - ASSERT_TRUE(ExpectedLineTable.operator bool());<br>
> - EXPECT_EQ((*ExpectedLineTable)->Rows.size(), 6u);<br>
> - // The unterminated sequence is not added to the sequence list.<br>
> - EXPECT_EQ((*ExpectedLineTable)->Sequences.size(), 1u);<br>
> -}<br>
> -<br>
> -TEST_F(DebugLineBasicFixture, ParserParsesCorrectly) {<br>
> - if (!setupGenerator())<br>
> - return;<br>
> -<br>
> - DWARFDebugLine::SectionParser Parser = setupParser();<br>
> -<br>
> - EXPECT_EQ(Parser.getOffset(), 0u);<br>
> - ASSERT_FALSE(Parser.done());<br>
> -<br>
> - DWARFDebugLine::LineTable Parsed =<br>
> - Parser.parseNext(RecordRecoverable, RecordUnrecoverable);<br>
> - checkDefaultPrologue(4, DWARF32, Parsed.Prologue, 16);<br>
> - EXPECT_EQ(Parsed.Sequences.size(), 1u);<br>
> - EXPECT_EQ(Parser.getOffset(), 62u);<br>
> - ASSERT_FALSE(Parser.done());<br>
> -<br>
> - DWARFDebugLine::LineTable Parsed2 =<br>
> - Parser.parseNext(RecordRecoverable, RecordUnrecoverable);<br>
> - checkDefaultPrologue(4, DWARF64, Parsed2.Prologue, 16);<br>
> - EXPECT_EQ(Parsed2.Sequences.size(), 1u);<br>
> - EXPECT_EQ(Parser.getOffset(), 136u);<br>
> - EXPECT_TRUE(Parser.done());<br>
> -<br>
> - EXPECT_FALSE(Recoverable);<br>
> - EXPECT_FALSE(Unrecoverable);<br>
> -}<br>
> -<br>
> -TEST_F(DebugLineBasicFixture, ParserSkipsCorrectly) {<br>
> - if (!setupGenerator())<br>
> - return;<br>
> -<br>
> - DWARFDebugLine::SectionParser Parser = setupParser();<br>
> -<br>
> - EXPECT_EQ(Parser.getOffset(), 0u);<br>
> - ASSERT_FALSE(Parser.done());<br>
> -<br>
> - Parser.skip(RecordUnrecoverable);<br>
> - EXPECT_EQ(Parser.getOffset(), 62u);<br>
> - ASSERT_FALSE(Parser.done());<br>
> -<br>
> - Parser.skip(RecordUnrecoverable);<br>
> - EXPECT_EQ(Parser.getOffset(), 136u);<br>
> - EXPECT_TRUE(Parser.done());<br>
> -<br>
> - EXPECT_FALSE(Unrecoverable);<br>
> -}<br>
> -<br>
> -TEST_F(DebugLineBasicFixture, ParserAlwaysDoneForEmptySection) {<br>
> - if (!setupGenerator())<br>
> - return;<br>
> -<br>
> - generate();<br>
> - DWARFDebugLine::SectionParser Parser(LineData, *Context, CUs, TUs);<br>
> -<br>
> - EXPECT_TRUE(Parser.done());<br>
> -}<br>
> -<br>
> -TEST_F(DebugLineBasicFixture, ParserMovesToEndForBadLengthWhenParsing) {<br>
> - if (!setupGenerator())<br>
> - return;<br>
> -<br>
> - LineTable < = Gen->addLineTable();<br>
> - LT.setCustomPrologue({{0xfffffff0, LineTable::Long}});<br>
> - Gen->addLineTable();<br>
> - generate();<br>
> -<br>
> - DWARFDebugLine::SectionParser Parser(LineData, *Context, CUs, TUs);<br>
> - Parser.parseNext(RecordRecoverable, RecordUnrecoverable);<br>
> -<br>
> - EXPECT_EQ(Parser.getOffset(), 4u);<br>
> - EXPECT_TRUE(Parser.done());<br>
> - EXPECT_FALSE(Recoverable);<br>
> -<br>
> - checkError("parsing line table prologue at offset 0x00000000<br>
> unsupported "<br>
> - "reserved unit length found of value 0xfffffff0",<br>
> - std::move(Unrecoverable));<br>
> -}<br>
> -<br>
> -TEST_F(DebugLineBasicFixture, ParserMovesToEndForBadLengthWhenSkipping) {<br>
> - if (!setupGenerator())<br>
> - return;<br>
> -<br>
> - LineTable < = Gen->addLineTable();<br>
> - LT.setCustomPrologue({{0xfffffff0, LineTable::Long}});<br>
> - Gen->addLineTable();<br>
> - generate();<br>
> -<br>
> - DWARFDebugLine::SectionParser Parser(LineData, *Context, CUs, TUs);<br>
> - Parser.skip(RecordUnrecoverable);<br>
> -<br>
> - EXPECT_EQ(Parser.getOffset(), 4u);<br>
> - EXPECT_TRUE(Parser.done());<br>
> -<br>
> - checkError("parsing line table prologue at offset 0x00000000<br>
> unsupported "<br>
> - "reserved unit length found of value 0xfffffff0",<br>
> - std::move(Unrecoverable));<br>
> -}<br>
> -<br>
> -TEST_F(DebugLineBasicFixture,<br>
> ParserReportsFirstErrorInEachTableWhenParsing) {<br>
> - if (!setupGenerator())<br>
> - return;<br>
> -<br>
> - LineTable < = Gen->addLineTable(DWARF32);<br>
> - LT.setCustomPrologue({{2, LineTable::Long}, {0, LineTable::Half}});<br>
> - LineTable <2 = Gen->addLineTable(DWARF32);<br>
> - LT2.setCustomPrologue({{2, LineTable::Long}, {1, LineTable::Half}});<br>
> - generate();<br>
> -<br>
> - DWARFDebugLine::SectionParser Parser(LineData, *Context, CUs, TUs);<br>
> - Parser.parseNext(RecordRecoverable, RecordUnrecoverable);<br>
> - ASSERT_FALSE(Parser.done());<br>
> - Parser.parseNext(RecordRecoverable, RecordUnrecoverable);<br>
> -<br>
> - EXPECT_TRUE(Parser.done());<br>
> - EXPECT_FALSE(Recoverable);<br>
> -<br>
> - checkError({"parsing line table prologue at offset 0x00000000 found "<br>
> - "unsupported version 0x00",<br>
> - "parsing line table prologue at offset 0x00000006 found "<br>
> - "unsupported version 0x01"},<br>
> - std::move(Unrecoverable));<br>
> -}<br>
> -<br>
> -TEST_F(DebugLineBasicFixture,<br>
> ParserReportsNonPrologueProblemsWhenParsing) {<br>
> - if (!setupGenerator())<br>
> - return;<br>
> -<br>
> - LineTable < = Gen->addLineTable(DWARF32);<br>
> - LT.addExtendedOpcode(0x42, DW_LNE_end_sequence, {});<br>
> - LineTable <2 = Gen->addLineTable(DWARF32);<br>
> - LT2.addExtendedOpcode(9, DW_LNE_set_address,<br>
> - {{0x1234567890abcdef, LineTable::Quad}});<br>
> - LT2.addStandardOpcode(DW_LNS_copy, {});<br>
> - LT2.addByte(0xbb);<br>
> - generate();<br>
> -<br>
> - DWARFDebugLine::SectionParser Parser(LineData, *Context, CUs, TUs);<br>
> - Parser.parseNext(RecordRecoverable, RecordUnrecoverable);<br>
> - EXPECT_FALSE(Recoverable);<br>
> - ASSERT_FALSE(Parser.done());<br>
> - checkError(<br>
> - "unexpected line op length at offset 0x00000030 expected 0x42 found<br>
> 0x01",<br>
> - std::move(Unrecoverable));<br>
> -<br>
> - // Reset the error state so that it does not confuse the next set of<br>
> checks.<br>
> - Unrecoverable = Error::success();<br>
> - Parser.parseNext(RecordRecoverable, RecordUnrecoverable);<br>
> -<br>
> - EXPECT_TRUE(Parser.done());<br>
> - checkError("last sequence in debug line table is not terminated!",<br>
> - std::move(Recoverable));<br>
> - EXPECT_FALSE(Unrecoverable);<br>
> -}<br>
> -<br>
> -TEST_F(DebugLineBasicFixture,<br>
> - ParserReportsPrologueErrorsInEachTableWhenSkipping) {<br>
> - if (!setupGenerator())<br>
> - return;<br>
> -<br>
> - LineTable < = Gen->addLineTable(DWARF32);<br>
> - LT.setCustomPrologue({{2, LineTable::Long}, {0, LineTable::Half}});<br>
> - LineTable <2 = Gen->addLineTable(DWARF32);<br>
> - LT2.setCustomPrologue({{2, LineTable::Long}, {1, LineTable::Half}});<br>
> - generate();<br>
> -<br>
> - DWARFDebugLine::SectionParser Parser(LineData, *Context, CUs, TUs);<br>
> - Parser.skip(RecordUnrecoverable);<br>
> - ASSERT_FALSE(Parser.done());<br>
> - Parser.skip(RecordUnrecoverable);<br>
> -<br>
> - EXPECT_TRUE(Parser.done());<br>
> -<br>
> - checkError({"parsing line table prologue at offset 0x00000000 found "<br>
> - "unsupported version 0x00",<br>
> - "parsing line table prologue at offset 0x00000006 found "<br>
> - "unsupported version 0x01"},<br>
> - std::move(Unrecoverable));<br>
> -}<br>
> -<br>
> -TEST_F(DebugLineBasicFixture, ParserIgnoresNonPrologueErrorsWhenSkipping)<br>
> {<br>
> - if (!setupGenerator())<br>
> - return;<br>
> -<br>
> - LineTable < = Gen->addLineTable(DWARF32);<br>
> - LT.addExtendedOpcode(42, DW_LNE_end_sequence, {});<br>
> - generate();<br>
> -<br>
> - DWARFDebugLine::SectionParser Parser(LineData, *Context, CUs, TUs);<br>
> - Parser.skip(RecordUnrecoverable);<br>
> -<br>
> - EXPECT_TRUE(Parser.done());<br>
> - EXPECT_FALSE(Unrecoverable);<br>
> -}<br>
> -<br>
> -TEST_F(DebugLineBasicFixture, ParserPrintsStandardOpcodesWhenRequested) {<br>
> - if (!setupGenerator())<br>
> - return;<br>
> -<br>
> - using ValLen = dwarfgen::LineTable::ValueAndLength;<br>
> - LineTable < = Gen->addLineTable(DWARF32);<br>
> - LT.addStandardOpcode(DW_LNS_copy, {});<br>
> - LT.addStandardOpcode(DW_LNS_advance_pc, {ValLen{11, LineTable::ULEB}});<br>
> - LT.addStandardOpcode(DW_LNS_advance_line, {ValLen{22,<br>
> LineTable::SLEB}});<br>
> - LT.addStandardOpcode(DW_LNS_set_file, {ValLen{33, LineTable::ULEB}});<br>
> - LT.addStandardOpcode(DW_LNS_set_column, {ValLen{44, LineTable::ULEB}});<br>
> - LT.addStandardOpcode(DW_LNS_negate_stmt, {});<br>
> - LT.addStandardOpcode(DW_LNS_set_basic_block, {});<br>
> - LT.addStandardOpcode(DW_LNS_const_add_pc, {});<br>
> - LT.addStandardOpcode(DW_LNS_fixed_advance_pc, {ValLen{55,<br>
> LineTable::Half}});<br>
> - LT.addStandardOpcode(DW_LNS_set_prologue_end, {});<br>
> - LT.addStandardOpcode(DW_LNS_set_epilogue_begin, {});<br>
> - LT.addStandardOpcode(DW_LNS_set_isa, {ValLen{66, LineTable::ULEB}});<br>
> - LT.addExtendedOpcode(1, DW_LNE_end_sequence, {});<br>
> - generate();<br>
> -<br>
> - DWARFDebugLine::SectionParser Parser(LineData, *Context, CUs, TUs);<br>
> - std::string Output;<br>
> - raw_string_ostream OS(Output);<br>
> - Parser.parseNext(RecordRecoverable, RecordUnrecoverable, &OS);<br>
> - OS.flush();<br>
> -<br>
> - EXPECT_FALSE(Recoverable);<br>
> - EXPECT_FALSE(Unrecoverable);<br>
> - auto InOutput = [&Output](char const *Str) {<br>
> - return Output.find(Str) != std::string::npos;<br>
> - };<br>
> - EXPECT_TRUE(InOutput("0x0000002e: 01 DW_LNS_copy\n")) << Output;<br>
> - EXPECT_TRUE(InOutput("0x0000002f: 02 DW_LNS_advance_pc (11)\n")) <<<br>
> Output;<br>
> - // FIXME: The value printed after DW_LNS_advance_line is currently the<br>
> result<br>
> - // of the advance, but it should be the value being advanced by. See<br>
> - // <a href="https://bugs.llvm.org/show_bug.cgi?id=44261" rel="noreferrer" target="_blank">https://bugs.llvm.org/show_bug.cgi?id=44261</a> for details.<br>
> - EXPECT_TRUE(InOutput("0x00000031: 03 DW_LNS_advance_line (23)\n")) <<<br>
> Output;<br>
> - EXPECT_TRUE(InOutput("0x00000033: 04 DW_LNS_set_file (33)\n")) <<<br>
> Output;<br>
> - EXPECT_TRUE(InOutput("0x00000035: 05 DW_LNS_set_column (44)\n")) <<<br>
> Output;<br>
> - EXPECT_TRUE(InOutput("0x00000037: 06 DW_LNS_negate_stmt\n")) << Output;<br>
> - EXPECT_TRUE(InOutput("0x00000038: 07 DW_LNS_set_basic_block\n")) <<<br>
> Output;<br>
> - EXPECT_TRUE(<br>
> - InOutput("0x00000039: 08 DW_LNS_const_add_pc<br>
> (0x0000000000000011)\n"))<br>
> - << Output;<br>
> - EXPECT_TRUE(InOutput("0x0000003a: 09 DW_LNS_fixed_advance_pc<br>
> (0x0037)\n"))<br>
> - << Output;<br>
> - EXPECT_TRUE(InOutput("0x0000003d: 0a DW_LNS_set_prologue_end\n")) <<<br>
> Output;<br>
> - EXPECT_TRUE(InOutput("0x0000003e: 0b DW_LNS_set_epilogue_begin\n")) <<<br>
> Output;<br>
> - EXPECT_TRUE(InOutput("0x0000003f: 0c DW_LNS_set_isa (66)\n")) <<<br>
> Output;<br>
> -}<br>
> -<br>
> -} // end anonymous namespace<br>
> +//===- DWARFDebugLineTest.cpp -------------------------------------------<br>
> --===//<br>
> +//<br>
> +// Part of the LLVM Project, under the Apache License v2.0 with LLVM<br>
> Exceptions.<br>
> +// See <a href="https://llvm.org/LICENSE.txt" rel="noreferrer" target="_blank">https://llvm.org/LICENSE.txt</a> for license information.<br>
> +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception<br>
> +//<br>
> +//===--------------------------------------------------------------------<br>
> --===//<br>
> +<br>
> +#include "DwarfGenerator.h"<br>
> +#include "DwarfUtils.h"<br>
> +#include "llvm/DebugInfo/DWARF/DWARFContext.h"<br>
> +#include "llvm/DebugInfo/DWARF/DWARFDebugLine.h"<br>
> +#include "llvm/Object/ObjectFile.h"<br>
> +#include "llvm/Testing/Support/Error.h"<br>
> +#include "gtest/gtest.h"<br>
> +<br>
> +using namespace llvm;<br>
> +using namespace dwarf;<br>
> +using namespace dwarfgen;<br>
> +using namespace object;<br>
> +using namespace utils;<br>
> +using namespace testing;<br>
> +<br>
> +namespace {<br>
> +struct CommonFixture {<br>
> + CommonFixture()<br>
> + : LineData("", true, 0), Recoverable(Error::success()),<br>
> + RecordRecoverable(std::bind(&CommonFixture::recordRecoverable,<br>
> this,<br>
> + std::placeholders::_1)),<br>
> + Unrecoverable(Error::success()),<br>
> +<br>
> RecordUnrecoverable(std::bind(&CommonFixture::recordUnrecoverable, this,<br>
> + std::placeholders::_1)){};<br>
> +<br>
> + ~CommonFixture() {<br>
> + EXPECT_FALSE(Recoverable);<br>
> + EXPECT_FALSE(Unrecoverable);<br>
> + }<br>
> +<br>
> + bool setupGenerator(uint16_t Version = 4) {<br>
> + Triple T = getDefaultTargetTripleForAddrSize(8);<br>
> + if (!isConfigurationSupported(T))<br>
> + return false;<br>
> + auto ExpectedGenerator = Generator::create(T, Version);<br>
> + if (ExpectedGenerator)<br>
> + Gen.reset(ExpectedGenerator->release());<br>
> + return true;<br>
> + }<br>
> +<br>
> + void generate() {<br>
> + Context = createContext();<br>
> + assert(Context != nullptr && "test state is not valid");<br>
> + const DWARFObject &Obj = Context->getDWARFObj();<br>
> + LineData = DWARFDataExtractor(<br>
> + Obj, Obj.getLineSection(),<br>
> + getDefaultTargetTripleForAddrSize(8).isLittleEndian(), 8);<br>
> + }<br>
> +<br>
> + std::unique_ptr<DWARFContext> createContext() {<br>
> + if (!Gen)<br>
> + return nullptr;<br>
> + StringRef FileBytes = Gen->generate();<br>
> + MemoryBufferRef FileBuffer(FileBytes, "dwarf");<br>
> + auto Obj = object::ObjectFile::createObjectFile(FileBuffer);<br>
> + if (Obj)<br>
> + return DWARFContext::create(**Obj);<br>
> + return nullptr;<br>
> + }<br>
> +<br>
> + DWARFDebugLine::SectionParser setupParser() {<br>
> + LineTable < = Gen->addLineTable(DWARF32);<br>
> + LT.addExtendedOpcode(9, DW_LNE_set_address, {{0xadd4e55,<br>
> LineTable::Quad}});<br>
> + LT.addStandardOpcode(DW_LNS_copy, {});<br>
> + LT.addByte(0xaa);<br>
> + LT.addExtendedOpcode(1, DW_LNE_end_sequence, {});<br>
> +<br>
> + LineTable <2 = Gen->addLineTable(DWARF64);<br>
> + LT2.addExtendedOpcode(9, DW_LNE_set_address,<br>
> + {{0x11223344, LineTable::Quad}});<br>
> + LT2.addStandardOpcode(DW_LNS_copy, {});<br>
> + LT2.addByte(0xbb);<br>
> + LT2.addExtendedOpcode(1, DW_LNE_end_sequence, {});<br>
> +<br>
> + generate();<br>
> +<br>
> + return DWARFDebugLine::SectionParser(LineData, *Context, CUs, TUs);<br>
> + }<br>
> +<br>
> + void recordRecoverable(Error Err) {<br>
> + Recoverable = joinErrors(std::move(Recoverable), std::move(Err));<br>
> + }<br>
> + void recordUnrecoverable(Error Err) {<br>
> + Unrecoverable = joinErrors(std::move(Unrecoverable), std::move(Err));<br>
> + }<br>
> +<br>
> + void checkError(ArrayRef<StringRef> ExpectedMsgs, Error Err) {<br>
> + ASSERT_TRUE(Err.operator bool());<br>
> + size_t WhichMsg = 0;<br>
> + Error Remaining =<br>
> + handleErrors(std::move(Err), [&](const ErrorInfoBase &Actual) {<br>
> + ASSERT_LT(WhichMsg, ExpectedMsgs.size());<br>
> + // Use .str(), because googletest doesn't visualise a StringRef<br>
> + // properly.<br>
> + EXPECT_EQ(Actual.message(), ExpectedMsgs[WhichMsg++].str());<br>
> + });<br>
> + EXPECT_EQ(WhichMsg, ExpectedMsgs.size());<br>
> + EXPECT_FALSE(Remaining);<br>
> + }<br>
> +<br>
> + void checkError(StringRef ExpectedMsg, Error Err) {<br>
> + checkError(ArrayRef<StringRef>{ExpectedMsg}, std::move(Err));<br>
> + }<br>
> +<br>
> + void checkGetOrParseLineTableEmitsFatalError(StringRef ExpectedMsg,<br>
> + uint64_t Offset = 0) {<br>
> + auto ExpectedLineTable = Line.getOrParseLineTable(<br>
> + LineData, Offset, *Context, nullptr, RecordRecoverable);<br>
> + EXPECT_FALSE(ExpectedLineTable);<br>
> + EXPECT_FALSE(Recoverable);<br>
> +<br>
> + checkError(ExpectedMsg, ExpectedLineTable.takeError());<br>
> + }<br>
> +<br>
> + void checkGetOrParseLineTableEmitsFatalError(ArrayRef<StringRef><br>
> ExpectedMsgs,<br>
> + uint64_t Offset = 0) {<br>
> + auto ExpectedLineTable = Line.getOrParseLineTable(<br>
> + LineData, Offset, *Context, nullptr, RecordRecoverable);<br>
> + EXPECT_FALSE(ExpectedLineTable);<br>
> + EXPECT_FALSE(Recoverable);<br>
> +<br>
> + checkError(ExpectedMsgs, ExpectedLineTable.takeError());<br>
> + }<br>
> +<br>
> + std::unique_ptr<Generator> Gen;<br>
> + std::unique_ptr<DWARFContext> Context;<br>
> + DWARFDataExtractor LineData;<br>
> + DWARFDebugLine Line;<br>
> + Error Recoverable;<br>
> + std::function<void(Error)> RecordRecoverable;<br>
> + Error Unrecoverable;<br>
> + std::function<void(Error)> RecordUnrecoverable;<br>
> +<br>
> + SmallVector<std::unique_ptr<DWARFUnit>, 2> CUs;<br>
> + SmallVector<std::unique_ptr<DWARFUnit>, 2> TUs;<br>
> +};<br>
> +<br>
> +// Fixtures must derive from "Test", but parameterised fixtures from<br>
> +// "TestWithParam". It does not seem possible to inherit from both, so we<br>
> share<br>
> +// the common state in a separate class, inherited by the two fixture<br>
> classes.<br>
> +struct DebugLineBasicFixture : public Test, public CommonFixture {};<br>
> +<br>
> +struct DebugLineParameterisedFixture<br>
> + : public TestWithParam<std::pair<uint16_t, DwarfFormat>>,<br>
> + public CommonFixture {<br>
> + void SetUp() { std::tie(Version, Format) = GetParam(); }<br>
> +<br>
> + uint16_t Version;<br>
> + DwarfFormat Format;<br>
> +};<br>
> +<br>
> +void checkDefaultPrologue(uint16_t Version, DwarfFormat Format,<br>
> + DWARFDebugLine::Prologue Prologue,<br>
> + uint64_t BodyLength) {<br>
> + // Check version specific fields and values.<br>
> + uint64_t UnitLength;<br>
> + uint64_t PrologueLength;<br>
> + switch (Version) {<br>
> + case 4:<br>
> + PrologueLength = 36;<br>
> + UnitLength = PrologueLength + 2;<br>
> + EXPECT_EQ(Prologue.MaxOpsPerInst, 1u);<br>
> + break;<br>
> + case 2:<br>
> + case 3:<br>
> + PrologueLength = 35;<br>
> + UnitLength = PrologueLength + 2;<br>
> + break;<br>
> + case 5:<br>
> + PrologueLength = 39;<br>
> + UnitLength = PrologueLength + 4;<br>
> + EXPECT_EQ(Prologue.getAddressSize(), 8u);<br>
> + EXPECT_EQ(Prologue.SegSelectorSize, 0u);<br>
> + break;<br>
> + default:<br>
> + llvm_unreachable("unsupported DWARF version");<br>
> + }<br>
> + UnitLength += BodyLength + (Format == DWARF32 ? 4 : 8);<br>
> +<br>
> + EXPECT_EQ(Prologue.TotalLength, UnitLength);<br>
> + EXPECT_EQ(Prologue.PrologueLength, PrologueLength);<br>
> + EXPECT_EQ(Prologue.MinInstLength, 1u);<br>
> + EXPECT_EQ(Prologue.DefaultIsStmt, 1u);<br>
> + EXPECT_EQ(Prologue.LineBase, -5);<br>
> + EXPECT_EQ(Prologue.LineRange, 14u);<br>
> + EXPECT_EQ(Prologue.OpcodeBase, 13u);<br>
> + std::vector<uint8_t> ExpectedLengths = {0, 1, 1, 1, 1, 0, 0, 0, 1, 0,<br>
> 0, 1};<br>
> + EXPECT_EQ(Prologue.StandardOpcodeLengths, ExpectedLengths);<br>
> + ASSERT_EQ(Prologue.IncludeDirectories.size(), 1u);<br>
> + ASSERT_EQ(Prologue.IncludeDirectories[0].getForm(), DW_FORM_string);<br>
> + EXPECT_STREQ(*Prologue.IncludeDirectories[0].getAsCString(), "a dir");<br>
> + ASSERT_EQ(Prologue.FileNames.size(), 1u);<br>
> + ASSERT_EQ(Prologue.FileNames[0].Name.getForm(), DW_FORM_string);<br>
> + EXPECT_STREQ(*Prologue.FileNames[0].Name.getAsCString(), "a file");<br>
> +}<br>
> +<br>
> +TEST_F(DebugLineBasicFixture, GetOrParseLineTableAtInvalidOffset) {<br>
> + if (!setupGenerator())<br>
> + return;<br>
> + generate();<br>
> +<br>
> + checkGetOrParseLineTableEmitsFatalError(<br>
> + "offset 0x00000000 is not a valid debug line section offset", 0);<br>
> + // Repeat to show that an error is reported each time.<br>
> + checkGetOrParseLineTableEmitsFatalError(<br>
> + "offset 0x00000000 is not a valid debug line section offset", 0);<br>
> + // Show that an error is reported for later offsets too.<br>
> + checkGetOrParseLineTableEmitsFatalError(<br>
> + "offset 0x00000001 is not a valid debug line section offset", 1);<br>
> +}<br>
> +<br>
> +TEST_F(DebugLineBasicFixture,<br>
> GetOrParseLineTableAtInvalidOffsetAfterData) {<br>
> + if (!setupGenerator())<br>
> + return;<br>
> +<br>
> + LineTable < = Gen->addLineTable();<br>
> + LT.setCustomPrologue({{0, LineTable::Byte}});<br>
> +<br>
> + generate();<br>
> +<br>
> + checkGetOrParseLineTableEmitsFatalError(<br>
> + "offset 0x00000001 is not a valid debug line section offset", 1);<br>
> +}<br>
> +<br>
> +TEST_P(DebugLineParameterisedFixture, GetOrParseLineTableValidTable) {<br>
> + if (!setupGenerator(Version))<br>
> + return;<br>
> +<br>
> + SCOPED_TRACE("Checking Version " + std::to_string(Version) + ", Format<br>
> " +<br>
> + (Format == DWARF64 ? "DWARF64" : "DWARF32"));<br>
> +<br>
> + LineTable < = Gen->addLineTable(Format);<br>
> + LT.addExtendedOpcode(9, DW_LNE_set_address, {{0xadd4e55,<br>
> LineTable::Quad}});<br>
> + LT.addStandardOpcode(DW_LNS_copy, {});<br>
> + LT.addByte(0xaa);<br>
> + LT.addExtendedOpcode(1, DW_LNE_end_sequence, {});<br>
> +<br>
> + LineTable <2 = Gen->addLineTable(Format);<br>
> + LT2.addExtendedOpcode(9, DW_LNE_set_address, {{0x11223344,<br>
> LineTable::Quad}});<br>
> + LT2.addStandardOpcode(DW_LNS_copy, {});<br>
> + LT2.addByte(0xbb);<br>
> + LT2.addExtendedOpcode(1, DW_LNE_end_sequence, {});<br>
> + LT2.addExtendedOpcode(9, DW_LNE_set_address, {{0x55667788,<br>
> LineTable::Quad}});<br>
> + LT2.addStandardOpcode(DW_LNS_copy, {});<br>
> + LT2.addByte(0xcc);<br>
> + LT2.addExtendedOpcode(1, DW_LNE_end_sequence, {});<br>
> +<br>
> + generate();<br>
> +<br>
> + auto ExpectedLineTable = Line.getOrParseLineTable(LineData, 0,<br>
> *Context,<br>
> + nullptr,<br>
> RecordRecoverable);<br>
> + ASSERT_TRUE(ExpectedLineTable.operator bool());<br>
> + EXPECT_FALSE(Recoverable);<br>
> + const DWARFDebugLine::LineTable *Expected = *ExpectedLineTable;<br>
> + checkDefaultPrologue(Version, Format, Expected->Prologue, 16);<br>
> + EXPECT_EQ(Expected->Sequences.size(), 1u);<br>
> +<br>
> + uint64_t SecondOffset =<br>
> + Expected->Prologue.sizeofTotalLength() + Expected-<br>
> >Prologue.TotalLength;<br>
> + Recoverable = Error::success();<br>
> + auto ExpectedLineTable2 = Line.getOrParseLineTable(<br>
> + LineData, SecondOffset, *Context, nullptr, RecordRecoverable);<br>
> + ASSERT_TRUE(ExpectedLineTable2.operator bool());<br>
> + EXPECT_FALSE(Recoverable);<br>
> + const DWARFDebugLine::LineTable *Expected2 = *ExpectedLineTable2;<br>
> + checkDefaultPrologue(Version, Format, Expected2->Prologue, 32);<br>
> + EXPECT_EQ(Expected2->Sequences.size(), 2u);<br>
> +<br>
> + EXPECT_NE(Expected, Expected2);<br>
> +<br>
> + // Check that if the same offset is requested, the exact same pointer<br>
> is<br>
> + // returned.<br>
> + Recoverable = Error::success();<br>
> + auto ExpectedLineTable3 = Line.getOrParseLineTable(<br>
> + LineData, 0, *Context, nullptr, RecordRecoverable);<br>
> + ASSERT_TRUE(ExpectedLineTable3.operator bool());<br>
> + EXPECT_FALSE(Recoverable);<br>
> + EXPECT_EQ(Expected, *ExpectedLineTable3);<br>
> +<br>
> + Recoverable = Error::success();<br>
> + auto ExpectedLineTable4 = Line.getOrParseLineTable(<br>
> + LineData, SecondOffset, *Context, nullptr, RecordRecoverable);<br>
> + ASSERT_TRUE(ExpectedLineTable4.operator bool());<br>
> + EXPECT_FALSE(Recoverable);<br>
> + EXPECT_EQ(Expected2, *ExpectedLineTable4);<br>
> +<br>
> + // TODO: Add tests that show that the body of the programs have been<br>
> read<br>
> + // correctly.<br>
> +}<br>
> +<br>
> +TEST_F(DebugLineBasicFixture, ErrorForReservedLength) {<br>
> + if (!setupGenerator())<br>
> + return;<br>
> +<br>
> + LineTable < = Gen->addLineTable();<br>
> + LT.setCustomPrologue({{0xfffffff0, LineTable::Long}});<br>
> +<br>
> + generate();<br>
> +<br>
> + checkGetOrParseLineTableEmitsFatalError(<br>
> + "parsing line table prologue at offset 0x00000000 unsupported<br>
> reserved "<br>
> + "unit length found of value 0xfffffff0");<br>
> +}<br>
> +<br>
> +TEST_F(DebugLineBasicFixture, ErrorForLowVersion) {<br>
> + if (!setupGenerator())<br>
> + return;<br>
> +<br>
> + LineTable < = Gen->addLineTable();<br>
> + LT.setCustomPrologue(<br>
> + {{LineTable::Half, LineTable::Long}, {1, LineTable::Half}});<br>
> +<br>
> + generate();<br>
> +<br>
> + checkGetOrParseLineTableEmitsFatalError(<br>
> + "parsing line table prologue at offset "<br>
> + "0x00000000 found unsupported version "<br>
> + "0x01");<br>
> +}<br>
> +<br>
> +TEST_F(DebugLineBasicFixture, ErrorForInvalidV5IncludeDirTable) {<br>
> + if (!setupGenerator(5))<br>
> + return;<br>
> +<br>
> + LineTable < = Gen->addLineTable();<br>
> + LT.setCustomPrologue({<br>
> + {19, LineTable::Long}, // unit length<br>
> + {5, LineTable::Half}, // version<br>
> + {8, LineTable::Byte}, // addr size<br>
> + {0, LineTable::Byte}, // segment selector size<br>
> + {11, LineTable::Long}, // prologue length<br>
> + {1, LineTable::Byte}, // min instruction length<br>
> + {1, LineTable::Byte}, // max ops per instruction<br>
> + {1, LineTable::Byte}, // default is_stmt<br>
> + {0, LineTable::Byte}, // line base<br>
> + {14, LineTable::Byte}, // line range<br>
> + {2, LineTable::Byte}, // opcode base (small to reduce the amount<br>
> of<br>
> + // setup required).<br>
> + {0, LineTable::Byte}, // standard opcode lengths<br>
> + {0, LineTable::Byte}, // directory entry format count (should not<br>
> be<br>
> + // zero).<br>
> + {0, LineTable::ULEB}, // directories count<br>
> + {0, LineTable::Byte}, // file name entry format count<br>
> + {0, LineTable::ULEB} // file name entry count<br>
> + });<br>
> +<br>
> + generate();<br>
> +<br>
> + checkGetOrParseLineTableEmitsFatalError(<br>
> + {"parsing line table prologue at 0x00000000 found an invalid<br>
> directory "<br>
> + "or file table description at 0x00000014",<br>
> + "failed to parse entry content descriptions because no path was<br>
> found"});<br>
> +}<br>
> +<br>
> +TEST_P(DebugLineParameterisedFixture, ErrorForTooLargePrologueLength) {<br>
> + if (!setupGenerator(Version))<br>
> + return;<br>
> +<br>
> + SCOPED_TRACE("Checking Version " + std::to_string(Version) + ", Format<br>
> " +<br>
> + (Format == DWARF64 ? "DWARF64" : "DWARF32"));<br>
> +<br>
> + LineTable < = Gen->addLineTable(Format);<br>
> + DWARFDebugLine::Prologue Prologue = LT.createBasicPrologue();<br>
> + ++Prologue.PrologueLength;<br>
> + LT.setPrologue(Prologue);<br>
> +<br>
> + generate();<br>
> +<br>
> + uint64_t ExpectedEnd =<br>
> + Prologue.TotalLength + 1 + Prologue.sizeofTotalLength();<br>
> + checkGetOrParseLineTableEmitsFatalError(<br>
> + (Twine("parsing line table prologue at 0x00000000 should have ended<br>
> at "<br>
> + "0x000000") +<br>
> + Twine::utohexstr(ExpectedEnd) + " but it ended at 0x000000" +<br>
> + Twine::utohexstr(ExpectedEnd - 1))<br>
> + .str());<br>
> +}<br>
> +<br>
> +TEST_P(DebugLineParameterisedFixture, ErrorForTooShortPrologueLength) {<br>
> + if (!setupGenerator(Version))<br>
> + return;<br>
> +<br>
> + SCOPED_TRACE("Checking Version " + std::to_string(Version) + ", Format<br>
> " +<br>
> + (Format == DWARF64 ? "DWARF64" : "DWARF32"));<br>
> +<br>
> + LineTable < = Gen->addLineTable(Format);<br>
> + DWARFDebugLine::Prologue Prologue = LT.createBasicPrologue();<br>
> + // FIXME: Ideally, we'd test for 1 less than expected, but the code<br>
> does not<br>
> + // currently fail if missing only the terminator of a v2-4 file table.<br>
> + if (Version < 5)<br>
> + Prologue.PrologueLength -= 2;<br>
> + else<br>
> + Prologue.PrologueLength -= 1;<br>
> + LT.setPrologue(Prologue);<br>
> +<br>
> + generate();<br>
> +<br>
> + uint64_t ExpectedEnd =<br>
> + Prologue.TotalLength - 1 + Prologue.sizeofTotalLength();<br>
> + if (Version < 5)<br>
> + --ExpectedEnd;<br>
> + checkGetOrParseLineTableEmitsFatalError(<br>
> + (Twine("parsing line table prologue at 0x00000000 should have ended<br>
> at "<br>
> + "0x000000") +<br>
> + Twine::utohexstr(ExpectedEnd) + " but it ended at 0x000000" +<br>
> + Twine::utohexstr(ExpectedEnd + 1))<br>
> + .str());<br>
> +}<br>
> +<br>
> +INSTANTIATE_TEST_CASE_P(<br>
> + LineTableTestParams, DebugLineParameterisedFixture,<br>
> + Values(std::make_pair(<br>
> + 2, DWARF32), // Test lower-bound of v2-3 fields and<br>
> DWARF32.<br>
> + std::make_pair(3, DWARF32), // Test upper-bound of v2-3<br>
> fields.<br>
> + std::make_pair(4, DWARF64), // Test v4 fields and DWARF64.<br>
> + std::make_pair(5, DWARF32), std::make_pair(5, DWARF64)), );<br>
> +<br>
> +TEST_F(DebugLineBasicFixture, ErrorForInvalidExtendedOpcodeLength) {<br>
> + if (!setupGenerator())<br>
> + return;<br>
> +<br>
> + LineTable < = Gen->addLineTable();<br>
> + // The Length should be 1 for an end sequence opcode.<br>
> + LT.addExtendedOpcode(2, DW_LNE_end_sequence, {});<br>
> +<br>
> + generate();<br>
> +<br>
> + checkGetOrParseLineTableEmitsFatalError(<br>
> + "unexpected line op length at offset "<br>
> + "0x00000030 expected 0x02 found 0x01");<br>
> +}<br>
> +<br>
> +TEST_F(DebugLineBasicFixture, ErrorForUnitLengthTooLarge) {<br>
> + if (!setupGenerator())<br>
> + return;<br>
> +<br>
> + LineTable &Padding = Gen->addLineTable();<br>
> + // Add some padding to show that a non-zero offset is handled<br>
> correctly.<br>
> + Padding.setCustomPrologue({{0, LineTable::Byte}});<br>
> + LineTable < = Gen->addLineTable();<br>
> + LT.addStandardOpcode(DW_LNS_copy, {});<br>
> + LT.addStandardOpcode(DW_LNS_const_add_pc, {});<br>
> + LT.addExtendedOpcode(1, DW_LNE_end_sequence, {});<br>
> + DWARFDebugLine::Prologue Prologue = LT.createBasicPrologue();<br>
> + // Set the total length to 1 higher than the actual length. The program<br>
> body<br>
> + // has size 5.<br>
> + Prologue.TotalLength += 6;<br>
> + LT.setPrologue(Prologue);<br>
> +<br>
> + generate();<br>
> +<br>
> + auto ExpectedLineTable = Line.getOrParseLineTable(LineData, 1,<br>
> *Context,<br>
> + nullptr,<br>
> RecordRecoverable);<br>
> + checkError("line table program with offset 0x00000001 has length<br>
> 0x00000034 "<br>
> + "but only 0x00000033 bytes are available",<br>
> + std::move(Recoverable));<br>
> + ASSERT_THAT_EXPECTED(ExpectedLineTable, Succeeded());<br>
> + EXPECT_EQ((*ExpectedLineTable)->Rows.size(), 2u);<br>
> + EXPECT_EQ((*ExpectedLineTable)->Sequences.size(), 1u);<br>
> +}<br>
> +<br>
> +TEST_F(DebugLineBasicFixture, ErrorForMismatchedAddressSize) {<br>
> + if (!setupGenerator())<br>
> + return;<br>
> +<br>
> + LineTable < = Gen->addLineTable();<br>
> + // The line data extractor expects size 8 (Quad) addresses.<br>
> + LT.addExtendedOpcode(5, DW_LNE_set_address, {{0x11223344,<br>
> LineTable::Long}});<br>
> + LT.addStandardOpcode(DW_LNS_copy, {});<br>
> + LT.addByte(0xaa);<br>
> + LT.addExtendedOpcode(1, DW_LNE_end_sequence, {});<br>
> +<br>
> + generate();<br>
> +<br>
> + checkGetOrParseLineTableEmitsFatalError(<br>
> + "mismatching address size at offset 0x00000030 expected 0x08 found<br>
> 0x04");<br>
> +}<br>
> +<br>
> +TEST_F(DebugLineBasicFixture, CallbackUsedForUnterminatedSequence) {<br>
> + if (!setupGenerator())<br>
> + return;<br>
> +<br>
> + LineTable < = Gen->addLineTable();<br>
> + LT.addExtendedOpcode(9, DW_LNE_set_address,<br>
> + {{0x1122334455667788, LineTable::Quad}});<br>
> + LT.addStandardOpcode(DW_LNS_copy, {});<br>
> + LT.addByte(0xaa);<br>
> + LT.addExtendedOpcode(1, DW_LNE_end_sequence, {});<br>
> + LT.addExtendedOpcode(9, DW_LNE_set_address,<br>
> + {{0x99aabbccddeeff00, LineTable::Quad}});<br>
> + LT.addStandardOpcode(DW_LNS_copy, {});<br>
> + LT.addByte(0xbb);<br>
> + LT.addByte(0xcc);<br>
> +<br>
> + generate();<br>
> +<br>
> + auto ExpectedLineTable = Line.getOrParseLineTable(LineData, 0,<br>
> *Context,<br>
> + nullptr,<br>
> RecordRecoverable);<br>
> + checkError("last sequence in debug line table at offset 0x00000000 is<br>
> not "<br>
> + "terminated",<br>
> + std::move(Recoverable));<br>
> + ASSERT_TRUE(ExpectedLineTable.operator bool());<br>
> + EXPECT_EQ((*ExpectedLineTable)->Rows.size(), 6u);<br>
> + // The unterminated sequence is not added to the sequence list.<br>
> + EXPECT_EQ((*ExpectedLineTable)->Sequences.size(), 1u);<br>
> +}<br>
> +<br>
> +TEST_F(DebugLineBasicFixture, ParserParsesCorrectly) {<br>
> + if (!setupGenerator())<br>
> + return;<br>
> +<br>
> + DWARFDebugLine::SectionParser Parser = setupParser();<br>
> +<br>
> + EXPECT_EQ(Parser.getOffset(), 0u);<br>
> + ASSERT_FALSE(Parser.done());<br>
> +<br>
> + DWARFDebugLine::LineTable Parsed =<br>
> + Parser.parseNext(RecordRecoverable, RecordUnrecoverable);<br>
> + checkDefaultPrologue(4, DWARF32, Parsed.Prologue, 16);<br>
> + EXPECT_EQ(Parsed.Sequences.size(), 1u);<br>
> + EXPECT_EQ(Parser.getOffset(), 62u);<br>
> + ASSERT_FALSE(Parser.done());<br>
> +<br>
> + DWARFDebugLine::LineTable Parsed2 =<br>
> + Parser.parseNext(RecordRecoverable, RecordUnrecoverable);<br>
> + checkDefaultPrologue(4, DWARF64, Parsed2.Prologue, 16);<br>
> + EXPECT_EQ(Parsed2.Sequences.size(), 1u);<br>
> + EXPECT_EQ(Parser.getOffset(), 136u);<br>
> + EXPECT_TRUE(Parser.done());<br>
> +<br>
> + EXPECT_FALSE(Recoverable);<br>
> + EXPECT_FALSE(Unrecoverable);<br>
> +}<br>
> +<br>
> +TEST_F(DebugLineBasicFixture, ParserSkipsCorrectly) {<br>
> + if (!setupGenerator())<br>
> + return;<br>
> +<br>
> + DWARFDebugLine::SectionParser Parser = setupParser();<br>
> +<br>
> + EXPECT_EQ(Parser.getOffset(), 0u);<br>
> + ASSERT_FALSE(Parser.done());<br>
> +<br>
> + Parser.skip(RecordUnrecoverable);<br>
> + EXPECT_EQ(Parser.getOffset(), 62u);<br>
> + ASSERT_FALSE(Parser.done());<br>
> +<br>
> + Parser.skip(RecordUnrecoverable);<br>
> + EXPECT_EQ(Parser.getOffset(), 136u);<br>
> + EXPECT_TRUE(Parser.done());<br>
> +<br>
> + EXPECT_FALSE(Unrecoverable);<br>
> +}<br>
> +<br>
> +TEST_F(DebugLineBasicFixture, ParserAlwaysDoneForEmptySection) {<br>
> + if (!setupGenerator())<br>
> + return;<br>
> +<br>
> + generate();<br>
> + DWARFDebugLine::SectionParser Parser(LineData, *Context, CUs, TUs);<br>
> +<br>
> + EXPECT_TRUE(Parser.done());<br>
> +}<br>
> +<br>
> +TEST_F(DebugLineBasicFixture, ParserMovesToEndForBadLengthWhenParsing) {<br>
> + if (!setupGenerator())<br>
> + return;<br>
> +<br>
> + LineTable < = Gen->addLineTable();<br>
> + LT.setCustomPrologue({{0xfffffff0, LineTable::Long}});<br>
> + Gen->addLineTable();<br>
> + generate();<br>
> +<br>
> + DWARFDebugLine::SectionParser Parser(LineData, *Context, CUs, TUs);<br>
> + Parser.parseNext(RecordRecoverable, RecordUnrecoverable);<br>
> +<br>
> + EXPECT_EQ(Parser.getOffset(), 4u);<br>
> + EXPECT_TRUE(Parser.done());<br>
> + EXPECT_FALSE(Recoverable);<br>
> +<br>
> + checkError("parsing line table prologue at offset 0x00000000<br>
> unsupported "<br>
> + "reserved unit length found of value 0xfffffff0",<br>
> + std::move(Unrecoverable));<br>
> +}<br>
> +<br>
> +TEST_F(DebugLineBasicFixture, ParserMovesToEndForBadLengthWhenSkipping) {<br>
> + if (!setupGenerator())<br>
> + return;<br>
> +<br>
> + LineTable < = Gen->addLineTable();<br>
> + LT.setCustomPrologue({{0xfffffff0, LineTable::Long}});<br>
> + Gen->addLineTable();<br>
> + generate();<br>
> +<br>
> + DWARFDebugLine::SectionParser Parser(LineData, *Context, CUs, TUs);<br>
> + Parser.skip(RecordUnrecoverable);<br>
> +<br>
> + EXPECT_EQ(Parser.getOffset(), 4u);<br>
> + EXPECT_TRUE(Parser.done());<br>
> +<br>
> + checkError("parsing line table prologue at offset 0x00000000<br>
> unsupported "<br>
> + "reserved unit length found of value 0xfffffff0",<br>
> + std::move(Unrecoverable));<br>
> +}<br>
> +<br>
> +TEST_F(DebugLineBasicFixture,<br>
> ParserReportsFirstErrorInEachTableWhenParsing) {<br>
> + if (!setupGenerator())<br>
> + return;<br>
> +<br>
> + LineTable < = Gen->addLineTable(DWARF32);<br>
> + LT.setCustomPrologue({{2, LineTable::Long}, {0, LineTable::Half}});<br>
> + LineTable <2 = Gen->addLineTable(DWARF32);<br>
> + LT2.setCustomPrologue({{2, LineTable::Long}, {1, LineTable::Half}});<br>
> + generate();<br>
> +<br>
> + DWARFDebugLine::SectionParser Parser(LineData, *Context, CUs, TUs);<br>
> + Parser.parseNext(RecordRecoverable, RecordUnrecoverable);<br>
> + ASSERT_FALSE(Parser.done());<br>
> + Parser.parseNext(RecordRecoverable, RecordUnrecoverable);<br>
> +<br>
> + EXPECT_TRUE(Parser.done());<br>
> + EXPECT_FALSE(Recoverable);<br>
> +<br>
> + checkError({"parsing line table prologue at offset 0x00000000 found "<br>
> + "unsupported version 0x00",<br>
> + "parsing line table prologue at offset 0x00000006 found "<br>
> + "unsupported version 0x01"},<br>
> + std::move(Unrecoverable));<br>
> +}<br>
> +<br>
> +TEST_F(DebugLineBasicFixture,<br>
> ParserReportsNonPrologueProblemsWhenParsing) {<br>
> + if (!setupGenerator())<br>
> + return;<br>
> +<br>
> + LineTable < = Gen->addLineTable(DWARF32);<br>
> + LT.addExtendedOpcode(0x42, DW_LNE_end_sequence, {});<br>
> + LineTable <2 = Gen->addLineTable(DWARF32);<br>
> + LT2.addExtendedOpcode(9, DW_LNE_set_address,<br>
> + {{0x1234567890abcdef, LineTable::Quad}});<br>
> + LT2.addStandardOpcode(DW_LNS_copy, {});<br>
> + LT2.addByte(0xbb);<br>
> + generate();<br>
> +<br>
> + DWARFDebugLine::SectionParser Parser(LineData, *Context, CUs, TUs);<br>
> + Parser.parseNext(RecordRecoverable, RecordUnrecoverable);<br>
> + EXPECT_FALSE(Recoverable);<br>
> + ASSERT_FALSE(Parser.done());<br>
> + checkError(<br>
> + "unexpected line op length at offset 0x00000030 expected 0x42 found<br>
> 0x01",<br>
> + std::move(Unrecoverable));<br>
> +<br>
> + // Reset the error state so that it does not confuse the next set of<br>
> checks.<br>
> + Unrecoverable = Error::success();<br>
> + Parser.parseNext(RecordRecoverable, RecordUnrecoverable);<br>
> +<br>
> + EXPECT_TRUE(Parser.done());<br>
> + checkError("last sequence in debug line table at offset 0x00000031 is<br>
> not "<br>
> + "terminated",<br>
> + std::move(Recoverable));<br>
> + EXPECT_FALSE(Unrecoverable);<br>
> +}<br>
> +<br>
> +TEST_F(DebugLineBasicFixture,<br>
> + ParserReportsPrologueErrorsInEachTableWhenSkipping) {<br>
> + if (!setupGenerator())<br>
> + return;<br>
> +<br>
> + LineTable < = Gen->addLineTable(DWARF32);<br>
> + LT.setCustomPrologue({{2, LineTable::Long}, {0, LineTable::Half}});<br>
> + LineTable <2 = Gen->addLineTable(DWARF32);<br>
> + LT2.setCustomPrologue({{2, LineTable::Long}, {1, LineTable::Half}});<br>
> + generate();<br>
> +<br>
> + DWARFDebugLine::SectionParser Parser(LineData, *Context, CUs, TUs);<br>
> + Parser.skip(RecordUnrecoverable);<br>
> + ASSERT_FALSE(Parser.done());<br>
> + Parser.skip(RecordUnrecoverable);<br>
> +<br>
> + EXPECT_TRUE(Parser.done());<br>
> +<br>
> + checkError({"parsing line table prologue at offset 0x00000000 found "<br>
> + "unsupported version 0x00",<br>
> + "parsing line table prologue at offset 0x00000006 found "<br>
> + "unsupported version 0x01"},<br>
> + std::move(Unrecoverable));<br>
> +}<br>
> +<br>
> +TEST_F(DebugLineBasicFixture, ParserIgnoresNonPrologueErrorsWhenSkipping)<br>
> {<br>
> + if (!setupGenerator())<br>
> + return;<br>
> +<br>
> + LineTable < = Gen->addLineTable(DWARF32);<br>
> + LT.addExtendedOpcode(42, DW_LNE_end_sequence, {});<br>
> + generate();<br>
> +<br>
> + DWARFDebugLine::SectionParser Parser(LineData, *Context, CUs, TUs);<br>
> + Parser.skip(RecordUnrecoverable);<br>
> +<br>
> + EXPECT_TRUE(Parser.done());<br>
> + EXPECT_FALSE(Unrecoverable);<br>
> +}<br>
> +<br>
> +TEST_F(DebugLineBasicFixture, ParserPrintsStandardOpcodesWhenRequested) {<br>
> + if (!setupGenerator())<br>
> + return;<br>
> +<br>
> + using ValLen = dwarfgen::LineTable::ValueAndLength;<br>
> + LineTable < = Gen->addLineTable(DWARF32);<br>
> + LT.addStandardOpcode(DW_LNS_copy, {});<br>
> + LT.addStandardOpcode(DW_LNS_advance_pc, {ValLen{11, LineTable::ULEB}});<br>
> + LT.addStandardOpcode(DW_LNS_advance_line, {ValLen{22,<br>
> LineTable::SLEB}});<br>
> + LT.addStandardOpcode(DW_LNS_set_file, {ValLen{33, LineTable::ULEB}});<br>
> + LT.addStandardOpcode(DW_LNS_set_column, {ValLen{44, LineTable::ULEB}});<br>
> + LT.addStandardOpcode(DW_LNS_negate_stmt, {});<br>
> + LT.addStandardOpcode(DW_LNS_set_basic_block, {});<br>
> + LT.addStandardOpcode(DW_LNS_const_add_pc, {});<br>
> + LT.addStandardOpcode(DW_LNS_fixed_advance_pc, {ValLen{55,<br>
> LineTable::Half}});<br>
> + LT.addStandardOpcode(DW_LNS_set_prologue_end, {});<br>
> + LT.addStandardOpcode(DW_LNS_set_epilogue_begin, {});<br>
> + LT.addStandardOpcode(DW_LNS_set_isa, {ValLen{66, LineTable::ULEB}});<br>
> + LT.addExtendedOpcode(1, DW_LNE_end_sequence, {});<br>
> + generate();<br>
> +<br>
> + DWARFDebugLine::SectionParser Parser(LineData, *Context, CUs, TUs);<br>
> + std::string Output;<br>
> + raw_string_ostream OS(Output);<br>
> + Parser.parseNext(RecordRecoverable, RecordUnrecoverable, &OS);<br>
> + OS.flush();<br>
> +<br>
> + EXPECT_FALSE(Recoverable);<br>
> + EXPECT_FALSE(Unrecoverable);<br>
> + auto InOutput = [&Output](char const *Str) {<br>
> + return Output.find(Str) != std::string::npos;<br>
> + };<br>
> + EXPECT_TRUE(InOutput("0x0000002e: 01 DW_LNS_copy\n")) << Output;<br>
> + EXPECT_TRUE(InOutput("0x0000002f: 02 DW_LNS_advance_pc (11)\n")) <<<br>
> Output;<br>
> + // FIXME: The value printed after DW_LNS_advance_line is currently the<br>
> result<br>
> + // of the advance, but it should be the value being advanced by. See<br>
> + // <a href="https://bugs.llvm.org/show_bug.cgi?id=44261" rel="noreferrer" target="_blank">https://bugs.llvm.org/show_bug.cgi?id=44261</a> for details.<br>
> + EXPECT_TRUE(InOutput("0x00000031: 03 DW_LNS_advance_line (23)\n")) <<<br>
> Output;<br>
> + EXPECT_TRUE(InOutput("0x00000033: 04 DW_LNS_set_file (33)\n")) <<<br>
> Output;<br>
> + EXPECT_TRUE(InOutput("0x00000035: 05 DW_LNS_set_column (44)\n")) <<<br>
> Output;<br>
> + EXPECT_TRUE(InOutput("0x00000037: 06 DW_LNS_negate_stmt\n")) << Output;<br>
> + EXPECT_TRUE(InOutput("0x00000038: 07 DW_LNS_set_basic_block\n")) <<<br>
> Output;<br>
> + EXPECT_TRUE(<br>
> + InOutput("0x00000039: 08 DW_LNS_const_add_pc<br>
> (0x0000000000000011)\n"))<br>
> + << Output;<br>
> + EXPECT_TRUE(InOutput("0x0000003a: 09 DW_LNS_fixed_advance_pc<br>
> (0x0037)\n"))<br>
> + << Output;<br>
> + EXPECT_TRUE(InOutput("0x0000003d: 0a DW_LNS_set_prologue_end\n")) <<<br>
> Output;<br>
> + EXPECT_TRUE(InOutput("0x0000003e: 0b DW_LNS_set_epilogue_begin\n")) <<<br>
> Output;<br>
> + EXPECT_TRUE(InOutput("0x0000003f: 0c DW_LNS_set_isa (66)\n")) <<<br>
> Output;<br>
> +}<br>
> +<br>
> +} // end anonymous namespace<br>
> <br>
> <br>
> <br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>