<div dir="ltr">Please describe in the commit message why a patch is being reverted.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Mar 20, 2020 at 4:28 PM Adrian Prantl via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Adrian Prantl<br>
Date: 2020-03-20T16:27:23-07:00<br>
New Revision: bde15de3cabff6363008e67a999e6e4559743867<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/bde15de3cabff6363008e67a999e6e4559743867" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/bde15de3cabff6363008e67a999e6e4559743867</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/bde15de3cabff6363008e67a999e6e4559743867.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/bde15de3cabff6363008e67a999e6e4559743867.diff</a><br>
<br>
LOG: Revert "Allow remapping the sysroot with -fdebug-prefix-map."<br>
<br>
This reverts commit 6725c4836a5b3c11227869a6f456019a244aa29f.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
clang/lib/CodeGen/CGDebugInfo.cpp<br>
clang/test/CodeGen/debug-prefix-map.c<br>
llvm/lib/DWARFLinker/DWARFLinker.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff --git a/clang/lib/CodeGen/CGDebugInfo.cpp b/clang/lib/CodeGen/CGDebugInfo.cpp<br>
index da6cb458982b..a98d82f7152c 100644<br>
--- a/clang/lib/CodeGen/CGDebugInfo.cpp<br>
+++ b/clang/lib/CodeGen/CGDebugInfo.cpp<br>
@@ -631,7 +631,7 @@ void CGDebugInfo::CreateCompileUnit() {<br>
? llvm::DICompileUnit::DebugNameTableKind::None<br>
: static_cast<llvm::DICompileUnit::DebugNameTableKind>(<br>
CGOpts.DebugNameTable),<br>
- CGOpts.DebugRangesBaseAddress, remapDIPath(Sysroot), SDK);<br>
+ CGOpts.DebugRangesBaseAddress, Sysroot, SDK);<br>
}<br>
<br>
llvm::DIType *CGDebugInfo::CreateType(const BuiltinType *BT) {<br>
<br>
diff --git a/clang/test/CodeGen/debug-prefix-map.c b/clang/test/CodeGen/debug-prefix-map.c<br>
index 354110d1b0da..5366e19447ae 100644<br>
--- a/clang/test/CodeGen/debug-prefix-map.c<br>
+++ b/clang/test/CodeGen/debug-prefix-map.c<br>
@@ -2,7 +2,6 @@<br>
// RUN: %clang_cc1 -debug-info-kind=standalone -fdebug-prefix-map=%p=/UNLIKELY_PATH=empty %s -emit-llvm -o - | FileCheck %s -check-prefix CHECK-EVIL<br>
// RUN: %clang_cc1 -debug-info-kind=standalone -fdebug-prefix-map=%p=/UNLIKELY_PATH/empty %s -emit-llvm -o - -main-file-name debug-prefix-map.c | FileCheck %s<br>
// RUN: %clang_cc1 -debug-info-kind=standalone -fdebug-prefix-map=%p=/UNLIKELY_PATH/empty %s -emit-llvm -o - -fdebug-compilation-dir %p | FileCheck %s -check-prefix CHECK-COMPILATION-DIR<br>
-// RUN: %clang_cc1 -debug-info-kind=standalone -fdebug-prefix-map=%p=/UNLIKELY_PATH/empty %s -emit-llvm -o - -isysroot %p -debugger-tuning=lldb | FileCheck %s -check-prefix CHECK-SYSROOT<br>
// RUN: %clang -g -fdebug-prefix-map=%p=/UNLIKELY_PATH/empty -S -c %s -emit-llvm -o - | FileCheck %s<br>
// RUN: %clang -g -ffile-prefix-map=%p=/UNLIKELY_PATH/empty -S -c %s -emit-llvm -o - | FileCheck %s<br>
<br>
@@ -41,4 +40,3 @@ void test_rewrite_includes() {<br>
// CHECK-COMPILATION-DIR: !DIFile(filename: "{{.*}}", directory: "/UNLIKELY_PATH/empty")<br>
// CHECK-COMPILATION-DIR: !DIFile(filename: "{{.*}}Inputs/stdio.h", directory: "/UNLIKELY_PATH/empty")<br>
// CHECK-COMPILATION-DIR-NOT: !DIFile(filename:<br>
-// CHECK-SYSROOT: !DICompileUnit({{.*}}sysroot: "/UNLIKELY_PATH/empty"<br>
<br>
diff --git a/llvm/lib/DWARFLinker/DWARFLinker.cpp b/llvm/lib/DWARFLinker/DWARFLinker.cpp<br>
index fbc3a3e60cc9..8464c04f801e 100644<br>
--- a/llvm/lib/DWARFLinker/DWARFLinker.cpp<br>
+++ b/llvm/lib/DWARFLinker/DWARFLinker.cpp<br>
@@ -1914,15 +1914,6 @@ static uint64_t getDwoId(const DWARFDie &CUDie, const DWARFUnit &Unit) {<br>
return 0;<br>
}<br>
<br>
-static std::string remapPath(std::string Path,<br>
- const objectPrefixMap &ObjectPrefixMap) {<br>
- StringRef PathRef(Path);<br>
- for (const auto &Entry : ObjectPrefixMap)<br>
- if (PathRef.startswith(Entry.first))<br>
- return (Twine(Entry.second) + PathRef.substr(Entry.first.size())).str();<br>
- return Path;<br>
-}<br>
-<br>
bool DWARFLinker::registerModuleReference(<br>
DWARFDie CUDie, const DWARFUnit &Unit, const DwarfFile &File,<br>
OffsetsStringPool &StringPool, UniquingStringPool &UniquingStringPool,<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>