<div dir="ltr">Please add a test for this. (likely an existing test probably covers this error message, but it should be updated to test for the specific message)</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Feb 19, 2020 at 6:19 PM Sourabh Singh Tomar via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Sourabh Singh Tomar<br>
Date: 2020-02-20T07:49:08+05:30<br>
New Revision: 84fc1233d9a47cd7b6e681b4573d9abbc779dd2b<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/84fc1233d9a47cd7b6e681b4573d9abbc779dd2b" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/84fc1233d9a47cd7b6e681b4573d9abbc779dd2b</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/84fc1233d9a47cd7b6e681b4573d9abbc779dd2b.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/84fc1233d9a47cd7b6e681b4573d9abbc779dd2b.diff</a><br>
<br>
LOG: [DebugInfo][NFCI]: Removed an exclamation mark from error message.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/tools/llvm-dwp/llvm-dwp.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/llvm/tools/llvm-dwp/llvm-dwp.cpp b/llvm/tools/llvm-dwp/llvm-dwp.cpp<br>
index f437063d1921..4eff8476d61f 100644<br>
--- a/llvm/tools/llvm-dwp/llvm-dwp.cpp<br>
+++ b/llvm/tools/llvm-dwp/llvm-dwp.cpp<br>
@@ -155,7 +155,7 @@ static Expected<CompileUnitIdentifiers> getCUIdentifiers(StringRef Abbrev,<br>
       return make_error<DWPError>(<br>
           std::string("unit type DW_UT_split_compile type not found in "<br>
                       "debug_info header. Unexpected unit type 0x" +<br>
-                      utostr(UnitType) + " found!"));<br>
+                      utostr(UnitType) + " found"));<br>
   }<br>
   InfoData.getU32(&Offset); // Abbrev offset (should be zero)<br>
   uint8_t AddrSize = InfoData.getU8(&Offset);<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>