<div dir="ltr"><div>Yep - flubbed the copy/paste somehow:</div><div>d8061456bcc111c0f4f7806d84283ae78c7b3e30</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Mar 18, 2020 at 7:00 PM Philip Reames <<a href="mailto:listmail@philipreames.com">listmail@philipreames.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
On 3/18/20 2:17 PM, Sanjay Patel via llvm-commits wrote:<br>
> Author: Sanjay Patel<br>
> Date: 2020-03-18T17:17:20-04:00<br>
> New Revision: faba1d034a046305a3a7902e1753bf5dfc4f686e<br>
><br>
> URL: <a href="https://github.com/llvm/llvm-project/commit/faba1d034a046305a3a7902e1753bf5dfc4f686e" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/faba1d034a046305a3a7902e1753bf5dfc4f686e</a><br>
> DIFF: <a href="https://github.com/llvm/llvm-project/commit/faba1d034a046305a3a7902e1753bf5dfc4f686e.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/faba1d034a046305a3a7902e1753bf5dfc4f686e.diff</a><br>
><br>
> LOG: [LangRef] add explanatory text for select poison semantics (PR20895)<br>
><br>
> This is copied from the suggested text by @regehr in:<br>
> <a href="https://bugs.llvm.org/show_bug.cgi?id=20895" rel="noreferrer" target="_blank">https://bugs.llvm.org/show_bug.cgi?id=20895</a><br>
><br>
> The way forward was not clear for several years, but now that we<br>
> have 'freeze' and Alive2, the behavior should be documented.<br>
> Also see comments in D76332.<br>
><br>
> Added:<br>
>      <br>
><br>
> Modified:<br>
>      llvm/docs/LangRef.rst<br>
><br>
> Removed:<br>
>      <br>
><br>
><br>
> ################################################################################<br>
> diff  --git a/llvm/docs/LangRef.rst b/llvm/docs/LangRef.rst<br>
> index 3d1f9d388319..19f3c3b1d7a3 100644<br>
> --- a/llvm/docs/LangRef.rst<br>
> +++ b/llvm/docs/LangRef.rst<br>
> @@ -3478,9 +3478,12 @@ the ``nsw`` flag.<br>
>   <br>
>   Poison value behavior is defined in terms of value *dependence*:<br>
>   <br>
> --  Values other than :ref:`phi <i_phi>` nodes depend on their operands.<br>
> +-  Values other than :ref:`phi <i_phi>` nodes and :ref:`select <i_select>'<br>
> +   instructions depend on their operands.<br>
>   -  :ref:`Phi <i_phi>` nodes depend on the operand corresponding to<br>
>      their dynamic predecessor basic block.<br>
> +-  Select instructions depend on their condition operand and their<br>
> +   select operand.<br>
I think you might have meant "selected operand"?  If not, this sentence <br>
doesn't really parse for me.<br>
>   -  Function arguments depend on the corresponding actual argument values<br>
>      in the dynamic callers of their functions.<br>
>   -  :ref:`Call <i_call>` instructions depend on the :ref:`ret <i_ret>`<br>
><br>
><br>
>          <br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>